Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixed vendor:publish tag name#11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ousid merged 1 commit intocoderflexx:mainfromaskdkc:main
Oct 12, 2022
Merged

Conversation

@askdkc
Copy link
Contributor

When you use custom view namespace in spatie laravel-package-tools, you need to use your custom namespace for your published view's tag name. This PR is fix for that.

@askdkcaskdkc mentioned this pull requestOct 11, 2022
@ousid
Copy link
Member

Hey,@askdkc

Is publishing withcsv-views tag doesn't work?

@askdkc
Copy link
ContributorAuthor

@ousid

I fixed laravel-package-tools bug with thisPR. Which will change tag name if you use custom view namespace. Your code is using custom namespace thus you need to fix your tag name.

@askdkc
Copy link
ContributorAuthor

@ousid just try your code by yourself and check out what outputs your vendor:publish makes. You should see it by yourself.

@ousid
Copy link
Member

ousid commentedOct 12, 2022
edited
Loading

@askdkc, The published files are works just fine.

This package uses^1.9.2, and your PR was merged for^1.13.6. So, I don't think it will affect this package for now, Or I am missing something?

Edit: Sorry, I didn't see yourcomment on the#8, and I didn't testlaravel-csv-views tag also. Yeah, you're right.

Thanks for the PR, and Resolving the both issues!

@askdkc
Copy link
ContributorAuthor

askdkc commentedOct 12, 2022
edited
Loading

@ousid

just try installing your package to newly created laravel project like this.

laravel new laravelcsv(or  composer create-project laravel/laravel --prefer-dist laravelcsv)cd laravecsvcomposer require coderflex/laravel-csvphp artisan vendor:publish --tag="csv-views"

And you get this:

    INFO  No publishable resourcesfor tag [csv-views].

You see?No publishable resources for tag [csv-views].

ousid reacted with thumbs up emoji

@ousidousid merged commitb001a25 intocoderflexx:mainOct 12, 2022
@ousid
Copy link
Member

@ousid

just try installing your package to newly created laravel project like this.

laravel new laravelcsvcd laravecsvcomposer require coderflex/laravel-csvphp artisan vendor:publish --tag="csv-views"

And you get this:

    INFO  No publishable resourcesfor tag [csv-views].

You see?No publishable resources for tag [csv-views].

Yep, I realized it just after I see the comment in the mentioned issue above.

@askdkc
Copy link
ContributorAuthor

@ousid
Thank you for your understanding👍

But hopefully you should test it before asking questions. I kinda hate repeating myself.
Trying to help here😅

ousid reacted with laugh emoji

@ousid
Copy link
Member

@askdkc

I tested all the published files except theviews 😅

Thanks again for your PR's and enhancing this package for the better

@askdkc
Copy link
ContributorAuthor

@ousid
This bug is tough to fix to begin with, I guess. Coz there is nothing wrong with your package but rather, other package is causing this issue. Anyway, it's nice to see it gets resolved.

Have a great day.

ousid reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@askdkc@ousid

[8]ページ先頭

©2009-2025 Movatter.jp