- Notifications
You must be signed in to change notification settings - Fork7
Fixed vendor:publish tag name#11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
ousid commentedOct 11, 2022
Hey,@askdkc Is publishing with |
askdkc commentedOct 11, 2022
askdkc commentedOct 11, 2022
@ousid just try your code by yourself and check out what outputs your vendor:publish makes. You should see it by yourself. |
ousid commentedOct 12, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@askdkc, The published files are works just fine. This package uses Edit: Sorry, I didn't see yourcomment on the#8, and I didn't test Thanks for the PR, and Resolving the both issues! |
askdkc commentedOct 12, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
just try installing your package to newly created laravel project like this. laravel new laravelcsv(or composer create-project laravel/laravel --prefer-dist laravelcsv)cd laravecsvcomposer require coderflex/laravel-csvphp artisan vendor:publish --tag="csv-views" And you get this: INFO No publishable resourcesfor tag [csv-views].You see?No publishable resources for tag [csv-views]. |
ousid commentedOct 12, 2022
Yep, I realized it just after I see the comment in the mentioned issue above. |
askdkc commentedOct 12, 2022
@ousid But hopefully you should test it before asking questions. I kinda hate repeating myself. |
ousid commentedOct 12, 2022
I tested all the published files except the Thanks again for your PR's and enhancing this package for the better |
askdkc commentedOct 12, 2022
@ousid Have a great day. |
When you use custom view namespace in spatie laravel-package-tools, you need to use your custom namespace for your published view's tag name. This PR is fix for that.