Commitfa41b90

kiryl

authored and

torvalds

committed

mm/thp: do not wait for lock_page() in deferred_split_scan()

deferred_split_scan() gets called from reclaim path. Waiting for pagelock may lead to deadlock there.Replace lock_page() with trylock_page() and skip the page if we failedto lock it. We will get to the page on the next scan.Link:http://lkml.kernel.org/r/20180315150747.31945-1-kirill.shutemov@linux.intel.comFixes:9a98225 ("thp: introduce deferred_split_huge_page()")Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>Acked-by: Michal Hocko <mhocko@suse.com>Cc: <stable@vger.kernel.org>Signed-off-by: Andrew Morton <akpm@linux-foundation.org>Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

1 parentfece202 commitfa41b90Copy full SHA for fa41b90

File tree

1 file changed

-1

lines changed

mm
- huge_memory.c

1 file changed

-1

lines changed

`‎mm/huge_memory.c‎`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2783,11 +2783,13 @@ static unsigned long deferred_split_scan(struct shrinker *shrink,`
`2783`	`2783`
`2784`	`2784`	`list_for_each_safe(pos,next,&list) {`
`2785`	`2785`	`page=list_entry((void*)pos,structpage,mapping);`
`2786`		`-lock_page(page);`
	`2786`	`+if (!trylock_page(page))`
	`2787`	`+gotonext;`
`2787`	`2788`	`/* split_huge_page() removes page from list on success */`
`2788`	`2789`	`if (!split_huge_page(page))`
`2789`	`2790`	`split++;`
`2790`	`2791`	`unlock_page(page);`
	`2792`	`+next:`
`2791`	`2793`	`put_page(page);`
`2792`	`2794`	`}`
`2793`	`2795`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitfa41b90

File tree

1 file changed

1 file changed

`‎mm/huge_memory.c‎`

0 commit comments