Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
forked fromtorvalds/linux

Commite400671

Browse files
andy-shevickle
authored andcommitted
i915: Re-use DEFINE_SHOW_ATTRIBUTE() macro
...instead of open coding file operations followed by custom ->open()callbacks per each attribute.Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>Link:https://patchwork.freedesktop.org/patch/msgid/20180316141213.38774-1-andriy.shevchenko@linux.intel.com
1 parent1947fd1 commite400671

File tree

2 files changed

+12
-77
lines changed

2 files changed

+12
-77
lines changed

‎drivers/gpu/drm/i915/gvt/debugfs.c‎

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -122,18 +122,7 @@ static int vgpu_mmio_diff_show(struct seq_file *s, void *unused)
122122
seq_printf(s,"Total: %d, Diff: %d\n",param.total,param.diff);
123123
return0;
124124
}
125-
126-
staticintvgpu_mmio_diff_open(structinode*inode,structfile*file)
127-
{
128-
returnsingle_open(file,vgpu_mmio_diff_show,inode->i_private);
129-
}
130-
131-
staticconststructfile_operationsvgpu_mmio_diff_fops= {
132-
.open=vgpu_mmio_diff_open,
133-
.read=seq_read,
134-
.llseek=seq_lseek,
135-
.release=single_release,
136-
};
125+
DEFINE_SHOW_ATTRIBUTE(vgpu_mmio_diff);
137126

138127
/**
139128
* intel_gvt_debugfs_add_vgpu - register debugfs entries for a vGPU

‎drivers/gpu/drm/i915/i915_debugfs.c‎

Lines changed: 11 additions & 65 deletions
Original file line numberDiff line numberDiff line change
@@ -3562,7 +3562,8 @@ static ssize_t i915_displayport_test_active_write(struct file *file,
35623562

35633563
staticinti915_displayport_test_active_show(structseq_file*m,void*data)
35643564
{
3565-
structdrm_device*dev=m->private;
3565+
structdrm_i915_private*dev_priv=m->private;
3566+
structdrm_device*dev=&dev_priv->drm;
35663567
structdrm_connector*connector;
35673568
structdrm_connector_list_iterconn_iter;
35683569
structintel_dp*intel_dp;
@@ -3596,10 +3597,8 @@ static int i915_displayport_test_active_show(struct seq_file *m, void *data)
35963597
staticinti915_displayport_test_active_open(structinode*inode,
35973598
structfile*file)
35983599
{
3599-
structdrm_i915_private*dev_priv=inode->i_private;
3600-
36013600
returnsingle_open(file,i915_displayport_test_active_show,
3602-
&dev_priv->drm);
3601+
inode->i_private);
36033602
}
36043603

36053604
staticconststructfile_operationsi915_displayport_test_active_fops= {
@@ -3613,7 +3612,8 @@ static const struct file_operations i915_displayport_test_active_fops = {
36133612

36143613
staticinti915_displayport_test_data_show(structseq_file*m,void*data)
36153614
{
3616-
structdrm_device*dev=m->private;
3615+
structdrm_i915_private*dev_priv=m->private;
3616+
structdrm_device*dev=&dev_priv->drm;
36173617
structdrm_connector*connector;
36183618
structdrm_connector_list_iterconn_iter;
36193619
structintel_dp*intel_dp;
@@ -3652,26 +3652,12 @@ static int i915_displayport_test_data_show(struct seq_file *m, void *data)
36523652

36533653
return0;
36543654
}
3655-
staticinti915_displayport_test_data_open(structinode*inode,
3656-
structfile*file)
3657-
{
3658-
structdrm_i915_private*dev_priv=inode->i_private;
3659-
3660-
returnsingle_open(file,i915_displayport_test_data_show,
3661-
&dev_priv->drm);
3662-
}
3663-
3664-
staticconststructfile_operationsi915_displayport_test_data_fops= {
3665-
.owner=THIS_MODULE,
3666-
.open=i915_displayport_test_data_open,
3667-
.read=seq_read,
3668-
.llseek=seq_lseek,
3669-
.release=single_release
3670-
};
3655+
DEFINE_SHOW_ATTRIBUTE(i915_displayport_test_data);
36713656

36723657
staticinti915_displayport_test_type_show(structseq_file*m,void*data)
36733658
{
3674-
structdrm_device*dev=m->private;
3659+
structdrm_i915_private*dev_priv=m->private;
3660+
structdrm_device*dev=&dev_priv->drm;
36753661
structdrm_connector*connector;
36763662
structdrm_connector_list_iterconn_iter;
36773663
structintel_dp*intel_dp;
@@ -3698,23 +3684,7 @@ static int i915_displayport_test_type_show(struct seq_file *m, void *data)
36983684

36993685
return0;
37003686
}
3701-
3702-
staticinti915_displayport_test_type_open(structinode*inode,
3703-
structfile*file)
3704-
{
3705-
structdrm_i915_private*dev_priv=inode->i_private;
3706-
3707-
returnsingle_open(file,i915_displayport_test_type_show,
3708-
&dev_priv->drm);
3709-
}
3710-
3711-
staticconststructfile_operationsi915_displayport_test_type_fops= {
3712-
.owner=THIS_MODULE,
3713-
.open=i915_displayport_test_type_open,
3714-
.read=seq_read,
3715-
.llseek=seq_lseek,
3716-
.release=single_release
3717-
};
3687+
DEFINE_SHOW_ATTRIBUTE(i915_displayport_test_type);
37183688

37193689
staticvoidwm_latency_show(structseq_file*m,constuint16_twm[8])
37203690
{
@@ -4875,19 +4845,7 @@ static int i915_dpcd_show(struct seq_file *m, void *data)
48754845

48764846
return0;
48774847
}
4878-
4879-
staticinti915_dpcd_open(structinode*inode,structfile*file)
4880-
{
4881-
returnsingle_open(file,i915_dpcd_show,inode->i_private);
4882-
}
4883-
4884-
staticconststructfile_operationsi915_dpcd_fops= {
4885-
.owner=THIS_MODULE,
4886-
.open=i915_dpcd_open,
4887-
.read=seq_read,
4888-
.llseek=seq_lseek,
4889-
.release=single_release,
4890-
};
4848+
DEFINE_SHOW_ATTRIBUTE(i915_dpcd);
48914849

48924850
staticinti915_panel_show(structseq_file*m,void*data)
48934851
{
@@ -4909,19 +4867,7 @@ static int i915_panel_show(struct seq_file *m, void *data)
49094867

49104868
return0;
49114869
}
4912-
4913-
staticinti915_panel_open(structinode*inode,structfile*file)
4914-
{
4915-
returnsingle_open(file,i915_panel_show,inode->i_private);
4916-
}
4917-
4918-
staticconststructfile_operationsi915_panel_fops= {
4919-
.owner=THIS_MODULE,
4920-
.open=i915_panel_open,
4921-
.read=seq_read,
4922-
.llseek=seq_lseek,
4923-
.release=single_release,
4924-
};
4870+
DEFINE_SHOW_ATTRIBUTE(i915_panel);
49254871

49264872
/**
49274873
* i915_debugfs_connector_add - add i915 specific connector debugfs files

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp