forked fromtorvalds/linux
- Notifications
You must be signed in to change notification settings - Fork1
Commite168159
ACPI / LPSS: Do not instiate platform_dev for devs without MMIO resources
acpi_lpss_create_device() skips handling LPSS devices which do not havea mmio resources in their resource list (typically these devices aredisabled by the firmware). But since the LPSS code does not bind to thedevice, acpi_bus_attach() ends up still creating a platform device forit and the regular platform_driver for the ACPI HID still tries to bindto it.This happens e.g. on some boards which do not use the pwm-controllerand have an empty or invalid resource-table for it. Currently this causesthese error messages to get logged:[ 3.281966] pwm-lpss 80862288:00: invalid resource[ 3.287098] pwm-lpss: probe of 80862288:00 failed with error -22This commit stops the undesirable creation of a platform_device fordisabled LPSS devices by setting pnp.type.platform_id to 0. Note thatacpi_scan_attach_handler() also sets pnp.type.platform_id to 0 when thereis a matching handler for the device and that handler has no attachcallback, so we simply behave as a handler without an attach functionin this case.Signed-off-by: Hans de Goede <hdegoede@redhat.com>Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>1 parente6ce0ce commite168159
1 file changed
+2
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
601 | 601 | | |
602 | 602 | | |
603 | 603 | | |
| 604 | + | |
| 605 | + | |
604 | 606 | | |
605 | 607 | | |
606 | 608 | | |
| |||
0 commit comments
Comments
(0)