Commit9605d1c

mwiniars

authored and

ickle

committed

drm/i915/guc: Default to non-verbose GuC logging

Now that we've decoupled logging from relay, GuC log level is onlycontrolling the GuC behavior - there shouldn't be any impact on i915behaviour. We're only going to see a single extra interrupt when logwill get half full.That, and the fact that we're seeing igt/gem_exec_nop/basic-seriesfailing with non-verbose logging being disabled.v2: Bring back the "auto" guc_log_level, now that we fixed the logSigned-off-by: Michał Winiarski <michal.winiarski@intel.com>Cc: Chris Wilson <chris@chris-wilson.co.uk>Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>Cc: Sagar Arun Kamble <sagar.a.kamble@intel.com>Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>Reviewed-by: Sagar Arun Kamble <sagar.a.kamble@intel.com>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>Link:https://patchwork.freedesktop.org/patch/msgid/20180319095348.9716-11-michal.winiarski@intel.com

1 parentcb5d64e commit9605d1cCopy full SHA for 9605d1c

File tree

2 files changed

-2

lines changed

drivers/gpu/drm/i915
- i915_params.h
- intel_uc.c

2 files changed

-2

lines changed

`‎drivers/gpu/drm/i915/i915_params.h‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ struct drm_printer;`
`48`	`48`	`param(int, enable_ips, 1) \`
`49`	`49`	`param(int, invert_brightness, 0) \`
`50`	`50`	`param(int, enable_guc, 0) \`
`51`		`-param(int, guc_log_level,0) \`
	`51`	`+param(int, guc_log_level,-1) \`
`52`	`52`	`param(char *, guc_firmware_path, NULL) \`
`53`	`53`	`param(char *, huc_firmware_path, NULL) \`
`54`	`54`	`param(int, mmio_debug, 0) \`

`‎drivers/gpu/drm/i915/intel_uc.c‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ static int __get_platform_enable_guc(struct drm_i915_private *dev_priv)`
`69`	`69`
`70`	`70`	`staticint__get_default_guc_log_level(structdrm_i915_private*dev_priv)`
`71`	`71`	`{`
`72`		`-intguc_log_level=0;/disabled /`
	`72`	`+intguc_log_level=1;/non-verbose /`
`73`	`73`
`74`	`74`	`/* Enable if we're running on platform with GuC and debug config */`
`75`	`75`	`if (HAS_GUC(dev_priv)&&intel_uc_is_using_guc()&&`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9605d1c

File tree

2 files changed

2 files changed

`‎drivers/gpu/drm/i915/i915_params.h‎`

`‎drivers/gpu/drm/i915/intel_uc.c‎`

0 commit comments