Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
forked fromtorvalds/linux

Commit5928c28

Browse files
jwrdegoederafaeljw
authored andcommitted
ACPI / video: Default lcd_only to true on Win8-ready and newer machines
We're seeing a lot of bogus backlight interfaces on newer machines withouta LCD such as desktops, servers and HDMI sticks. This causes userspace toshow a non-functional brightness slider in e.g. the GNOME3 system menu,which is undesirable. And, in general, we should simply just not registera non functional backlight interface.Checking the LCD flag causes the bogus acpi_video backlight interfaces togo away (on the machines this was tested on).This change sets the lcd_only option by default on any machines whichare Win8-ready, to fix this.This is not entirely without a risk of regressions, but video_detect.calready prefers native-backlight interfaces over the acpi_video oneon Win8-ready machines, calling acpi_video_unregister_backlight() as soonas a native interface shows up. This is done because the ACPI backlightinterface often is broken on Win8-ready machines, because win8 does notseem to actually use it.So in practice we already end up not registering the ACPI backlightinterface on (most) Win8-ready machines with a LCD panel, thus thischange does not change anything for (most) machines with a LCD paneland on machines without a LCD panel we actually don't want to registerany backlight interfaces.This has been tested on the following machines and fixes a bogus backlightinterface showing up there: - Desktop with an Asrock B150M Pro4S/D3 m.b. using i5-6500 builtin gfx - Intel Compute Stick STK1AW32SC - Meegopad T08 HDMI stickBogus backlight interfaces have also been reported on: - Desktop with Asus H87I-Plus m.b. - Desktop with ASRock B75M-ITX m.b. - Desktop with Gigabyte Z87-D3HP m.b. - Dell PowerEdge T20 desktopLink:https://bugzilla.redhat.com/show_bug.cgi?id=1097436Link:https://bugzilla.redhat.com/show_bug.cgi?id=1133327Link:https://bugzilla.redhat.com/show_bug.cgi?id=1133329Link:https://bugzilla.redhat.com/show_bug.cgi?id=1133646Signed-off-by: Hans de Goede <hdegoede@redhat.com>Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent464e1d5 commit5928c28

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

‎drivers/acpi/acpi_video.c‎

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@ MODULE_PARM_DESC(report_key_events,
8080
staticbooldevice_id_scheme= false;
8181
module_param(device_id_scheme,bool,0444);
8282

83-
staticboolonly_lcd=false;
84-
module_param(only_lcd,bool,0444);
83+
staticintonly_lcd=-1;
84+
module_param(only_lcd,int,0444);
8585

8686
staticintregister_count;
8787
staticDEFINE_MUTEX(register_count_mutex);
@@ -2136,6 +2136,16 @@ int acpi_video_register(void)
21362136
gotoleave;
21372137
}
21382138

2139+
/*
2140+
* We're seeing a lot of bogus backlight interfaces on newer machines
2141+
* without a LCD such as desktops, servers and HDMI sticks. Checking
2142+
* the lcd flag fixes this, so enable this on any machines which are
2143+
* win8 ready (where we also prefer the native backlight driver, so
2144+
* normally the acpi_video code should not register there anyways).
2145+
*/
2146+
if (only_lcd==-1)
2147+
only_lcd=acpi_osi_is_win8();
2148+
21392149
dmi_check_system(video_dmi_table);
21402150

21412151
ret=acpi_bus_register_driver(&acpi_video_bus);

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp