Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit16e61b5

Browse files
committed
Remove unused parts of ProcMeta
Also replace if-else if chain with switch and fix error strings.
1 parentf960ace commit16e61b5

File tree

1 file changed

+5
-52
lines changed

1 file changed

+5
-52
lines changed

‎internal/lvgen/generate.go‎

Lines changed: 5 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -170,34 +170,10 @@ type Proc struct {
170170
WriteStreamIdxint// The index of read stream in function argument list
171171
}
172172

173-
// ProcMetaGenerate is a type for flags from @generate annotation
174-
typeProcMetaGenerateint
175-
176-
// @generate annotation can be none, client, server or both
177-
const (
178-
ProcMetaGenerateNoneProcMetaGenerate=iota
179-
ProcMetaGenerateClient
180-
ProcMetaGenerateServer
181-
ProcMetaGenerateBoth
182-
)
183-
184-
// ProcMetaPriority is a type for values from @priority annotation
185-
typeProcMetaPriorityint
186-
187-
// @priority annotation can be low or high
188-
const (
189-
ProcMetaPriorityLowProcMetaPriority=iota
190-
ProcMetaPriorityHigh
191-
)
192-
193173
// ProcMeta holds information from annotations attached to a libvirt procedure
194174
typeProcMetastruct {
195-
GenerateProcMetaGenerate
196175
ReadStreamint
197176
WriteStreamint
198-
PriorityProcMetaPriority
199-
Acls []string
200-
Aclfilterstring
201177
}
202178

203179
typestructStack []*Structure
@@ -671,42 +647,19 @@ func parseMeta(meta string) (*ProcMeta, error) {
671647
returnnil,fmt.Errorf("invalid annotation: %s",meta)
672648
}
673649
spl[1]=strings.Trim(spl[1]," ")
674-
ifspl[0]=="generate" {
675-
ifspl[1]=="none" {
676-
res.Generate=ProcMetaGenerateNone
677-
}elseifspl[1]=="client" {
678-
res.Generate=ProcMetaGenerateClient
679-
}elseifspl[1]=="server" {
680-
res.Generate=ProcMetaGenerateServer
681-
}elseifspl[1]=="both" {
682-
res.Generate=ProcMetaGenerateBoth
683-
}else {
684-
returnnil,fmt.Errorf("invalid value for generate: %s",spl[1])
685-
}
686-
}elseifspl[0]=="readstream" {
650+
switchspl[0] {
651+
case"readstream":
687652
varerrerror
688653
res.ReadStream,err=strconv.Atoi(spl[1])
689654
iferr!=nil {
690-
returnnil,fmt.Errorf("invalid value forreadstread: %s",spl[1])
655+
returnnil,fmt.Errorf("invalid value forreadstream: %s",spl[1])
691656
}
692-
}elseifspl[0]=="writestream" {
657+
case"writestream":
693658
varerrerror
694659
res.WriteStream,err=strconv.Atoi(spl[1])
695660
iferr!=nil {
696-
returnnil,fmt.Errorf("invalid value for readstread: %s",spl[1])
697-
}
698-
}elseifspl[0]=="priority" {
699-
ifspl[1]=="low" {
700-
res.Priority=ProcMetaPriorityLow
701-
}elseifspl[1]=="high" {
702-
res.Priority=ProcMetaPriorityHigh
703-
}else {
704-
returnnil,fmt.Errorf("invalid value for priority: %s",spl[1])
661+
returnnil,fmt.Errorf("invalid value for writestream: %s",spl[1])
705662
}
706-
}elseifspl[0]=="acl" {
707-
res.Acls=append(res.Acls,spl[1])
708-
}elseifspl[0]=="aclfilter" {
709-
res.Aclfilter=spl[1]
710663
}
711664
}
712665
returnres,nil

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp