Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Functionality] Reduce Custom generator scope to a Single stage generator#227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
coder137 merged 19 commits intomainfromcustom_generator_improvements
Nov 24, 2022
Merged
Changes from1 commit
Commits
Show all changes
19 commits
Select commitHold shift + click to select a range
346925c
Added Comparator for custom_generator
coder137Nov 7, 2022
3b1d63e
Updated CreateTaskRunner and TaskRunner APIs
coder137Nov 7, 2022
2395186
Added GroupRunner
coder137Nov 10, 2022
83fab19
Removed dependency_cb
coder137Nov 19, 2022
da0ef69
Update gcovr.cmake
coder137Nov 19, 2022
9352f01
Update test_custom_generator.cpp
coder137Nov 19, 2022
33a1111
Removed groups from Custom Generator
coder137Nov 20, 2022
240881e
Removed ungrouped ids from custom generator
coder137Nov 21, 2022
19ce132
Updated comparator variable names
coder137Nov 21, 2022
950d840
Added IsChanged function to Comparator
coder137Nov 21, 2022
fa20529
Added a ConvertToInternal function for UserCustomGeneratorSchema
coder137Nov 21, 2022
6d03060
Removed groups from custom_generator_schema
coder137Nov 23, 2022
2bfff72
Shifted classes to seperate include files
coder137Nov 24, 2022
0156aec
Update custom_generator.cpp
coder137Nov 24, 2022
a0316aa
Pass blob_handler shared_ptr by ref
coder137Nov 24, 2022
fdc7849
Update custom_generator.h
coder137Nov 24, 2022
6a0e493
Update cppcheck.cmake
coder137Nov 24, 2022
a4a52b2
Updated tests for custom_generator
coder137Nov 24, 2022
03061bd
Updated custom_generator blob_handler implementation
coder137Nov 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
Updated comparator variable names
  • Loading branch information
@coder137
coder137 committedNov 21, 2022
commit19ce132f606ebb883b7c932f4c186b7eb7b5855a
32 changes: 16 additions & 16 deletionsbuildcc/lib/target/include/target/custom_generator.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -175,9 +175,9 @@ class CustomGenerator : public internal::BuilderInterface {

private:
struct Comparator {
Comparator(const internal::CustomGeneratorSchema &s,
Comparator(const internal::CustomGeneratorSchema &loaded,
const UserCustomGeneratorSchema &us)
:schema(s),user_schema(us) {}
:loaded_schema_(loaded),current_schema_(us) {}

enum class State {
kRemoved,
Expand All@@ -186,54 +186,54 @@ class CustomGenerator : public internal::BuilderInterface {
};

void AddAllIds() {
const auto &curr_ids =user_schema.ids;
const auto &curr_ids =current_schema_.ids;
for (const auto &[id, _] : curr_ids) {
id_state_info.at(State::kAdded).insert(id);
id_state_info_.at(State::kAdded).insert(id);
}
}

void CompareIds() {
const auto &prev_ids =schema.internal_ids;
const auto &curr_ids =user_schema.ids;
const auto &prev_ids =loaded_schema_.internal_ids;
const auto &curr_ids =current_schema_.ids;

for (const auto &[prev_id, _] : prev_ids) {
if (curr_ids.find(prev_id) == curr_ids.end()) {
// Id Removed condition, previous id is not present in the current run
id_state_info.at(State::kRemoved).insert(prev_id);
id_state_info_.at(State::kRemoved).insert(prev_id);
}
}

for (const auto &[curr_id, _] : curr_ids) {
if (prev_ids.find(curr_id) == prev_ids.end()) {
// Id Added condition
id_state_info.at(State::kAdded).insert(curr_id);
id_state_info_.at(State::kAdded).insert(curr_id);
} else {
// Id Check Later condition
id_state_info.at(State::kCheckLater).insert(curr_id);
id_state_info_.at(State::kCheckLater).insert(curr_id);
}
}
}

const std::unordered_set<std::string> &GetRemovedIds() const {
returnid_state_info.at(State::kRemoved);
returnid_state_info_.at(State::kRemoved);
}

const std::unordered_set<std::string> &GetAddedIds() const {
returnid_state_info.at(State::kAdded);
returnid_state_info_.at(State::kAdded);
}

const std::unordered_set<std::string> &GetCheckLaterIds() const {
returnid_state_info.at(State::kCheckLater);
returnid_state_info_.at(State::kCheckLater);
}

bool IsIdAdded(const std::string &id) const {
returnid_state_info.at(State::kAdded).count(id) == 1;
returnid_state_info_.at(State::kAdded).count(id) == 1;
}

private:
const internal::CustomGeneratorSchema &schema;
const UserCustomGeneratorSchema &user_schema;
std::unordered_map<State, std::unordered_set<std::string>>id_state_info{
const internal::CustomGeneratorSchema &loaded_schema_;
const UserCustomGeneratorSchema &current_schema_;
std::unordered_map<State, std::unordered_set<std::string>>id_state_info_{
{State::kRemoved, std::unordered_set<std::string>()},
{State::kAdded, std::unordered_set<std::string>()},
{State::kCheckLater, std::unordered_set<std::string>()},
Expand Down
[8]ページ先頭
©2009-2025 Movatter.jp