Commitfa61c00

committed

fix proxy missing property detection when render function does not usewith

1 parent1a7b910 commitfa61c00Copy full SHA for fa61c00

File tree

+38

-6

lines changed

+38

-6

lines changed

Lines changed: 17 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,15 @@ if (process.env.NODE_ENV !== 'production') {`
`12`	`12`	`'require'// for Webpack/Browserify`
`13`	`13`	`)`
`14`	`14`
	`15`	`+constwarnNonPresent=(target,key)=>{`
	`16`	`+warn(`
	`17`	+`Property or method "${key}" is not defined on the instance but `+
	`18`	+`referenced during render. Make sure to declare reactive data `+
	`19`	+`properties in the data option.`,
	`20`	`+target`
	`21`	`+)`
	`22`	`+}`
	`23`	`+`
`15`	`24`	`hasProxy=`
`16`	`25`	`typeofProxy!=='undefined'&&`
`17`	`26`	`Proxy.toString().match(/nativecode/)`
`@@ -21,14 +30,16 @@ if (process.env.NODE_ENV !== 'production') {`
`21`	`30`	`consthas=keyintarget`
`22`	`31`	`constisAllowed=allowedGlobals(key)\|\|key.charAt(0)==='_'`
`23`	`32`	`if(!has&&!isAllowed){`
`24`		`-warn(`
`25`		-`Property or method "${key}" is not defined on the instance but `+
`26`		-`referenced during render. Make sure to declare reactive data `+
`27`		-`properties in the data option.`,
`28`		`-target`
`29`		`-)`
	`33`	`+warnNonPresent(target,key)`
`30`	`34`	`}`
`31`	`35`	`returnhas\|\|!isAllowed`
	`36`	`+},`
	`37`	`+`
	`38`	`+get(target,key){`
	`39`	`+if(typeofkey==='string'&&!(keyintarget)){`
	`40`	`+warnNonPresent(target,key)`
	`41`	`+}`
	`42`	`+returntarget[key]`
`32`	`43`	`}`
`33`	`44`	`}`
`34`	`45`

Lines changed: 21 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,21 @@`
	`1`	`+importVuefrom'vue'`
	`2`	`+`
	`3`	`+if(typeofProxy!=='undefined'){`
	`4`	`+describe('render proxy',()=>{`
	`5`	+it('should warn missing property in render fns with `with`',()=>{
	`6`	`+newVue({`
	`7`	+template:`<div>{{ a }}</div>`
	`8`	`+}).$mount()`
	`9`	+expect(`Property or method "a" is not defined`).toHaveBeenWarned()
	`10`	`+})`
	`11`	`+`
	`12`	+it('should warn missing property in render fns without `with`',()=>{
	`13`	`+newVue({`
	`14`	`+render(h){`
	`15`	`+returnh('div',[this.a])`
	`16`	`+}`
	`17`	`+}).$mount()`
	`18`	+expect(`Property or method "a" is not defined`).toHaveBeenWarned()
	`19`	`+})`
	`20`	`+})`
	`21`	`+}`

Comments

(0)