Commitf2e00f7

committed

fix: special case for static muted attribute in firefox

1 parent350f578 commitf2e00f7Copy full SHA for f2e00f7

File tree

+25

-0

lines changed

+25

-0

lines changed

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -556,6 +556,13 @@ function processAttrs (el) {`
`556`	`556`	`}`
`557`	`557`	`}`
`558`	`558`	`addAttr(el,name,JSON.stringify(value))`
	`559`	`+// #6887 firefox doesn't update muted state if set via attribute`
	`560`	`+// even immediately after element creation`
	`561`	`+if(!el.component&&`
	`562`	`+platformMustUseProp(el.tag,el.attrsMap.type,name)&&`
	`563`	`+name==='muted'){`
	`564`	`+addProp(el,name,'true')`
	`565`	`+}`
`559`	`566`	`}`
`560`	`567`	`}`
`561`	`568`	`}`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1000,6 +1000,15 @@ describe('SSR: renderToString', () => {`
`1000`	`1000`	`done()`
`1001`	`1001`	`})`
`1002`	`1002`	`})`
	`1003`	`+`
	`1004`	`+it('render muted properly',done=>{`
	`1005`	`+renderVmWithOptions({`
	`1006`	`+template:'<video muted></video>'`
	`1007`	`+},result=>{`
	`1008`	`+expect(result).toContain('<video muted="muted" data-server-rendered="true"></video>')`
	`1009`	`+done()`
	`1010`	`+})`
	`1011`	`+})`
`1003`	`1012`	`})`
`1004`	`1013`
`1005`	`1014`	`functionrenderVmWithOptions(options,cb){`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -395,6 +395,15 @@ describe('parser', () => {`
`395`	`395`	`expect(ast.props[0].value).toBe('msg')`
`396`	`396`	`})`
`397`	`397`
	`398`	`+// #6887`
	`399`	`+it('special case static attribute that must be props',()=>{`
	`400`	`+constast=parse('<video muted></video>',baseOptions)`
	`401`	`+expect(ast.attrs[0].name).toBe('muted')`
	`402`	`+expect(ast.attrs[0].value).toBe('""')`
	`403`	`+expect(ast.props[0].name).toBe('muted')`
	`404`	`+expect(ast.props[0].value).toBe('true')`
	`405`	`+})`
	`406`	`+`
`398`	`407`	`it('attribute with v-on',()=>{`
`399`	`408`	`constast=parse('<input type="text" name="field1" :value="msg" @input="onInput">',baseOptions)`
`400`	`409`	`expect(ast.events.input.value).toBe('onInput')`

Comments

(0)