Commite9670d5

committed

fix watcher accidentally clearing watcherList on teardown (fixvuejs#806)

1 parent7822d71 commite9670d5Copy full SHA for e9670d5

File tree

-2

lines changed

-2

lines changed

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -222,7 +222,10 @@ p.teardown = function () {`
`222`	`222`	`// which can improve teardown performance.`
`223`	`223`	`if(!this.vm._isBeingDestroyed){`
`224`	`224`	`varlist=this.vm._watcherList`
`225`		`-list.splice(list.indexOf(this))`
	`225`	`+vari=list.indexOf(this)`
	`226`	`+if(i>-1){`
	`227`	`+list.splice(i,1)`
	`228`	`+}`
`226`	`229`	`}`
`227`	`230`	`for(varidinthis.deps){`
`228`	`231`	`this.deps[id].removeSub(this)`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -233,7 +233,7 @@ if (_.inBrowser) {`
`233`	`233`	`expect(opts[1].selected).toBe(false)`
`234`	`234`	`// should teardown option watcher when unbind`
`235`	`235`	`expect(vm._watcherList.length).toBe(2)`
`236`		`-vm._directives[0].unbind()`
	`236`	`+vm._directives[0]._teardown()`
`237`	`237`	`expect(vm._watcherList.length).toBe(0)`
`238`	`238`	`done()`
`239`	`239`	`})`

Comments

(0)