Commite3d7a03

committed

fix special static attrs as dom prop

1 parentc9fa2e6 commite3d7a03Copy full SHA for e3d7a03

File tree

+14

-2

lines changed

+14

-2

lines changed

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -75,6 +75,7 @@ declare type ASTElement = {`
`75`	`75`	`staticInFor?:boolean;`
`76`	`76`	`staticProcessed?:boolean;`
`77`	`77`	`hasBindings?:boolean;`
	`78`	`+hasNormalProp?:true;`
`78`	`79`
`79`	`80`	`text?:string;`
`80`	`81`	`attrs?:Array<{name:string;value:string}>;`

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`/@flow /`
`2`	`2`
`3`		`-import{makeMap,isBuiltInTag,cached,no}from'shared/util'`
	`3`	`+import{makeMap,isBuiltInTag,cached,no,remove}from'shared/util'`
`4`	`4`
`5`	`5`	`letisStaticKey`
`6`	`6`	`letisPlatformReservedTag`
`@@ -99,13 +99,17 @@ function isStatic (node: ASTNode): boolean {`
`99`	`99`	`if(node.type===3){// text`
`100`	`100`	`returntrue`
`101`	`101`	`}`
	`102`	`+constnodeAttrs=Object.keys(node)`
	`103`	`+if(!node.hasNormalProp&&node.props&&node.props.length){`
	`104`	`+remove(nodeAttrs,'props')`
	`105`	`+}`
`102`	`106`	`return!!(node.pre\|\|(`
`103`	`107`	`!node.hasBindings&&// no dynamic bindings`
`104`	`108`	`!node.if&&!node.for&&// not v-if or v-for or v-else`
`105`	`109`	`!isBuiltInTag(node.tag)&&// not a built-in`
`106`	`110`	`isPlatformReservedTag(node.tag)&&// not a component`
`107`	`111`	`!isDirectChildOfTemplateFor(node)&&`
`108`		`-Object.keys(node).every(isStaticKey)`
	`112`	`+nodeAttrs.every(isStaticKey)`
`109`	`113`	`))`
`110`	`114`	`}`
`111`	`115`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -444,6 +444,7 @@ function processAttrs (el) {`
`444`	`444`	`}`
`445`	`445`	`}`
`446`	`446`	`if(isProp\|\|platformMustUseProp(el.tag,name)){`
	`447`	`+el.hasNormalProp=true`
`447`	`448`	`addProp(el,name,value)`
`448`	`449`	`}else{`
`449`	`450`	`addAttr(el,name,value)`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -191,6 +191,12 @@ describe('optimizer', () => {`
`191`	`191`	`expect(ast.children[0].static).toBe(false)`
`192`	`192`	`})`
`193`	`193`
	`194`	`+it('mark static with static dom property',()=>{`
	`195`	`+constast=parse('<input type="text" value="1">',baseOptions)`
	`196`	`+optimize(ast,baseOptions)`
	`197`	`+expect(ast.static).toBe(true)`
	`198`	`+})`
	`199`	`+`
`194`	`200`	`it('not root ast',()=>{`
`195`	`201`	`constast=null`
`196`	`202`	`optimize(ast,baseOptions)`

Comments

(0)