Commitc24f3e4

authored and

committed

fix(events): properly $off array of events (vuejs#6949)

1 parentf2e00f7 commitc24f3e4Copy full SHA for c24f3e4

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ export function eventsMixin (Vue: Class<Component>) {`
`92`	`92`	`if(!cbs){`
`93`	`93`	`returnvm`
`94`	`94`	`}`
`95`		`-if(arguments.length===1){`
	`95`	`+if(!fn){`
`96`	`96`	`vm._events[event]=null`
`97`	`97`	`returnvm`
`98`	`98`	`}`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,13 @@ describe('Instance methods events', () => {`
`41`	`41`	`expect(spy.calls.count()).toBe(1)`
`42`	`42`	`})`
`43`	`43`
	`44`	`+it('$off multi event without callback',()=>{`
	`45`	`+vm.$on(['test1','test2'],spy)`
	`46`	`+vm.$off(['test1','test2'])`
	`47`	`+vm.$emit('test1')`
	`48`	`+expect(spy).not.toHaveBeenCalled()`
	`49`	`+})`
	`50`	`+`
`44`	`51`	`it('$once',()=>{`
`45`	`52`	`vm.$once('test',spy)`
`46`	`53`	`vm.$emit('test',1,2,3)`

Comments

(0)