Commitbacb911

authored and

committed

fix(warning): allow symbol as vdom key (vuejs#7271)

1 parentc0d516c commitbacb911Copy full SHA for bacb911

File tree

+12

-1

lines changed

+12

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -270,7 +270,7 @@ export function createPatchFunction (backend) {`
`270`	`270`	`createElm(children[i],insertedVnodeQueue,vnode.elm,null,true)`
`271`	`271`	`}`
`272`	`272`	`}elseif(isPrimitive(vnode.text)){`
`273`		`-nodeOps.appendChild(vnode.elm,nodeOps.createTextNode(vnode.text))`
	`273`	`+nodeOps.appendChild(vnode.elm,nodeOps.createTextNode(String(vnode.text)))`
`274`	`274`	`}`
`275`	`275`	`}`
`276`	`276`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,8 @@ export function isPrimitive (value: any): boolean %checks {`
`27`	`27`	`return(`
`28`	`28`	`typeofvalue==='string'\|\|`
`29`	`29`	`typeofvalue==='number'\|\|`
	`30`	`+// $flow-disable-line`
	`31`	`+typeofvalue==='symbol'\|\|`
`30`	`32`	`typeofvalue==='boolean'`
`31`	`33`	`)`
`32`	`34`	`}`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -215,6 +215,15 @@ describe('create-element', () => {`
`215`	`215`	`expect('Avoid using non-primitive value as key').not.toHaveBeenWarned()`
`216`	`216`	`})`
`217`	`217`
	`218`	`+it('doesn\'t warn symbol key',()=>{`
	`219`	`+newVue({`
	`220`	`+render(h){`
	`221`	`+returnh('div',{key:Symbol('symbol')})`
	`222`	`+}`
	`223`	`+}).$mount()`
	`224`	`+expect('Avoid using non-primitive value as key').not.toHaveBeenWarned()`
	`225`	`+})`
	`226`	`+`
`218`	`227`	`it('nested child elements should be updated correctly',done=>{`
`219`	`228`	`constvm=newVue({`
`220`	`229`	`data:{n:1},`

Comments

(0)