forked fromvuejs/vue

NotificationsYou must be signed in to change notification settings
Fork0
Star0

Commitae4db82

committed

fix unexpected warnings in tests

1 parent7b389bc commitae4db82Copy full SHA for ae4db82

File tree

7 files changed

+14

-7

lines changed

test/unit
- features
  - component
    - component-keep-alive.spec.js
    - component.spec.js
  - options
- modules/vdom
  - create-component.spec.js

7 files changed

+14

-7

lines changed

`‎test/unit/features/component/component-keep-alive.spec.js`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -265,7 +265,7 @@ describe('Component keep-alive', () => {`
`265`	`265`	`<keep-alive>`
`266`	`266`	`<component :is="view" class="test"></component>`
`267`	`267`	`</keep-alive>`
`268`		`- <transition>`
	`268`	`+ </transition>`
`269`	`269`	</div>`,
`270`	`270`	`data:{`
`271`	`271`	`view:'one'`

`‎test/unit/features/component/component.spec.js`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -294,7 +294,6 @@ describe('Component', () => {`
`294`	`294`	`expect(spy).not.toHaveBeenCalled()`
`295`	`295`	`vm.a=null`
`296`	`296`	`waitForUpdate(()=>{`
`297`		`-expect('Error when rendering root instance').toHaveBeenWarned()`
`298`	`297`	`expect(spy).toHaveBeenCalled()`
`299`	`298`	`expect(vm.$el.textContent).toBe('123')// should preserve rendered DOM`
`300`	`299`	`vm.a={b:234}`

`‎test/unit/features/options/data.spec.js`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -79,6 +79,7 @@ describe('Options data', () => {`
`79`	`79`	`it('should have access to props',()=>{`
`80`	`80`	`constTest={`
`81`	`81`	`props:['a'],`
	`82`	`+render(){},`
`82`	`83`	`data(){`
`83`	`84`	`return{`
`84`	`85`	`b:this.a`

`‎test/unit/features/options/lifecycle.spec.js`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,7 @@ describe('Options lifecyce hooks', () => {`
`45`	`45`	`describe('beforeMount',()=>{`
`46`	`46`	`it('should not have mounted',()=>{`
`47`	`47`	`constvm=newVue({`
	`48`	`+render(){},`
`48`	`49`	`beforeMount(){`
`49`	`50`	`spy()`
`50`	`51`	`expect(this._isMounted).toBe(false)`
`@@ -160,6 +161,7 @@ describe('Options lifecyce hooks', () => {`
`160`	`161`	`describe('beforeDestroy',()=>{`
`161`	`162`	`it('should be called before destroy',()=>{`
`162`	`163`	`constvm=newVue({`
	`164`	`+render(){},`
`163`	`165`	`beforeDestroy(){`
`164`	`166`	`spy()`
`165`	`167`	`expect(this._isBeingDestroyed).toBe(false)`
`@@ -177,6 +179,7 @@ describe('Options lifecyce hooks', () => {`
`177`	`179`	`describe('destroyed',()=>{`
`178`	`180`	`it('should be called after destroy',()=>{`
`179`	`181`	`constvm=newVue({`
	`182`	`+render(){},`
`180`	`183`	`destroyed(){`
`181`	`184`	`spy()`
`182`	`185`	`expect(this._isBeingDestroyed).toBe(true)`

`‎test/unit/features/options/mixins.spec.js`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ describe('Options mixins', () => {`
`17`	`17`	`methods:{`
`18`	`18`	`b:function(){}`
`19`	`19`	`}`
`20`		`-}).$mount()`
	`20`	`+})`
`21`	`21`
`22`	`22`	`expect(vm.a).toBeDefined()`
`23`	`23`	`expect(vm.b).toBeDefined()`
`@@ -103,7 +103,7 @@ describe('Options mixins', () => {`
`103`	`103`	`methods:{`
`104`	`104`	`b:function(){}`
`105`	`105`	`}`
`106`		`-}).$mount()`
	`106`	`+})`
`107`	`107`
`108`	`108`	`expect(vm.a).toBeDefined()`
`109`	`109`	`expect(vm.b).toBeDefined()`

`‎test/unit/features/options/parent.spec.js`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -2,10 +2,13 @@ import Vue from 'vue'`
`2`	`2`
`3`	`3`	`describe('Options parent',()=>{`
`4`	`4`	`it('should work',()=>{`
`5`		`-constparent=newVue({}).$mount()`
	`5`	`+constparent=newVue({`
	`6`	`+render(){}`
	`7`	`+}).$mount()`
`6`	`8`
`7`	`9`	`constchild=newVue({`
`8`		`-parent:parent`
	`10`	`+parent:parent,`
	`11`	`+render(){}`
`9`	`12`	`}).$mount()`
`10`	`13`
`11`	`14`	`// this option is straight-forward`

`‎test/unit/modules/vdom/create-component.spec.js`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,8 @@ describe('create-component', () => {`
`16`	`16`	`it('create a component basically',()=>{`
`17`	`17`	`constchild={`
`18`	`18`	`name:'child',`
`19`		`-props:['msg']`
	`19`	`+props:['msg'],`
	`20`	`+render(){}`
`20`	`21`	`}`
`21`	`22`	`constinit=jasmine.createSpy()`
`22`	`23`	`constdata={`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitae4db82

File tree

7 files changed

7 files changed

`‎test/unit/features/component/component-keep-alive.spec.js`

`‎test/unit/features/component/component.spec.js`

`‎test/unit/features/options/data.spec.js`

`‎test/unit/features/options/lifecycle.spec.js`

`‎test/unit/features/options/mixins.spec.js`

`‎test/unit/features/options/parent.spec.js`

`‎test/unit/modules/vdom/create-component.spec.js`

0 commit comments