Commitacdc3c4

authored and

committed

feat($event): support binding parameters on event handler within weex recycle-list

1 parent2a1ce0d commitacdc3c4Copy full SHA for acdc3c4

File tree

+17

-9

lines changed

+17

-9

lines changed

Lines changed: 11 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,13 +1,15 @@`
`1`	`1`	`/@flow /`
`2`	`2`
`3`	`3`	`import{warn}from'core/util/index'`
`4`		`-import{cached,isUndef}from'shared/util'`
	`4`	`+import{cached,isUndef,isPlainObject}from'shared/util'`
`5`	`5`
`6`	`6`	`constnormalizeEvent=cached((name:string):{`
`7`	`7`	`name:string,`
`8`	`8`	`once:boolean,`
`9`	`9`	`capture:boolean,`
`10`		`-passive:boolean`
	`10`	`+passive:boolean,`
	`11`	`+handler?:Function,`
	`12`	`+params?:Array<any>`
`11`	`13`	`}=>{`
`12`	`14`	`const passive=name.charAt(0)==='&'`
`13`	`15`	`name=passive ?name.slice(1) :name`
`@@ -47,11 +49,15 @@ export function updateListeners (`
`47`	`49`	`remove:Function,`
`48`	`50`	`vm:Component`
`49`	`51`	`){`
`50`		`-letname,cur,old,event`
	`52`	`+letname,def,cur,old,event`
`51`	`53`	`for(nameinon){`
`52`		`-cur=on[name]`
	`54`	`+def=cur=on[name]`
`53`	`55`	`old=oldOn[name]`
`54`	`56`	`event=normalizeEvent(name)`
	`57`	`+if(isPlainObject(def)){`
	`58`	`+ cur=def.handler`
	`59`	`+event.params=def.params`
	`60`	`+}`
`55`	`61`	`if(isUndef(cur)){`
`56`	`62`	`process.env.NODE_ENV!=='production'&&warn(`
`57`	`63`	`Invalid handler for event "${event.name}": got `+String(cur),
`@@ -61,7 +67,7 @@ export function updateListeners (`
`61`	`67`	`if(isUndef(cur.fns)){`
`62`	`68`	`cur=on[name]=createFnInvoker(cur)`
`63`	`69`	`}`
`64`		`-add(event.name,cur,event.once,event.capture,event.passive)`
	`70`	`+add(event.name,cur,event.once,event.capture,event.passive,event.params)`
`65`	`71`	`}elseif(cur!==old){`
`66`	`72`	`old.fns=cur`
`67`	`73`	`on[name]=old`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -122,10 +122,10 @@ const jsHandlers = {`
`122`	`122`	`}`
`123`	`123`	`}`
`124`	`124`
`125`		`-functionfireEvent(instance,nodeId,type,e,domChanges){`
	`125`	`+functionfireEvent(instance,nodeId,type,e,domChanges,params){`
`126`	`126`	`constel=instance.document.getRef(nodeId)`
`127`	`127`	`if(el){`
`128`		`-returninstance.document.fireEvent(el,type,e,domChanges)`
	`128`	`+returninstance.document.fireEvent(el,type,e,domChanges,params)`
`129`	`129`	`}`
`130`	`130`	returnnewError(`invalid element reference "${nodeId}"`)
`131`	`131`	`}`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,9 @@ function add (`
`8`	`8`	`event:string,`
`9`	`9`	`handler:Function,`
`10`	`10`	`once:boolean,`
`11`		`-capture:boolean`
	`11`	`+capture:boolean,`
	`12`	`+passive?:boolean,`
	`13`	`+params?:Array<any>`
`12`	`14`	`){`
`13`	`15`	`if(capture){`
`14`	`16`	`console.log('Weex do not support event in bubble phase.')`
`@@ -26,7 +28,7 @@ function add (`
`26`	`28`	`}`
`27`	`29`	`}`
`28`	`30`	`}`
`29`		`-target.addEvent(event,handler)`
	`31`	`+target.addEvent(event,handler,params)`
`30`	`32`	`}`
`31`	`33`
`32`	`34`	`functionremove(`

Comments

(0)