Commita64ff19

authored and

committed

fix(lifecycle): updated should not be called after component being destroyed (vuejs#8381)

1 parenta71853b commita64ff19Copy full SHA for a64ff19

File tree

+38

-1

lines changed

+38

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ function callUpdatedHooks (queue) {`
`98`	`98`	`while(i--){`
`99`	`99`	`constwatcher=queue[i]`
`100`	`100`	`constvm=watcher.vm`
`101`		`-if(vm._watcher===watcher&&vm._isMounted){`
	`101`	`+if(vm._watcher===watcher&&vm._isMounted&&!vm._isDestroyed){`
`102`	`102`	`callHook(vm,'updated')`
`103`	`103`	`}`
`104`	`104`	`}`

Lines changed: 37 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -199,6 +199,43 @@ describe('Options lifecycle hooks', () => {`
`199`	`199`	`expect(calls).toEqual(['child','parent'])`
`200`	`200`	`}).then(done)`
`201`	`201`	`})`
	`202`	`+`
	`203`	`+// #8076`
	`204`	`+it('should not be called after destroy',done=>{`
	`205`	`+constupdated=jasmine.createSpy('updated')`
	`206`	`+constdestroyed=jasmine.createSpy('destroyed')`
	`207`	`+`
	`208`	`+Vue.component('todo',{`
	`209`	`+template:'<div>{{todo.done}}</div>',`
	`210`	`+props:['todo'],`
	`211`	`+ destroyed,`
	`212`	`+ updated`
	`213`	`+})`
	`214`	`+`
	`215`	`+constvm=newVue({`
	`216`	+template:`
	`217`	`+ <div>`
	`218`	`+ <todo v-for="t in pendingTodos" :todo="t" :key="t.id"></todo>`
	`219`	`+ </div>`
	`220`	+ `,
	`221`	`+data(){`
	`222`	`+return{`
	`223`	`+todos:[{id:1,done:false}]`
	`224`	`+}`
	`225`	`+},`
	`226`	`+computed:{`
	`227`	`+pendingTodos(){`
	`228`	`+returnthis.todos.filter(t=>!t.done)`
	`229`	`+}`
	`230`	`+}`
	`231`	`+}).$mount()`
	`232`	`+`
	`233`	`+vm.todos[0].done=true`
	`234`	`+waitForUpdate(()=>{`
	`235`	`+expect(destroyed).toHaveBeenCalled()`
	`236`	`+expect(updated).not.toHaveBeenCalled()`
	`237`	`+}).then(done)`
	`238`	`+})`
`202`	`239`	`})`
`203`	`240`
`204`	`241`	`describe('beforeDestroy',()=>{`

Comments

(0)