Commit83ed926

committed

fix: $set should respect properties on prototype chain

1 parentee0e8b5 commit83ed926Copy full SHA for 83ed926

File tree

+27

-1

lines changed

+27

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -196,7 +196,7 @@ export function set (target: Array<any> \| Object, key: any, val: any): any {`
`196`	`196`	`target.splice(key,1,val)`
`197`	`197`	`returnval`
`198`	`198`	`}`
`199`		`-if(hasOwn(target,key)){`
	`199`	`+if(keyintarget&&!(keyinObject.prototype)){`
`200`	`200`	`target[key]=val`
`201`	`201`	`returnval`
`202`	`202`	`}`

Lines changed: 26 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -80,6 +80,32 @@ describe('Global API: set/delete', () => {`
`80`	`80`	`expect(vm.$el.innerHTML).toBe('<p>D</p><p>B</p><p>C</p>')`
`81`	`81`	`}).then(done)`
`82`	`82`	`})`
	`83`	`+`
	`84`	`+// #6845`
	`85`	`+it('should not overwrite properties on prototype chain',()=>{`
	`86`	`+classModel{`
	`87`	`+constructor(){`
	`88`	`+this._bar=null`
	`89`	`+}`
	`90`	`+getbar(){`
	`91`	`+returnthis._bar`
	`92`	`+}`
	`93`	`+setbar(newvalue){`
	`94`	`+this._bar=newvalue`
	`95`	`+}`
	`96`	`+}`
	`97`	`+`
	`98`	`+constvm=newVue({`
	`99`	`+data:{`
	`100`	`+data:newModel()`
	`101`	`+}`
	`102`	`+})`
	`103`	`+`
	`104`	`+Vue.set(vm.data,'bar',123)`
	`105`	`+expect(vm.data.bar).toBe(123)`
	`106`	`+expect(vm.data.hasOwnProperty('bar')).toBe(false)`
	`107`	`+expect(vm.data._bar).toBe(123)`
	`108`	`+})`
`83`	`109`	`})`
`84`	`110`
`85`	`111`	`describe('Vue.delete',()=>{`

Comments

(0)