Commit7644380

thenickname

authored and

yyx990803

committed

Typings: Improve $slots and $scopedSlots type to prevent unchecked access to undefined (vuejs#8946)

* fix(types): Declare $scopedSlots as potentially undefined to enable stricter TS checks* fix(types): Fix tests* fix(types): declare $slots option as potentially undefineddeclare $slots option as potentially undefined to enable stricter TS checks

1 parent3cd4af4 commit7644380Copy full SHA for 7644380

File tree

2 files changed

-5

lines changed

types
- test
  - options-test.ts
- vue.d.ts

2 files changed

-5

lines changed

`‎types/test/options-test.ts‎`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -304,8 +304,8 @@ Vue.component('component-with-scoped-slot', {`
`304`	`304`	`child:{`
`305`	`305`	`render(this:Vue,h:CreateElement){`
`306`	`306`	`returnh('div',[`
`307`		`-this.$scopedSlots['default']({msg:'hi'}),`
`308`		`-this.$scopedSlots['item']({msg:'hello'})`
	`307`	`+this.$scopedSlots['default']!({msg:'hi'}),`
	`308`	`+this.$scopedSlots['item']!({msg:'hello'})`
`309`	`309`	`])`
`310`	`310`	`}`
`311`	`311`	`}`
`@@ -314,7 +314,7 @@ Vue.component('component-with-scoped-slot', {`
`314`	`314`
`315`	`315`	`Vue.component('narrow-array-of-vnode-type',{`
`316`	`316`	`render(h):VNode{`
`317`		`-constslot=this.$scopedSlots.default({})`
	`317`	`+constslot=this.$scopedSlots.default!({})`
`318`	`318`	`if(typeofslot!=='string'){`
`319`	`319`	`constfirst=slot[0]`
`320`	`320`	`if(!Array.isArray(first)&&typeoffirst!=='string'){`

`‎types/vue.d.ts‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -27,8 +27,8 @@ export interface Vue {`
`27`	`27`	`readonly$root:Vue;`
`28`	`28`	`readonly$children:Vue[];`
`29`	`29`	`readonly$refs:{[key:string]:Vue\|Element\|Vue[]\|Element[]};`
`30`		`-readonly$slots:{[key:string]:VNode[]};`
`31`		`-readonly$scopedSlots:{[key:string]:ScopedSlot};`
	`30`	`+readonly$slots:{[key:string]:VNode[]\|undefined};`
	`31`	`+readonly$scopedSlots:{[key:string]:ScopedSlot\|undefined};`
`32`	`32`	`readonly$isServer:boolean;`
`33`	`33`	`readonly$data:Record<string,any>;`
`34`	`34`	`readonly$props:Record<string,any>;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7644380

File tree

2 files changed

2 files changed

`‎types/test/options-test.ts‎`

`‎types/vue.d.ts‎`

0 commit comments