Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Usecontext.AfterFunc() instead of a goroutine to track timeouts#532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mafredri merged 1 commit intocoder:masterfromash2k:no-timeout-goroutine
Sep 4, 2025

Conversation

ash2k
Copy link
Contributor

@ash2kash2k commentedAug 1, 2025•
edited
Loading

This is a reworked version of#501 with some minor improvements.

Closes#411

Closes#501

@ash2k
Copy link
ContributorAuthor

PTAL@mafredri@Jacalz

Copy link
Contributor

@JacalzJacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code looks good and the changes work well in my testing. Thanks 👍

@mafredrimafredri self-requested a reviewSeptember 1, 2025 12:06
@mafredrimafredri self-assigned thisSep 1, 2025
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the PR! This is a solid improvement, but I noticed a gotcha that needs to be addressed.

Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, thanks again!

@mafredrimafredri merged commitc7846ea intocoder:masterSep 4, 2025
4 checks passed
@mafredrimafredri mentioned this pull requestSep 4, 2025
@ash2k
Copy link
ContributorAuthor

Thanks for merging! If you could tag a release, I'd deploy to prod and see what happens 🤞

Jacalz reacted with rocket emoji

@mafredri
Copy link
Member

@ash2k Released asv1.8.14!

ash2k and Jacalz reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@mafredrimafredrimafredri approved these changes

+1 more reviewer

@JacalzJacalzJacalz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@mafredrimafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use context.AfterFunc to remove extra goroutine per connection used for context cancellation
3 participants
@ash2k@mafredri@Jacalz
[8]ページ先頭
©2009-2025 Movatter.jp