Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Disable AppArmor in CI to allow chrome sandbox#511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mafredri merged 1 commit intocoder:masterfromigolaizola:disable-app-armor
Jan 29, 2025

Conversation

igolaizola
Copy link
Contributor

@igolaizolaigolaizola commentedJan 29, 2025
edited by mafredri
Loading

The CI is currently failing with this error when trying to launchTestWasm with wasmbrowsertest:

No usable sandbox! If you are running on Ubuntu 23.10+ or another Linux distro that has disabled unprivileged user namespaces with AppArmor, seehttps://chromium.googlesource.com/chromium/src/+/main/docs/security/apparmor-userns-restrictions.md. Otherwise seehttps://chromium.googlesource.com/chromium/src/+/main/docs/linux/suid_sandbox_development.md for more information on developing with the (older) SUID sandbox. If you want to live dangerously and need an immediate workaround, you can try using --no-sandbox.

This change disables AppArmor in the CI to allow the sandbox to work.

Fixes#512
Closes#510

The CI is currently failing with this error when trying to launch`TestWasm` with wasmbrowsertest:No usable sandbox! If you are running on Ubuntu 23.10+ or another Linuxdistro that has disabled unprivileged user namespaces with AppArmor, seehttps://chromium.googlesource.com/chromium/src/+/main/docs/security/apparmor-userns-restrictions.md.Otherwise seehttps://chromium.googlesource.com/chromium/src/+/main/docs/linux/suid_sandbox_development.mdfor more information on developing with the (older) SUID sandbox. If youwant to live dangerously and need an immediate workaround, you can tryusing --no-sandbox.This change disables AppArmor in the CI to allow the sandbox to work.
@igolaizola
Copy link
ContributorAuthor

I got the idea to disable AppArmor from the following pull request in the wasmbrowsertest project:agnivade/wasmbrowsertest#72.

Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for investigating, nice solution!

@mafredri
Copy link
Member

@igolaizola I think this approach is fine, can we close#512 and#510 or would you like for them to remain open?

@igolaizola
Copy link
ContributorAuthor

igolaizola commentedJan 29, 2025
edited
Loading

@igolaizola I think this approach is fine, can we close#512 and#510 or would you like for them to remain open?

I agree. Feel free to merge this solution to fix the issue#512. Then we can also close#510.

@mafredrimafredri merged commit3e183a9 intocoder:masterJan 29, 2025
4 checks passed
@igolaizolaigolaizola deleted the disable-app-armor branchJanuary 29, 2025 15:24
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@mafredrimafredrimafredri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI failing when launching TestWasm with wasmbrowsertest
2 participants
@igolaizola@mafredri

[8]ページ先頭

©2009-2025 Movatter.jp