Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Avoid handling ping after close frame has been sent#394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
bhallionOhbibi wants to merge2 commits intocoder:devfrombhallionOhbibi:master

Conversation

bhallionOhbibi
Copy link

Fixes#298

Guidurand reacted with thumbs up emoji
@bhallionOhbibi
Copy link
Author

Any chance you have time to take a quick look at this ?
This fix is quite simple :D

marco-rozz reacted with thumbs up emoji

@nhooyr
Copy link
Contributor

Will do soon#402

Need to get#256 done first.

@nhooyrnhooyr changed the base branch frommaster todevOctober 13, 2023 07:29
@nhooyrnhooyrforce-pushed thedev branch 2 times, most recently from825873c to9b5a15bCompareOctober 13, 2023 07:33
@nhooyrnhooyr added this to thev1.8.8 milestoneOct 13, 2023
@nhooyrnhooyrforce-pushed thedev branch 5 times, most recently from3500fce toa94999fCompareOctober 14, 2023 13:10
@nhooyr
Copy link
Contributor

Unfortunately this doesn't work. writeFrame already has a check like this built in so it makes sense it doesn't work. There is definitely a bug in#298, but need to dig deeper to figure out what.

See the test I added to your commit, it still fails.

@nhooyr
Copy link
Contributor

Seee4879ab for the test

nhooyr added a commit that referenced this pull requestOct 19, 2023
Closes#298Closes#394The close frame was being received from the peer before we were able to reset ourwrite timeout and so we thought the write kept failing but it never was...Thanks@univerio and@bhallionOhbibi
@nhooyr
Copy link
Contributor

Fixed in dev, see28c6709

@nhooyrnhooyr closed thisOct 19, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nhooyrnhooyrAwaiting requested review from nhooyr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.8.8
Development

Successfully merging this pull request may close these issues.

Ping sometimes causes Close to time out
2 participants
@bhallionOhbibi@nhooyr
[8]ページ先頭
©2009-2025 Movatter.jp