Extend DialOptions to allow Host header override#336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nhooyr merged 1 commit intocoder:devfrombendiscz:client-host-override

Oct 13, 2023

Merged

Extend DialOptions to allow Host header override#336

nhooyr merged 1 commit intocoder:devfrombendiscz:client-host-override

Oct 13, 2023

+67 −0

Conversation

Copy link

Contributor

bendiscz commentedApr 28, 2022

The standardhttp.Request.Host field allows to override theHost header that is sent with the HTTP request (URL.Host is used by default). Such option can be useful in various scenarios, for example when running behind some proxy server.

This patch extends theDialOptions struct withHost field that basically does the same.

bendiscz requested a review fromnhooyr as acode owner

April 28, 2022 14:11

nhooyr reviewed

Mar 6, 2023

View reviewed changes

Copy link

Contributor

nhooyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Couldn't you useHost inHTTPHeader?

Copy link

ContributorAuthor

bendiscz commentedMar 6, 2023•
edited
Loading

Couldn't you useHost inHTTPHeader?

That does not work unfortunately.http.Client.Do ignoresHost inHTTPHeader, you need to set thehttp.Request.Host field if you want to override host fromhttp.Request.URL.

Copy link

Contributor

nhooyr commentedMar 6, 2023

Sounds good will get this in then after#256

Copy link

Contributor

nhooyr commentedMar 6, 2023

Or you know what we could actually check forHost inHTTPHeader and special case it to apply tohttp.Request.Host. The API innet/http isn't something we should follow to the tee anyway as it's hodgepodge.