coder/websocketPublic

NotificationsYou must be signed in to change notification settings
Fork329
Star4.7k

Fix DOS attack from malicious pongs#291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nhooyr merged 2 commits intomasterfromdos-56b8

Apr 7, 2021

Merged

Fix DOS attack from malicious pongs#291

nhooyr merged 2 commits intomasterfromdos-56b8

Apr 7, 2021

+7 −4

Conversation

Copy link

Contributor

nhooyr commentedApr 7, 2021•
edited
Loading

A double channel close panic was possible if a peer sent back multiple
pongs for every ping.

If the second pong arrived before the ping goroutine deleted its channel
from the map, the channel would be closed twice and so a panic would
ensue.

This fixes that by having the read goroutine send on the ping
goroutine's channel rather than closing it.

Reported via email by Tibor Kálmán@kalmant

Please update to the new release ASAP!

cc@noramehesz

nhooyr force-pushed themaster branch fromde018ed toe4c3b0fCompare

April 7, 2021 15:44

Fix DOS attack from malicious pongs

129d303

A double channel close panic was possible if a peer sent back multiplepongs for every ping.If the second pong arrived before the ping goroutine deleted its channelfrom the map, the channel would be closed twice and so a panic wouldensue.This fixes that by having the read goroutine send on the pinggoroutine's channel rather than closing it.Reported via email by Tibor Kálmán@kalmantPlease update to the new release ASAP!

nhooyr force-pushed thedos-56b8 branch fromaae5879 to129d303Compare

April 7, 2021 15:54

Fix CI

b0d7a27

nhooyr merged commit3604edc intomaster

Apr 7, 2021

nhooyr deleted the dos-56b8 branch

April 7, 2021 16:02

a-krause mentioned this pull request

Nov 23, 2021

Bump nhooyr.io/websocket from v1.8.6 to v1.8.7improbable-eng/grpc-web#1063

Merged

jmeridth added a commit to jmeridth/argo-cd that referenced this pull request

Aug 10, 2023

fix: upgrade nhooyr.io/websocket dependency

6d4d5ac

Upgrade from 1.8.6 to 1.8.7 due to high security issueWas solved in dependency withcoder/websocket#291Signed-off-by: jmeridth <jmeridth@gmail.com>

jmeridth added a commit to jmeridth/argo-cd that referenced this pull request

Aug 10, 2023

chore(deps): upgrade nhooyr.io/websocket dependency

a7d1a9e

Upgrade from 1.8.6 to 1.8.7 due to high security issueWas solved in dependency withcoder/websocket#291Signed-off-by: jmeridth <jmeridth@gmail.com>

jmeridth mentioned this pull request

Aug 10, 2023

chore(deps): upgrade nhooyr.io/websocket dependencyargoproj/argo-cd#15000

Merged

13 tasks

jmeridth added a commit to jmeridth/argo-cd that referenced this pull request

Aug 10, 2023

chore(deps): upgrade nhooyr.io/websocket dependency

962972d

Upgrade from 1.8.6 to 1.8.7 due to high security issueWas solved in dependency withcoder/websocket#291Signed-off-by: jmeridth <jmeridth@gmail.com>

crenshaw-dev pushed a commit to argoproj/argo-cd that referenced this pull request

Aug 10, 2023

chore(deps): upgrade nhooyr.io/websocket dependency (#15000)

9f51334

Upgrade from 1.8.6 to 1.8.7 due to high security issueWas solved in dependency withcoder/websocket#291Signed-off-by: jmeridth <jmeridth@gmail.com>

jmeridth added a commit to jmeridth/argo-cd that referenced this pull request

Aug 10, 2023

chore(deps): upgrade nhooyr.io/websocket dependency (argoproj#15000)

11daa77

Upgrade from 1.8.6 to 1.8.7 due to high security issueWas solved in dependency withcoder/websocket#291Signed-off-by: jmeridth <jmeridth@gmail.com>

jmeridth mentioned this pull request

Aug 10, 2023

chore(deps): upgrade nhooyr.io/websocket dependency (#15000)argoproj/argo-cd#15008

Merged

13 tasks

jmeridth added a commit to jmeridth/argo-cd that referenced this pull request

Aug 11, 2023

chore(deps): upgrade nhooyr.io/websocket dependency (argoproj#15000)

0e5844b

Upgrade from 1.8.6 to 1.8.7 due to high security issueWas solved in dependency withcoder/websocket#291Signed-off-by: jmeridth <jmeridth@gmail.com>

crenshaw-dev pushed a commit to argoproj/argo-cd that referenced this pull request

Aug 11, 2023

chore(deps): upgrade nhooyr.io/websocket dependency (#15000) (#15008)

092e55e

Upgrade from 1.8.6 to 1.8.7 due to high security issueWas solved in dependency withcoder/websocket#291Signed-off-by: jmeridth <jmeridth@gmail.com>

GeorgiYosifov pushed a commit to GeorgiYosifov/argo-cd that referenced this pull request

Aug 15, 2023

chore(deps): upgrade nhooyr.io/websocket dependency (argoproj#15000)

c2acff6

Upgrade from 1.8.6 to 1.8.7 due to high security issueWas solved in dependency withcoder/websocket#291Signed-off-by: jmeridth <jmeridth@gmail.com>Signed-off-by: GeorgiYosifov <georgi_yosifov99@abv.bg>

GeorgiYosifov pushed a commit to GeorgiYosifov/argo-cd that referenced this pull request

Aug 15, 2023

chore(deps): upgrade nhooyr.io/websocket dependency (argoproj#15000)

6bf902f

Upgrade from 1.8.6 to 1.8.7 due to high security issueWas solved in dependency withcoder/websocket#291Signed-off-by: jmeridth <jmeridth@gmail.com>

GeorgiYosifov pushed a commit to GeorgiYosifov/argo-cd that referenced this pull request

Aug 15, 2023

chore(deps): upgrade nhooyr.io/websocket dependency (argoproj#15000)

f739e25

Upgrade from 1.8.6 to 1.8.7 due to high security issueWas solved in dependency withcoder/websocket#291Signed-off-by: jmeridth <jmeridth@gmail.com>

alexymantha pushed a commit to alexymantha/argo-cd that referenced this pull request

Sep 1, 2023

chore(deps): upgrade nhooyr.io/websocket dependency (argoproj#15000)

32d1033

Upgrade from 1.8.6 to 1.8.7 due to high security issueWas solved in dependency withcoder/websocket#291Signed-off-by: jmeridth <jmeridth@gmail.com>Signed-off-by: Alexy Mantha <alexy@mantha.dev>

alexymantha pushed a commit to alexymantha/argo-cd that referenced this pull request

Sep 1, 2023

chore(deps): upgrade nhooyr.io/websocket dependency (argoproj#15000)

34fac25

Upgrade from 1.8.6 to 1.8.7 due to high security issueWas solved in dependency withcoder/websocket#291Signed-off-by: jmeridth <jmeridth@gmail.com>Signed-off-by: Alexy Mantha <alexy@mantha.dev>

Jneville0815 pushed a commit to radiusmethod/argo-cd that referenced this pull request

Sep 30, 2023

chore(deps): upgrade nhooyr.io/websocket dependency (argoproj#15000)

fed5155

Upgrade from 1.8.6 to 1.8.7 due to high security issueWas solved in dependency withcoder/websocket#291Signed-off-by: jmeridth <jmeridth@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>

crenshaw-dev added a commit to argoproj/argo-cd that referenced this pull request

Nov 1, 2023

feat: Allow 'both' option for uibannerposition (#14623)

51b4b20

* fix(ui): Drop ready from Completed container status (#14434) (#14629)Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/go-git/go-git/v5 from 5.7.0 to 5.8.0 (#14641)Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.7.0 to 5.8.0.- [Release notes](https://github.com/go-git/go-git/releases)- [Commits](https://github.com/go-git/go-git/compare/v5.7.0...v5.8.0)---updated-dependencies:- dependency-name: github.com/go-git/go-git/v5  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: webhook handler fails to refresh when alternate application namespaces are configured (#13976)* fix: Add failing test for webhooks in all namespacesThis adds a failing test that properly exercises this functionality overall namespaces. The issue with the code that is under test is that itdoes not pass the namespace correctly to the patch of the application,resulting in the patch not taking place in the correct namespaceSigned-off-by: Nikolas Skoufis <nskoufis@seek.com.au>* fix: queue webhook refresh for apps in all namespacesThis passes the test in the previous commit, to ensure that webhookscorrectly refresh applications across all namespaces.Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au>* fix: Use existing NamespacedName typeUse the existing type instead of a custom typeSigned-off-by: Nikolas Skoufis <nskoufis@seek.com.au>---------Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: ApplicationSet Controller crashes when tag is not closed; panic: Cannot find end tag="}}"(#14227) (#14651)* ApplicationSet bug fixSigned-off-by: schakrad <58915923+schakrad@users.noreply.github.com>* Update applicationset/utils/utils_test.goSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* oopsSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): The default pod group filter should be removed if fewer than 15 pods (#14590)Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(deep-links): sprig support (#14660)Signed-off-by: daftping <21245083+daftping@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Print in-cluster svr addr disabled warning when server starts (#14553)* chore: Print in-cluster svr addr disabled warning when server startsSigned-off-by: Yuan Tang <terrytangyuan@gmail.com>* fix: mockSigned-off-by: Yuan Tang <terrytangyuan@gmail.com>* no interface changeSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Upgrade semver to avoid cve (#14710)Signed-off-by: Yi Cai <yicai@redhat.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: adding a autosync_enabled field  to the argocd_app_info gauge (#14424)Signed-off-by: Gerardo Corea <gerardocorea92@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(controller): log failed attempts to update operation state (#14273)* fix(controller): log failed attempts to update operation stateSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* new package nameSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* Update controller/appcontroller_test.goSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(server): handle PATCH in http/s server (#2677) (#14530)Signed-off-by: mmerrill3 <jjpaacks@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: manifest generation error with null annotations (#14336) (#14680)* fix: manifest generation error with null annotationsSigned-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>* fix testSigned-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>* fix unit testsSigned-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>---------Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* Clean up repeated package import (#13889)Signed-off-by: Zechun Chen <zechun.chen@daocloud.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(sso): Set redirectURI for gitea, google, oauth Dex connectors (#11237)Signed-off-by: ylxianzhe <ylxianzhe@outlook.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(appset): Restrict scm provider urls (#14286)* 9353: Restrict scm provider urlsSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Enforce restrictionSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Fix after reviewSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Remove commentSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Fix units testsSigned-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com>* 9353: Code review, update commentSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Code review, update comment 2Signed-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Remove doc issuesSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Fix e2eSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Fix e2e goTemplateSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Fix e2e pullRequestGeneratorSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>---------Signed-off-by: gmuselli <geoffrey.muselli@gmail.com>Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/go-git/go-git/v5 from 5.8.0 to 5.8.1 (#14744)Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.8.0 to 5.8.1.- [Release notes](https://github.com/go-git/go-git/releases)- [Commits](https://github.com/go-git/go-git/compare/v5.8.0...v5.8.1)---updated-dependencies:- dependency-name: github.com/go-git/go-git/v5  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/aws/aws-sdk-go from 1.44.305 to 1.44.309 (#14746)Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.305 to 1.44.309.- [Release notes](https://github.com/aws/aws-sdk-go/releases)- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.305...v1.44.309)---updated-dependencies:- dependency-name: github.com/aws/aws-sdk-go  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): display valuesobject if set (#14257)* fix: display valuesobject if setWith #11538 we now have the ability to set helm values as an objectinstead of a string, but we also need to be able to correctly displayit in the UI if it is set.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* fix: set valuesobject on saveIf `valuesObject` is present, set it to the value of`input.spec.source.helm.values` on save, as an unmarshaled json string.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* fix: set `helm.values` to empty string on saveIf `valuesObject` exists, set `input.spec.source.helm.values` to anempty string once `valuesObject` has been unmarshalled from thevalues input. This is to prevent unnecessary duplication of the values.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* chore: eslintSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>* chore: eslintSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>* fix: deep clone appThis is so that we can conditionally set `source.helm.values` withoutinadvertently affecting other parts of the app. Only when the editbutton is pressed do we toggle `source.helm.values`.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* chore: eslintSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>---------Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: OCI dependency url can't contain part of repository (#14699)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Add missing value (#14538)Signed-off-by: felix <felix@psy-coding.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* [Bot] docs: Update Snyk reports (#14781)Signed-off-by: CI <ci@argoproj.com>Co-authored-by: CI <ci@argoproj.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/aws/aws-sdk-go from 1.44.309 to 1.44.312 (#14782)Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.309 to 1.44.312.- [Release notes](https://github.com/aws/aws-sdk-go/releases)- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.309...v1.44.312)---updated-dependencies:- dependency-name: github.com/aws/aws-sdk-go  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/xanzy/go-gitlab from 0.88.0 to 0.89.0 (#14784)Bumps [github.com/xanzy/go-gitlab](https://github.com/xanzy/go-gitlab) from 0.88.0 to 0.89.0.- [Changelog](https://github.com/xanzy/go-gitlab/blob/master/releases_test.go)- [Commits](https://github.com/xanzy/go-gitlab/compare/v0.88.0...v0.89.0)---updated-dependencies:- dependency-name: github.com/xanzy/go-gitlab  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/casbin/casbin/v2 from 2.72.1 to 2.73.0 (#14783)Bumps [github.com/casbin/casbin/v2](https://github.com/casbin/casbin) from 2.72.1 to 2.73.0.- [Release notes](https://github.com/casbin/casbin/releases)- [Changelog](https://github.com/casbin/casbin/blob/master/.releaserc.json)- [Commits](https://github.com/casbin/casbin/compare/v2.72.1...v2.73.0)---updated-dependencies:- dependency-name: github.com/casbin/casbin/v2  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add Autodesk to USERS.md (#14778)Signed-off-by: Dylan Page <dylan.page@autodesk.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Add query-scoped cluster URL in Cluster Secret E2E tests (#14446)* Add query-scoped cluster URL in Cluster Secret E2E testsSigned-off-by: Jonathan West <jonwest@redhat.com>* Respond to review commentsSigned-off-by: Jonathan West <jonwest@redhat.com>---------Signed-off-by: Jonathan West <jonwest@redhat.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Clarify that security policy covers last 3 versions (#14786)* docs: Clarify that security policy covers last 3 versionsSigned-off-by: Kostis Kapelonis <kostis@codefresh.io>* Update SECURITY.mdSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Kostis Kapelonis <kostis@codefresh.io>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(controller): cache deadlock on delete and re-add cluster (#14780)Signed-off-by: Nathan Romriell <nateromriell@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: make `helm template` errors less verbose (#14772)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(deep-links): alias `application` as `apps` for consistency with notifications engine (#14761)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): no hyphen for "create job" action + nice icon (#14776) (#14777)* chore(actions): space instead of hyphen in action name (#14776)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* new field for backwards-compatibilitySigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* align icons for maximum synergySigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* delete unused functionSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* revert unnecessary changesSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* Update docs/operator-manual/upgrading/2.7-2.8.mdSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Correct broken `forever` option in pod logs viewer. Fixes #14762 (#14763)Signed-off-by: Alex Collins <alex_collins@intuit.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update application.yaml (#14742)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: add ignoreDifferences name and namespace fields (#14741)* Update application.yamlSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* Update docs/operator-manual/application.yamlSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/node from 20.4.0 to 20.5.0 (#14664)Bumps library/node from 20.4.0 to 20.5.0.---updated-dependencies:- dependency-name: library/node  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/node from 20.4.0 to 20.5.0 in /ui-test (#14662)Bumps library/node from 20.4.0 to 20.5.0.---updated-dependencies:- dependency-name: library/node  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update Controlling-Resource-Modification.md (#14751)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(notifications-catalog): Add nil check for notifications_catalog triggers (#14795)* Add nil check for notifications_catalog triggersSigned-off-by: Trung <trung.hoang@pricehubble.com>* Use correct nil checkSigned-off-by: Trung <trung.hoang@pricehubble.com>* Add missing catalog generation to makefileSigned-off-by: Trung <trung.hoang@pricehubble.com>* Revert changes to update-manifests.shSigned-off-by: Trung <trung.hoang@pricehubble.com>---------Signed-off-by: Trung <trung.hoang@pricehubble.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: ManagedResources API should not return diff for hooks (#14816)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Change Generator docs for List Generator to note any key/value pairs can be used (#14825)This is no longer limited to cluster/url value pairs.Signed-off-by: JesseBot <jessebot@linux.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: improve app destination docstrings (#14836)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: Adding kubelogin capability to argocd-k8s-auth (#9460) (#10700)Signed-off-by: mmerrill3 <jjpaacks@gmail.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Add header support for proxy extension requests  (#14800)* chore: add server URL in the header of proxy extensionsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>* feat: add header support for proxy extension requestsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>* Address review commentsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>* address review commentsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>* Address review commentsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>* Address review commentsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>---------Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: use consistent password in plugin generator examples (#14837)* docs: use consistent password in plugin generator examplesThe example secret with the token is using `strong-password`, but the later examples use `string-password`.This updates all of the examples to use `strong-password`.Signed-off-by: Nicholas Morey <nicholas@morey.tech>* docs: update another-secret example to include `strong-password`Consistent with above example of client token in argocd-secretSigned-off-by: Nicholas Morey <nicholas@morey.tech>---------Signed-off-by: Nicholas Morey <nicholas@morey.tech>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: give context to error logs #10592 (#14851)* chore: give context to error logsSigned-off-by: ashinsabu3 <ashin.sabu@harness.io>* Update reposerver/repository/repository.goSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: ashinsabu3 <ashin.sabu@harness.io>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add more tests in proxy extension headers (#14842)Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: revert #12255 (#14858)This reverts commit c651bd8de551c85fc897c997c1976d6777259921.Due to the imminent release of 2.8, this needs to be rolled back sincethe proposed fix in #14210 cannot make it in time.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Repo URL link for unsupported sources links to https://<argocd>/null/path/to/chart (#14861)* Fix #14860Fix #14860Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com>* Update USERS.mdSigned-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com>---------Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: correct discrepancies in generated swagger file (#14813)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: wrap ComparisonError messages (#14886)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): Fixes health icon positioning (#14708) (#14852)* fix: Fixes health icon positioning #14708Signed-off-by: ashinsabu3 <ashin.sabu@harness.io>* fix: Fixes alignment of app health application status panel #14708Signed-off-by: ashinsabu3 <ashin.sabu@harness.io>* fix: Added line height to App Status to fix its  positioning #14708Signed-off-by: ashinsabu3 <ashin.sabu@harness.io>---------Signed-off-by: ashinsabu3 <ashin.sabu@harness.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: fix non-deterministic test (#14905)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Change underscore (_) back to plus (+) to get valid SemVer when when reading tags from OCI registry (#14537)* fix: Change underscore (_) back to plus (+) to get valid SemVer when reading tags from OCI registrySigned-off-by: xashr <saschasynaos@gmail.com>* Add test coverage for SemVer tags in TestGetTagsFromUrlSigned-off-by: xashr <saschasynaos@gmail.com>---------Signed-off-by: xashr <saschasynaos@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appset): typo in ARGOCD_APPLICATIONSET_CONTROLLER_ALLOWED_SCM_PROVIDERS (#14902) (#14913)Signed-off-by: gmuselli <geoffrey.muselli@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: provide short revision in ARGOCD_APP_REVISION_SHORT env variable (#14926)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/aws/aws-sdk-go from 1.44.312 to 1.44.317 (#14925)Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.312 to 1.44.317.- [Release notes](https://github.com/aws/aws-sdk-go/releases)- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.312...v1.44.317)---updated-dependencies:- dependency-name: github.com/aws/aws-sdk-go  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump golang.org/x/oauth2 from 0.10.0 to 0.11.0 (#14922)Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.10.0 to 0.11.0.- [Commits](https://github.com/golang/oauth2/compare/v0.10.0...v0.11.0)---updated-dependencies:- dependency-name: golang.org/x/oauth2  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update Generators-Git.md (#14921)Remove a misleading symbol from the pattern for the path.Match function. The pipe symbol doesn't have any special meaning.Signed-off-by: German Lashevich <german.lashevich@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update helm.md - add missing syntax highlighting for YAML and Dockerfile blocks (#14911)Signed-off-by: JesseBot <jessebot@linux.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): COPY JSON for ArgoCD version should include trailing newline (#5117) (#14917)Signed-off-by: Vipin M S <vipinachar2016@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* [Bot] docs: Update Snyk reports (#14919)Signed-off-by: CI <ci@argoproj.com>Co-authored-by: CI <ci@argoproj.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: give context to error logs (#10592) (#14915)* chore: wrap error objects to include contextSigned-off-by: Vipin M S <vipinachar2016@gmail.com>* chore: wrap error objects to include contextSigned-off-by: Vipin M S <vipinachar2016@gmail.com>* chore: wrap error objects to include contextSigned-off-by: Vipin M S <vipinachar2016@gmail.com>* chore: wrap error objects to include contextSigned-off-by: Vipin M S <vipinachar2016@gmail.com>* Update applicationset/controllers/applicationset_controller.goSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Vipin M S <vipinachar2016@gmail.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(appset): Add SCM Provider option for Gitlab generator to filter shared projects from subgroups projects (#14831)* added option to disable gitlab to fetch shared project from a subgroupSigned-off-by: Prune <prune@lecentre.net>* Correct gitlab SCM provider mock testSigned-off-by: Prune <prune@lecentre.net>* updated test to validate shared-groupsSigned-off-by: Prune <prune@lecentre.net>* reworked shared project testsSigned-off-by: Prune <prune@lecentre.net>* added subgroups only testSigned-off-by: Prune <prune@lecentre.net>---------Signed-off-by: Prune <prune@lecentre.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(cmp): send sigterm to cmp commands before sigkill to allow for potential cleanup (#9180) (#14955)* fix: send sigterm to cmp commands before sigkill to allow for potential cleanupSigned-off-by: Ashin Sabu <ashin.sabu@harness.io>* fix: unit test for runCommand in cmpserver to test cleanup modifiedSigned-off-by: Ashin Sabu <ashin.sabu@harness.io>* fix: change unit test for plugin/runCommand to avoid bad trap along with lint fixSigned-off-by: Ashin Sabu <ashin.sabu@harness.io>---------Signed-off-by: Ashin Sabu <ashin.sabu@harness.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Feature bounty proposal (Experimental) (#14234)* Create bounty proposalSigned-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>---------Signed-off-by: Dan Garfield <dan@codefresh.io>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(actions): check if CronWorkflow has labels in create-workflow action (#14962) (#14974)Signed-off-by: Mickaël Canévet <mickael.canevet@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add Jellysmack in USERS.md (#14975)Signed-off-by: Mickaël Canévet <mickael.canevet@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump actions/setup-go from 4.0.1 to 4.1.0 (#14970)Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4.0.1 to 4.1.0.- [Release notes](https://github.com/actions/setup-go/releases)- [Commits](https://github.com/actions/setup-go/compare/fac708d6674e30b6ba41289acaab6d4b75aa0753...93397bea11091df50f3d7e59dc26a7711a8bcfbe)---updated-dependencies:- dependency-name: actions/setup-go  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Adding native OCI support proposal (#13516)Signed-off-by: Andrew Block <andy.block@gmail.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: space in 'Argo CD' (#14987)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: Add Support for AzureDevops Webhooks (#14969)* feat: Add Support for AzureDevops WebhooksSigned-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>* document azure devops webhook configurationSigned-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>---------Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: api server fails to call dex with istio (#14995)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): Update default and max count for maxCookieNumber (#14979)* Update default and max count for maxCookieNumberSigned-off-by: zvlb <vl.zemtsov@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: correct the swagger ui link to support --rootpath (#14845)Signed-off-by: Kevin Yue <yuezk001@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): upgrade nhooyr.io/websocket dependency (#15000)Upgrade from 1.8.6 to 1.8.7 due to high security issueWas solved in dependency with https://github.com/nhooyr/websocket/pull/291Signed-off-by: jmeridth <jmeridth@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: upgrade to go 1.21 (#14992)Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump goreleaser/goreleaser-action from 4.3.0 to 4.4.0 (#14996)Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 4.3.0 to 4.4.0.- [Release notes](https://github.com/goreleaser/goreleaser-action/releases)- [Commits](https://github.com/goreleaser/goreleaser-action/compare/336e29918d653399e599bfca99fadc1d7ffbc9f7...3fa32b8bb5620a2c1afe798654bbad59f9da4906)---updated-dependencies:- dependency-name: goreleaser/goreleaser-action  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: bump ubuntu base image (#15020) (#15021)Latest version of the ubuntu image addresses CVE-2023-38408.https://ubuntu.com/security/notices/USN-6242-1https://github.com/docker-library/repo-info/blob/master/repos/ubuntu/remote/22.04.mdresolves #15020Signed-off-by: Mason Cole <macole@beyondtrust.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: give context to errors (#10592) (#15022)* chore: give context to errorsSigned-off-by: Vipin M S <vipinachar2016@gmail.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/tls/tls.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/tls/tls.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/tls/tls.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Apply suggestions from code reviewSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Vipin M S <vipinachar2016@gmail.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: give context to errors (#15019)* chore: give context to error logs in reposerverSigned-off-by: Ashin Sabu <ashin.sabu@harness.io>* chore: give context to errors in applicationsetSigned-off-by: Ashin Sabu <ashin.sabu@harness.io>* chore: give context to errors(tweaks in error messages)Signed-off-by: Ashin Sabu <ashin.sabu@harness.io>* chore: give context to errors(fix unit test)Signed-off-by: Ashin Sabu <ashin.sabu@harness.io>---------Signed-off-by: Ashin Sabu <ashin.sabu@harness.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add Carrefour Group to USERS.md (#15039)Signed-off-by: Zadkiel Aharonian <zadkiel_aharonian@carrefour.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(health): spec.executor.instances is Optional, Support a flexible number of executors (#11877)Support a flexible number of executors. For example with a mounted ConfigMap inside the Spark-Operator.Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* [Bot] docs: Update Snyk reports (#15031)Signed-off-by: CI <ci@argoproj.com>Co-authored-by: CI <ci@argoproj.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(reposerver): loosen source not permitted helm errors (#14210)* fix: loosen source not permitted helm errorsWith #12255, we check if a source is first permitted before running`helm template`. This works a bit too well, since this may breakpreviously working manifests. If an `AppProject` has a set of`sourceRepos` which are more restrictive than `*`, and it also has Helmpublic dependencies (repos with credentials would not work with 2.7xdue to the fact they get filtered out before ending up on the reposerver). Whereas before this would work, this currently fails on`HEAD` but not in `2.7x`.What we instead do here is that we only run this check if the chartfailed to download - if it does then we run a check to see if the repois in the allowed repos list. If the repo is not in the allowed reposlist, we return the same error as in #12555, otherwise we bubble up theerror.Should fix #13833.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* fix: check for 401 unauthorized in errorThe regex check works fine for OCI artifacts, but the flow is slightlydifferent for standard Helm charts (specifically when running`helm repo add`). To get around that, we also check the error for`401 Unauthorized`.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* fix: loosen string checkSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>* Revert "chore: revert #12255 (#14858)"This reverts commit c8ae5bc3e79fa985632861f75669c07523f5ded6.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* wipSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>* wipSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>* chore: reword test to reduce confusionSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>---------Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appset): Fix helm valuesObject with ApplicationSet (#14912) (#14920)Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(cli): support apply out of sync flag only (#14624)* feat: support apply out of sync flag onlySigned-off-by: pashakostohrys <pavel@codefresh.io>* update engine versionSigned-off-by: pashakostohrys <pavel@codefresh.io>* update gitops engine versionSigned-off-by: pashakostohrys <pavel@codefresh.io>* add cli optionSigned-off-by: pashakostohrys <pavel@codefresh.io>* feat: verify apply out of sync flagSigned-off-by: pashakostohrys <pavel@codefresh.io>* redundant commentSigned-off-by: pashakostohrys <pavel@codefresh.io>* improve test logicSigned-off-by: pashakostohrys <pavel@codefresh.io>* change command description and do codegenSigned-off-by: pashakostohrys <pavel@codefresh.io>---------Signed-off-by: pashakostohrys <pavel@codefresh.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs(github): comment out notational pieces of PR template (#14888)- the DCO and FAQ sentences are not filled out during PRs and are purely notational  - comment them out with HTML comments, as is common practice    - example from argo-helm: https://github.com/argoproj/argo-helm/blob/962342fe2acef6022ac5c1a3eb352b336308b3eb/.github/pull_request_template.md?plain=1#L1      - copied this practice from other repos I maintain and from other repos before that- these comments are still visible to the PR author, just not visible when rendered, keeping the PR more conciseSigned-off-by: Anton Gilgur <agilgur5@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump golangci/golangci-lint-action from 3.6.0 to 3.7.0 (#15053)Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.6.0 to 3.7.0.- [Release notes](https://github.com/golangci/golangci-lint-action/releases)- [Commits](https://github.com/golangci/golangci-lint-action/compare/639cd343e1d3b897ff35927a75193d57cfcba299...3a919529898de77ec3da873e3063ca4b10e7f5cc)---updated-dependencies:- dependency-name: golangci/golangci-lint-action  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump actions/setup-node from 3.7.0 to 3.8.0 (#15054)Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.7.0 to 3.8.0.- [Release notes](https://github.com/actions/setup-node/releases)- [Commits](https://github.com/actions/setup-node/compare/e33196f7422957bea03ed53f6fbb155025ffc7b8...bea5baf987ba7aa777a8a0b4ace377a21c45c381)---updated-dependencies:- dependency-name: actions/setup-node  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update bank vaults link to point to the new org (#15069)Bank-Vaults recently migrated to a new organization. The old repository is archived.Signed-off-by: Anton Lindholm <LinAnt@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: improve error logs (#10592) (#15059)* chore: improve error logsSigned-off-by: AvhiMaz <avhimazumder5@outlook.com>* chore: Changes made according to the reviewerSigned-off-by: AvhiMaz <avhimazumder5@outlook.com>* chore: Chnages according to the reviewerI"Signed-off-by: AvhiMaz <avhimazumder5@outlook.com>* Update cmpserver/apiclient/plugin.pb.goSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: AvhiMaz <avhimazumder5@outlook.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update link to KubeCon China 2021 talk in README.md (#14887)Signed-off-by: Yuan (Terry) Tang <terrytangyuan@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: document permitOnlyProjectScopedClusters field (#15076)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: kubectl to synchronize argocd apps (#14881)We can use kubectl to synchronize argocd applications the same way we can usethe argocd cli or ui, however there's no documentation.This PR adds documentation for kubectl.Signed-off-by: Jordi Grant Esteve <jgrant.esteve@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: fix typo (#15083)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: add timeout for update cluster info (#14511)* chore: simplified parsing of startup parametersSigned-off-by: yyzxw <1020938856@qq.com>* feat: add timeout for update cluster infoSigned-off-by: yyzxw <1020938856@qq.com>---------Signed-off-by: yyzxw <1020938856@qq.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: requeue ApplicationSet if there are validation errors (#14429)Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: fix link for `argocd-repo-creds.yaml` sample (#15091)Signed-off-by: SHIMADA Kento <shimada.kento8974@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: wrap error objects to include context (#10592) (#15055)* chore: wrap error objects to include context (#10592)Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com>* chore: resolved common_test.go file as per reviewer's feedbackSigned-off-by: Pawank06 <pawan06kumar2003@gmail.com>* chore:changes in ulits.goSigned-off-by: Pawank06 <pawan06kumar2003@gmail.com>* chore: resolving utils_test.go fileSigned-off-by: Pawank06 <pawan06kumar2003@gmail.com>---------Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com>Signed-off-by: B Pawan Kumar <pawan06kumar2003@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(#12862): Update FlinkDeployment health check to support Flink v1.x (#15065)Signed-off-by: Dylan Slavin <dylan@sla.vin>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: add docs for various annotations and labels (#14020)* docs: add docs for various annotationsSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* more infoSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* more docsSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appset): bitbucket server scm provider EOF on empty repo (#14411)* fix bitbucket server scm provider EOF on empty repo default branch checkSigned-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>* add unit test for bitbucketServer empty repoSigned-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>* check for EOF explicitlySigned-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>---------Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: update confusing variable name (#15106)Signed-off-by: jmcshane <james.mcshane@superorbital.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs(progressive syncs): specify which ConfigMap to use (#15119)Signed-off-by: Gaël Jourdan-Weil <gjourdanweil@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(appset): added topic filter for Gitlab SCM (#14965)* added topic (tag) filter for Gitlab SCMSigned-off-by: Prune <prune@lecentre.net>* corrected few commentsSigned-off-by: Prune <prune@lecentre.net>* removed latest tag referencesSigned-off-by: Prune <prune@lecentre.net>---------Signed-off-by: Prune <prune@lecentre.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Add kustomization.yaml for server app RBAC (#15124)This change adds a `kustomization.yaml` file for the example RBACrole/rolebinding for argocd server applications.This makes it easier to include them as resources in another `kustomization.yaml`.Instead of including```yamlapiVersion: kustomize.config.k8s.io/v1beta1kind: Kustomizationresources:- https://raw.githubusercontent.com/argoproj/argo-cd/v2.8.0/examples/k8s-rbac/argocd-server-applications/argocd-server-rbac-clusterrole.yaml- https://raw.githubusercontent.com/argoproj/argo-cd/v2.8.0/examples/k8s-rbac/argocd-server-applications/argocd-server-rbac-clusterrolebinding.yaml```the user can now instead include```yamlapiVersion: kustomize.config.k8s.io/v1beta1kind: Kustomizationresources:- github.com/argoproj/argo-cd/examples/k8s-rbac/argocd-server-applications?ref=v2.8.0```This change was performed by running:```consolekustomize createkustomize edit add resource argocd-server-rbac-clusterrole.yamlkustomize edit add resource argocd-server-rbac-clusterrolebinding.yaml```Signed-off-by: Andreas Lindhé <andreas@lindhe.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: ✏️ fix typo on configmap name for private certs (#9596)Signed-off-by: Gaël Jourdan-Weil <gael.jourdan-weil@kelkoogroup.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* Merge pull request from GHSA-c8xw-vjgf-94hrSigned-off-by: pashakostohrys <pavel@codefresh.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): code lint (#15150)Signed-off-by: ebuildy <ebuildy@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: windows build (#15154)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: run refresh from UI in parallel (#15138)Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(cli): add support for components with non-default names (#10200) (#14605)* fix(cli): add support for components with non-default names (#10200)Co-Authored-By: maheshbaliga <mahesh.baliga@infracloud.io>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: maheshbaliga <mahesh.baliga@infracloud.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Updated docs about using a slash in ignoreDifferences (#15144)Signed-off-by: Christian Hernandez <christian@chernand.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: stop creating new otel interceptor to avoid memory leak (#15174)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add example jq path expression (#15130)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: document sourceNamespaces field (#15195)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appset): Matrix Generator Override not Working for Booleans (#14498) (#14573)* Fix AppSet matrix generator parameter overrideSigned-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com>* Add test case for parameter override fixSigned-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com>---------Signed-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: remove unnecessary version number (#15198)We have versioned docs now, no need for this.Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): switch podgroup notification to tooltip message (#14821)* improve pod grouping uxSigned-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>fix: update log view on container selectSigned-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>* fix(ui): improve pod grouping uxSigned-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>* fix(ui):update the pod grouping messages to tooltipSigned-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>* fix(ui):update the pod grouping messages to tooltipSigned-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>* fix: GroupNodes notificationSigned-off-by: AS <11219262+ashutosh16@users.noreply.github.com>* fix: GroupNodes notificationSigned-off-by: AS <11219262+ashutosh16@users.noreply.github.com>---------Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>Signed-off-by: AS <11219262+ashutosh16@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add upsider to USERS.md (#15228)Signed-off-by: Vlad Fratila <vlad.fratila@up-sider.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: clarify argocd-repo-server repo-cache-expiration HA use case (#15239)Signed-off-by: phanama <yudiandreanp@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: better logs for jq expression errors (#15226)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): Helm chart empty maintainers blow up Argo UI (#15225)Signed-off-by: Carlos Castro carlos.castro@jumo.worldSigned-off-by: Carlos Castro carlos.castro@jumo.worldSigned-off-by: Carlos Castro <carlos.castro@jumo.world>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add Kvist to USERS.md (#15240)Signed-off-by: Fredrik A. Madsen-Malmo <fredrik.malmo@icloud.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: improve doc on labels parameter on scmProvider generator (#15255)Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update ApplicationSet docs (#15269)Signed-off-by: David Muckle <dvdmuckle@dvdmuckle.xyz>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: support extra attributes for opentelemetry (#15071)Signed-off-by: penglongli <pelenli@tencent.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Add Twilio Segment to USERS.md (#15267)Thank you to the Argo community!Signed-off-by: Prasad Katti <prasad.katti@segment.com>Co-authored-by: jannfis <jann@mistrust.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: make WatchResourceTree use namespaced cache key (#15258)* fix: make WatchResourceTree use namespaced application cache keySigned-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com>* chore: add PGS to USERS.mdSigned-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com>---------Signed-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: remove duplicate function (#15123)Signed-off-by: yyzxw <1020938856@qq.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Cache control 404 asset requests (#15327)* backfill cache control header tests for ui assetsSigned-off-by: Scott Windsor <scott.windsor@flexe.com>* Set cache-control header non-cache for assets not foundSigned-off-by: Scott Windsor <scott.windsor@flexe.com>* fix golang-cilint warningSigned-off-by: Scott Windsor <scott.windsor@flexe.com>---------Signed-off-by: Scott Windsor <scott.windsor@flexe.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Fixes a markdown typo in USERS.md (#15362)This removes the whitespace between the link text and the link URL.Signed-off-by: Prasad Katti <prasad.katti@segment.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: upgrade notification engine (#15359)* Update notifications-engine dependenciesSigned-off-by: Mike Splain <mike.splain@gmail.com>* Update docsSigned-off-by: Mike Splain <mike.splain@gmail.com>---------Signed-off-by: Mike Splain <mike.splain@gmail.com>Co-authored-by: pasha-codefresh <pavel@codefresh.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: add Dott to users (#15370)Signed-off-by: Jake Burn <jake@ridedott.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(notifications-catalog): Add nil check for on-deployed trigger (#15363)Signed-off-by: Fs02 <surya.asriadie@gmail.com>Co-authored-by: pasha-codefresh <pavel@codefresh.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: auto respect rbac for discovery/sync (#14381)feat: auto respect rbac for discovery/sync (#14381)Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: Add ARGOCD_CLUSTER_CACHE_LIST_PAGE_BUFFER_SIZE environment variable (#15159)Signed-off-by: Brad West <brad.g.west@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appset): Revert applicationset-name labels (#15324)* fix(15282) Revert applicationset-name labelsSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* fix(15282) fix unit testSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>---------Signed-off-by: gmuselli <geoffrey.muselli@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/golang from 1.21.0 to 1.21.1 (#15391)Bumps library/golang from 1.21.0 to 1.21.1.---updated-dependencies:- dependency-name: library/golang  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/golang from 1.21.0 to 1.21.1 in /test/remote (#15387)Bumps library/golang from 1.21.0 to 1.21.1.---updated-dependencies:- dependency-name: library/golang  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/node from 20.4.0 to 20.6.0 in /test/container (#15366)Bumps library/node from 20.4.0 to 20.6.0.---updated-dependencies:- dependency-name: library/node  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* Merge pull request from GHSA-g687-f2gx-6wm8* feat: use untar with limiterSigned-off-by: pashakostohrys <pavel@codefresh.io>* feat: use untar with limiterSigned-off-by: pashakostohrys <pavel@codefresh.io>---------Signed-off-by: pashakostohrys <pavel@codefresh.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* Merge pull request from GHSA-fwr2-64vr-xv9m* fix: prevent seeing/editing 'kubectl.kubernetes.io/last-applied-configuration' cluster annotationSigned-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>* fix: failing unit testSigned-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>---------Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>Co-authored-by: iam-veeramalla <abhishek.veeramalla@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/node from 20.5.0 to 20.6.0 in /ui-test (#15364)Bumps library/node from 20.5.0 to 20.6.0.---updated-dependencies:- dependency-name: library/node  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: handle annotations for resources with ':' in the name (#15101) (#15380)* fix: handle annotations for resources with ':' in the nameSigned-off-by: Oreon Lothamer <oreon.lothamer@softrams.com>* fix: switch to using splitN for handling annotation splittingSigned-off-by: Oreon Lothamer <oreon.lothamer@softrams.com>* fix: check len(parts) !=3Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com>* Retrigger CI pipelineSigned-off-by: Oreon Lothamer <oreon.lothamer@softrams.com>---------Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Improve RBAC documentation (#15430)* Improve staging-db project nameThis change renames the project to distinguish it from the role.Signed-off-by: Andreas Lindhé <andreas@lindhe.io>* Rename db-staging role to singular formRole names should be singular ("User x has the role admin" as opposed to"User x has the role admins").Signed-off-by: Andreas Lindhé <andreas@lindhe.io>* Remove trailing newlinesSigned-off-by: Andreas Lindhé <andreas@lindhe.io>* Consistently mark `AppProject` as codeSigned-off-by: Andreas Lindhé <andreas@lindhe.io>* Replace ```shell with ```console in suitable placesSigned-off-by: Andreas Lindhé <andreas@lindhe.io>* Use consistent style for unordered listhttps://github.com/DavidAnson/markdownlint/blob/main/doc/md004.mdSigned-off-by: Andreas Lindhé <andreas@lindhe.io>* Use consistent emphasis stylehttps://github.com/DavidAnson/markdownlint/blob/main/doc/md049.mdSigned-off-by: Andreas Lindhé <andreas@lindhe.io>* Fix incorrect description of the staging-db exampleSigned-off-by: Andreas Lindhé <andreas@lindhe.io>---------Signed-off-by: Andreas Lindhé <andreas@lindhe.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appsets): gotemplate can cause panic from nil dereference (#15377) (#15378)* fix(appsets): gotemplate can cause panic from nil deferenceSigned-off-by: rumstead <37445536+rumstead@users.noreply.github.com>* fix(appsets): gotemplate can cause panic from nil dereferenceSigned-off-by: rumstead <37445536+rumstead@users.noreply.github.com>---------Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Fix flaky cluster test (#15433)Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* Fix requeue after for Matrix/Merge with SCM or ClusterDecision generators (#15407)Signed-off-by: Cezar Sa Espinola <cezarsa@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: added shorthand flags for follow and conatainre in app logs (#15400)* feat: added shorthand flags for follow and conatainre in app logsSigned-off-by: ashu <ashupednekar49@gmail.com>* doc: re-generated cli docsSigned-off-by: ashu <ashupednekar49@gmail.com>---------Signed-off-by: ashu <ashupednekar49@gmail.com>Co-authored-by: jannfis <jann@mistrust.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* [Bot] docs: Update Snyk reports (#15437)Signed-off-by: CI <ci@argoproj.com>Co-authored-by: CI <ci@argoproj.com>Co-authored-by: jannfis <jann@mistrust.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Better enforcement of application namespace restrictions (#15431)* fix: Better enforce application namespace restrictionsSigned-off-by: jannfis <jann@mistrust.net>* Only call ValidateDestination when allowedSigned-off-by: jannfis <jann@mistrust.net>---------Signed-off-by: jannfis <jann@mistrust.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: fix bullets (#15446)Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: failed to add cluster when the cluster server address is ipv6 (#8204) (#15350)* fix: failed to add cluster when the cluster server address is ipv6 (#8204)Signed-off-by: huyinhou <huyinhou@bytedance.com>* fix: failed to add cluster when the cluster server address is ipv6 (#8204)Signed-off-by: huyinhou <huyinhou@bytedance.com>* remove …

jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request

Nov 13, 2023

chore(deps): upgrade nhooyr.io/websocket dependency (argoproj#15000)

03b47c6

Upgrade from 1.8.6 to 1.8.7 due to high security issueWas solved in dependency withcoder/websocket#291Signed-off-by: jmeridth <jmeridth@gmail.com>Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>

jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request

Nov 13, 2023

feat: Allow 'both' option for uibannerposition (argoproj#14623)

b02ea5c

* fix(ui): Drop ready from Completed container status (#14434) (#14629)Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/go-git/go-git/v5 from 5.7.0 to 5.8.0 (#14641)Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.7.0 to 5.8.0.- [Release notes](https://github.com/go-git/go-git/releases)- [Commits](https://github.com/go-git/go-git/compare/v5.7.0...v5.8.0)---updated-dependencies:- dependency-name: github.com/go-git/go-git/v5  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: webhook handler fails to refresh when alternate application namespaces are configured (#13976)* fix: Add failing test for webhooks in all namespacesThis adds a failing test that properly exercises this functionality overall namespaces. The issue with the code that is under test is that itdoes not pass the namespace correctly to the patch of the application,resulting in the patch not taking place in the correct namespaceSigned-off-by: Nikolas Skoufis <nskoufis@seek.com.au>* fix: queue webhook refresh for apps in all namespacesThis passes the test in the previous commit, to ensure that webhookscorrectly refresh applications across all namespaces.Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au>* fix: Use existing NamespacedName typeUse the existing type instead of a custom typeSigned-off-by: Nikolas Skoufis <nskoufis@seek.com.au>---------Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: ApplicationSet Controller crashes when tag is not closed; panic: Cannot find end tag="}}"(#14227) (#14651)* ApplicationSet bug fixSigned-off-by: schakrad <58915923+schakrad@users.noreply.github.com>* Update applicationset/utils/utils_test.goSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* oopsSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): The default pod group filter should be removed if fewer than 15 pods (#14590)Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(deep-links): sprig support (#14660)Signed-off-by: daftping <21245083+daftping@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Print in-cluster svr addr disabled warning when server starts (#14553)* chore: Print in-cluster svr addr disabled warning when server startsSigned-off-by: Yuan Tang <terrytangyuan@gmail.com>* fix: mockSigned-off-by: Yuan Tang <terrytangyuan@gmail.com>* no interface changeSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Upgrade semver to avoid cve (#14710)Signed-off-by: Yi Cai <yicai@redhat.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: adding a autosync_enabled field  to the argocd_app_info gauge (#14424)Signed-off-by: Gerardo Corea <gerardocorea92@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(controller): log failed attempts to update operation state (#14273)* fix(controller): log failed attempts to update operation stateSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* new package nameSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* Update controller/appcontroller_test.goSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(server): handle PATCH in http/s server (#2677) (#14530)Signed-off-by: mmerrill3 <jjpaacks@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: manifest generation error with null annotations (#14336) (#14680)* fix: manifest generation error with null annotationsSigned-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>* fix testSigned-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>* fix unit testsSigned-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>---------Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* Clean up repeated package import (#13889)Signed-off-by: Zechun Chen <zechun.chen@daocloud.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(sso): Set redirectURI for gitea, google, oauth Dex connectors (#11237)Signed-off-by: ylxianzhe <ylxianzhe@outlook.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(appset): Restrict scm provider urls (#14286)* 9353: Restrict scm provider urlsSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Enforce restrictionSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Fix after reviewSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Remove commentSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Fix units testsSigned-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com>* 9353: Code review, update commentSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Code review, update comment 2Signed-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Remove doc issuesSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Fix e2eSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Fix e2e goTemplateSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Fix e2e pullRequestGeneratorSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>---------Signed-off-by: gmuselli <geoffrey.muselli@gmail.com>Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/go-git/go-git/v5 from 5.8.0 to 5.8.1 (#14744)Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.8.0 to 5.8.1.- [Release notes](https://github.com/go-git/go-git/releases)- [Commits](https://github.com/go-git/go-git/compare/v5.8.0...v5.8.1)---updated-dependencies:- dependency-name: github.com/go-git/go-git/v5  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/aws/aws-sdk-go from 1.44.305 to 1.44.309 (#14746)Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.305 to 1.44.309.- [Release notes](https://github.com/aws/aws-sdk-go/releases)- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.305...v1.44.309)---updated-dependencies:- dependency-name: github.com/aws/aws-sdk-go  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): display valuesobject if set (#14257)* fix: display valuesobject if setWith #11538 we now have the ability to set helm values as an objectinstead of a string, but we also need to be able to correctly displayit in the UI if it is set.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* fix: set valuesobject on saveIf `valuesObject` is present, set it to the value of`input.spec.source.helm.values` on save, as an unmarshaled json string.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* fix: set `helm.values` to empty string on saveIf `valuesObject` exists, set `input.spec.source.helm.values` to anempty string once `valuesObject` has been unmarshalled from thevalues input. This is to prevent unnecessary duplication of the values.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* chore: eslintSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>* chore: eslintSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>* fix: deep clone appThis is so that we can conditionally set `source.helm.values` withoutinadvertently affecting other parts of the app. Only when the editbutton is pressed do we toggle `source.helm.values`.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* chore: eslintSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>---------Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: OCI dependency url can't contain part of repository (#14699)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Add missing value (#14538)Signed-off-by: felix <felix@psy-coding.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* [Bot] docs: Update Snyk reports (#14781)Signed-off-by: CI <ci@argoproj.com>Co-authored-by: CI <ci@argoproj.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/aws/aws-sdk-go from 1.44.309 to 1.44.312 (#14782)Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.309 to 1.44.312.- [Release notes](https://github.com/aws/aws-sdk-go/releases)- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.309...v1.44.312)---updated-dependencies:- dependency-name: github.com/aws/aws-sdk-go  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/xanzy/go-gitlab from 0.88.0 to 0.89.0 (#14784)Bumps [github.com/xanzy/go-gitlab](https://github.com/xanzy/go-gitlab) from 0.88.0 to 0.89.0.- [Changelog](https://github.com/xanzy/go-gitlab/blob/master/releases_test.go)- [Commits](https://github.com/xanzy/go-gitlab/compare/v0.88.0...v0.89.0)---updated-dependencies:- dependency-name: github.com/xanzy/go-gitlab  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/casbin/casbin/v2 from 2.72.1 to 2.73.0 (#14783)Bumps [github.com/casbin/casbin/v2](https://github.com/casbin/casbin) from 2.72.1 to 2.73.0.- [Release notes](https://github.com/casbin/casbin/releases)- [Changelog](https://github.com/casbin/casbin/blob/master/.releaserc.json)- [Commits](https://github.com/casbin/casbin/compare/v2.72.1...v2.73.0)---updated-dependencies:- dependency-name: github.com/casbin/casbin/v2  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add Autodesk to USERS.md (#14778)Signed-off-by: Dylan Page <dylan.page@autodesk.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Add query-scoped cluster URL in Cluster Secret E2E tests (#14446)* Add query-scoped cluster URL in Cluster Secret E2E testsSigned-off-by: Jonathan West <jonwest@redhat.com>* Respond to review commentsSigned-off-by: Jonathan West <jonwest@redhat.com>---------Signed-off-by: Jonathan West <jonwest@redhat.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Clarify that security policy covers last 3 versions (#14786)* docs: Clarify that security policy covers last 3 versionsSigned-off-by: Kostis Kapelonis <kostis@codefresh.io>* Update SECURITY.mdSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Kostis Kapelonis <kostis@codefresh.io>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(controller): cache deadlock on delete and re-add cluster (#14780)Signed-off-by: Nathan Romriell <nateromriell@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: make `helm template` errors less verbose (#14772)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(deep-links): alias `application` as `apps` for consistency with notifications engine (#14761)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): no hyphen for "create job" action + nice icon (#14776) (#14777)* chore(actions): space instead of hyphen in action name (#14776)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* new field for backwards-compatibilitySigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* align icons for maximum synergySigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* delete unused functionSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* revert unnecessary changesSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* Update docs/operator-manual/upgrading/2.7-2.8.mdSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Correct broken `forever` option in pod logs viewer. Fixes #14762 (#14763)Signed-off-by: Alex Collins <alex_collins@intuit.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update application.yaml (#14742)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: add ignoreDifferences name and namespace fields (#14741)* Update application.yamlSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* Update docs/operator-manual/application.yamlSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/node from 20.4.0 to 20.5.0 (#14664)Bumps library/node from 20.4.0 to 20.5.0.---updated-dependencies:- dependency-name: library/node  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/node from 20.4.0 to 20.5.0 in /ui-test (#14662)Bumps library/node from 20.4.0 to 20.5.0.---updated-dependencies:- dependency-name: library/node  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update Controlling-Resource-Modification.md (#14751)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(notifications-catalog): Add nil check for notifications_catalog triggers (#14795)* Add nil check for notifications_catalog triggersSigned-off-by: Trung <trung.hoang@pricehubble.com>* Use correct nil checkSigned-off-by: Trung <trung.hoang@pricehubble.com>* Add missing catalog generation to makefileSigned-off-by: Trung <trung.hoang@pricehubble.com>* Revert changes to update-manifests.shSigned-off-by: Trung <trung.hoang@pricehubble.com>---------Signed-off-by: Trung <trung.hoang@pricehubble.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: ManagedResources API should not return diff for hooks (#14816)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Change Generator docs for List Generator to note any key/value pairs can be used (#14825)This is no longer limited to cluster/url value pairs.Signed-off-by: JesseBot <jessebot@linux.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: improve app destination docstrings (#14836)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: Adding kubelogin capability to argocd-k8s-auth (#9460) (#10700)Signed-off-by: mmerrill3 <jjpaacks@gmail.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Add header support for proxy extension requests  (#14800)* chore: add server URL in the header of proxy extensionsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>* feat: add header support for proxy extension requestsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>* Address review commentsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>* address review commentsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>* Address review commentsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>* Address review commentsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>---------Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: use consistent password in plugin generator examples (#14837)* docs: use consistent password in plugin generator examplesThe example secret with the token is using `strong-password`, but the later examples use `string-password`.This updates all of the examples to use `strong-password`.Signed-off-by: Nicholas Morey <nicholas@morey.tech>* docs: update another-secret example to include `strong-password`Consistent with above example of client token in argocd-secretSigned-off-by: Nicholas Morey <nicholas@morey.tech>---------Signed-off-by: Nicholas Morey <nicholas@morey.tech>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: give context to error logs #10592 (#14851)* chore: give context to error logsSigned-off-by: ashinsabu3 <ashin.sabu@harness.io>* Update reposerver/repository/repository.goSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: ashinsabu3 <ashin.sabu@harness.io>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add more tests in proxy extension headers (#14842)Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: revert #12255 (#14858)This reverts commit c651bd8de551c85fc897c997c1976d6777259921.Due to the imminent release of 2.8, this needs to be rolled back sincethe proposed fix in #14210 cannot make it in time.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Repo URL link for unsupported sources links to https://<argocd>/null/path/to/chart (#14861)* Fix #14860Fix #14860Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com>* Update USERS.mdSigned-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com>---------Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: correct discrepancies in generated swagger file (#14813)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: wrap ComparisonError messages (#14886)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): Fixes health icon positioning (#14708) (#14852)* fix: Fixes health icon positioning #14708Signed-off-by: ashinsabu3 <ashin.sabu@harness.io>* fix: Fixes alignment of app health application status panel #14708Signed-off-by: ashinsabu3 <ashin.sabu@harness.io>* fix: Added line height to App Status to fix its  positioning #14708Signed-off-by: ashinsabu3 <ashin.sabu@harness.io>---------Signed-off-by: ashinsabu3 <ashin.sabu@harness.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: fix non-deterministic test (#14905)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Change underscore (_) back to plus (+) to get valid SemVer when when reading tags from OCI registry (#14537)* fix: Change underscore (_) back to plus (+) to get valid SemVer when reading tags from OCI registrySigned-off-by: xashr <saschasynaos@gmail.com>* Add test coverage for SemVer tags in TestGetTagsFromUrlSigned-off-by: xashr <saschasynaos@gmail.com>---------Signed-off-by: xashr <saschasynaos@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appset): typo in ARGOCD_APPLICATIONSET_CONTROLLER_ALLOWED_SCM_PROVIDERS (#14902) (#14913)Signed-off-by: gmuselli <geoffrey.muselli@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: provide short revision in ARGOCD_APP_REVISION_SHORT env variable (#14926)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/aws/aws-sdk-go from 1.44.312 to 1.44.317 (#14925)Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.312 to 1.44.317.- [Release notes](https://github.com/aws/aws-sdk-go/releases)- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.312...v1.44.317)---updated-dependencies:- dependency-name: github.com/aws/aws-sdk-go  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump golang.org/x/oauth2 from 0.10.0 to 0.11.0 (#14922)Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.10.0 to 0.11.0.- [Commits](https://github.com/golang/oauth2/compare/v0.10.0...v0.11.0)---updated-dependencies:- dependency-name: golang.org/x/oauth2  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update Generators-Git.md (#14921)Remove a misleading symbol from the pattern for the path.Match function. The pipe symbol doesn't have any special meaning.Signed-off-by: German Lashevich <german.lashevich@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update helm.md - add missing syntax highlighting for YAML and Dockerfile blocks (#14911)Signed-off-by: JesseBot <jessebot@linux.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): COPY JSON for ArgoCD version should include trailing newline (#5117) (#14917)Signed-off-by: Vipin M S <vipinachar2016@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* [Bot] docs: Update Snyk reports (#14919)Signed-off-by: CI <ci@argoproj.com>Co-authored-by: CI <ci@argoproj.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: give context to error logs (#10592) (#14915)* chore: wrap error objects to include contextSigned-off-by: Vipin M S <vipinachar2016@gmail.com>* chore: wrap error objects to include contextSigned-off-by: Vipin M S <vipinachar2016@gmail.com>* chore: wrap error objects to include contextSigned-off-by: Vipin M S <vipinachar2016@gmail.com>* chore: wrap error objects to include contextSigned-off-by: Vipin M S <vipinachar2016@gmail.com>* Update applicationset/controllers/applicationset_controller.goSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Vipin M S <vipinachar2016@gmail.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(appset): Add SCM Provider option for Gitlab generator to filter shared projects from subgroups projects (#14831)* added option to disable gitlab to fetch shared project from a subgroupSigned-off-by: Prune <prune@lecentre.net>* Correct gitlab SCM provider mock testSigned-off-by: Prune <prune@lecentre.net>* updated test to validate shared-groupsSigned-off-by: Prune <prune@lecentre.net>* reworked shared project testsSigned-off-by: Prune <prune@lecentre.net>* added subgroups only testSigned-off-by: Prune <prune@lecentre.net>---------Signed-off-by: Prune <prune@lecentre.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(cmp): send sigterm to cmp commands before sigkill to allow for potential cleanup (#9180) (#14955)* fix: send sigterm to cmp commands before sigkill to allow for potential cleanupSigned-off-by: Ashin Sabu <ashin.sabu@harness.io>* fix: unit test for runCommand in cmpserver to test cleanup modifiedSigned-off-by: Ashin Sabu <ashin.sabu@harness.io>* fix: change unit test for plugin/runCommand to avoid bad trap along with lint fixSigned-off-by: Ashin Sabu <ashin.sabu@harness.io>---------Signed-off-by: Ashin Sabu <ashin.sabu@harness.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Feature bounty proposal (Experimental) (#14234)* Create bounty proposalSigned-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>---------Signed-off-by: Dan Garfield <dan@codefresh.io>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(actions): check if CronWorkflow has labels in create-workflow action (#14962) (#14974)Signed-off-by: Mickaël Canévet <mickael.canevet@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add Jellysmack in USERS.md (#14975)Signed-off-by: Mickaël Canévet <mickael.canevet@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump actions/setup-go from 4.0.1 to 4.1.0 (#14970)Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4.0.1 to 4.1.0.- [Release notes](https://github.com/actions/setup-go/releases)- [Commits](https://github.com/actions/setup-go/compare/fac708d6674e30b6ba41289acaab6d4b75aa0753...93397bea11091df50f3d7e59dc26a7711a8bcfbe)---updated-dependencies:- dependency-name: actions/setup-go  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Adding native OCI support proposal (#13516)Signed-off-by: Andrew Block <andy.block@gmail.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: space in 'Argo CD' (#14987)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: Add Support for AzureDevops Webhooks (#14969)* feat: Add Support for AzureDevops WebhooksSigned-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>* document azure devops webhook configurationSigned-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>---------Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: api server fails to call dex with istio (#14995)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): Update default and max count for maxCookieNumber (#14979)* Update default and max count for maxCookieNumberSigned-off-by: zvlb <vl.zemtsov@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: correct the swagger ui link to support --rootpath (#14845)Signed-off-by: Kevin Yue <yuezk001@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): upgrade nhooyr.io/websocket dependency (#15000)Upgrade from 1.8.6 to 1.8.7 due to high security issueWas solved in dependency with https://github.com/nhooyr/websocket/pull/291Signed-off-by: jmeridth <jmeridth@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: upgrade to go 1.21 (#14992)Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump goreleaser/goreleaser-action from 4.3.0 to 4.4.0 (#14996)Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 4.3.0 to 4.4.0.- [Release notes](https://github.com/goreleaser/goreleaser-action/releases)- [Commits](https://github.com/goreleaser/goreleaser-action/compare/336e29918d653399e599bfca99fadc1d7ffbc9f7...3fa32b8bb5620a2c1afe798654bbad59f9da4906)---updated-dependencies:- dependency-name: goreleaser/goreleaser-action  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: bump ubuntu base image (#15020) (#15021)Latest version of the ubuntu image addresses CVE-2023-38408.https://ubuntu.com/security/notices/USN-6242-1https://github.com/docker-library/repo-info/blob/master/repos/ubuntu/remote/22.04.mdresolves #15020Signed-off-by: Mason Cole <macole@beyondtrust.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: give context to errors (#10592) (#15022)* chore: give context to errorsSigned-off-by: Vipin M S <vipinachar2016@gmail.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/tls/tls.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/tls/tls.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/tls/tls.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Apply suggestions from code reviewSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Vipin M S <vipinachar2016@gmail.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: give context to errors (#15019)* chore: give context to error logs in reposerverSigned-off-by: Ashin Sabu <ashin.sabu@harness.io>* chore: give context to errors in applicationsetSigned-off-by: Ashin Sabu <ashin.sabu@harness.io>* chore: give context to errors(tweaks in error messages)Signed-off-by: Ashin Sabu <ashin.sabu@harness.io>* chore: give context to errors(fix unit test)Signed-off-by: Ashin Sabu <ashin.sabu@harness.io>---------Signed-off-by: Ashin Sabu <ashin.sabu@harness.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add Carrefour Group to USERS.md (#15039)Signed-off-by: Zadkiel Aharonian <zadkiel_aharonian@carrefour.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(health): spec.executor.instances is Optional, Support a flexible number of executors (#11877)Support a flexible number of executors. For example with a mounted ConfigMap inside the Spark-Operator.Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* [Bot] docs: Update Snyk reports (#15031)Signed-off-by: CI <ci@argoproj.com>Co-authored-by: CI <ci@argoproj.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(reposerver): loosen source not permitted helm errors (#14210)* fix: loosen source not permitted helm errorsWith #12255, we check if a source is first permitted before running`helm template`. This works a bit too well, since this may breakpreviously working manifests. If an `AppProject` has a set of`sourceRepos` which are more restrictive than `*`, and it also has Helmpublic dependencies (repos with credentials would not work with 2.7xdue to the fact they get filtered out before ending up on the reposerver). Whereas before this would work, this currently fails on`HEAD` but not in `2.7x`.What we instead do here is that we only run this check if the chartfailed to download - if it does then we run a check to see if the repois in the allowed repos list. If the repo is not in the allowed reposlist, we return the same error as in #12555, otherwise we bubble up theerror.Should fix #13833.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* fix: check for 401 unauthorized in errorThe regex check works fine for OCI artifacts, but the flow is slightlydifferent for standard Helm charts (specifically when running`helm repo add`). To get around that, we also check the error for`401 Unauthorized`.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* fix: loosen string checkSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>* Revert "chore: revert #12255 (#14858)"This reverts commit c8ae5bc3e79fa985632861f75669c07523f5ded6.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* wipSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>* wipSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>* chore: reword test to reduce confusionSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>---------Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appset): Fix helm valuesObject with ApplicationSet (#14912) (#14920)Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(cli): support apply out of sync flag only (#14624)* feat: support apply out of sync flag onlySigned-off-by: pashakostohrys <pavel@codefresh.io>* update engine versionSigned-off-by: pashakostohrys <pavel@codefresh.io>* update gitops engine versionSigned-off-by: pashakostohrys <pavel@codefresh.io>* add cli optionSigned-off-by: pashakostohrys <pavel@codefresh.io>* feat: verify apply out of sync flagSigned-off-by: pashakostohrys <pavel@codefresh.io>* redundant commentSigned-off-by: pashakostohrys <pavel@codefresh.io>* improve test logicSigned-off-by: pashakostohrys <pavel@codefresh.io>* change command description and do codegenSigned-off-by: pashakostohrys <pavel@codefresh.io>---------Signed-off-by: pashakostohrys <pavel@codefresh.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs(github): comment out notational pieces of PR template (#14888)- the DCO and FAQ sentences are not filled out during PRs and are purely notational  - comment them out with HTML comments, as is common practice    - example from argo-helm: https://github.com/argoproj/argo-helm/blob/962342fe2acef6022ac5c1a3eb352b336308b3eb/.github/pull_request_template.md?plain=1#L1      - copied this practice from other repos I maintain and from other repos before that- these comments are still visible to the PR author, just not visible when rendered, keeping the PR more conciseSigned-off-by: Anton Gilgur <agilgur5@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump golangci/golangci-lint-action from 3.6.0 to 3.7.0 (#15053)Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.6.0 to 3.7.0.- [Release notes](https://github.com/golangci/golangci-lint-action/releases)- [Commits](https://github.com/golangci/golangci-lint-action/compare/639cd343e1d3b897ff35927a75193d57cfcba299...3a919529898de77ec3da873e3063ca4b10e7f5cc)---updated-dependencies:- dependency-name: golangci/golangci-lint-action  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump actions/setup-node from 3.7.0 to 3.8.0 (#15054)Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.7.0 to 3.8.0.- [Release notes](https://github.com/actions/setup-node/releases)- [Commits](https://github.com/actions/setup-node/compare/e33196f7422957bea03ed53f6fbb155025ffc7b8...bea5baf987ba7aa777a8a0b4ace377a21c45c381)---updated-dependencies:- dependency-name: actions/setup-node  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update bank vaults link to point to the new org (#15069)Bank-Vaults recently migrated to a new organization. The old repository is archived.Signed-off-by: Anton Lindholm <LinAnt@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: improve error logs (#10592) (#15059)* chore: improve error logsSigned-off-by: AvhiMaz <avhimazumder5@outlook.com>* chore: Changes made according to the reviewerSigned-off-by: AvhiMaz <avhimazumder5@outlook.com>* chore: Chnages according to the reviewerI"Signed-off-by: AvhiMaz <avhimazumder5@outlook.com>* Update cmpserver/apiclient/plugin.pb.goSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: AvhiMaz <avhimazumder5@outlook.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update link to KubeCon China 2021 talk in README.md (#14887)Signed-off-by: Yuan (Terry) Tang <terrytangyuan@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: document permitOnlyProjectScopedClusters field (#15076)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: kubectl to synchronize argocd apps (#14881)We can use kubectl to synchronize argocd applications the same way we can usethe argocd cli or ui, however there's no documentation.This PR adds documentation for kubectl.Signed-off-by: Jordi Grant Esteve <jgrant.esteve@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: fix typo (#15083)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: add timeout for update cluster info (#14511)* chore: simplified parsing of startup parametersSigned-off-by: yyzxw <1020938856@qq.com>* feat: add timeout for update cluster infoSigned-off-by: yyzxw <1020938856@qq.com>---------Signed-off-by: yyzxw <1020938856@qq.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: requeue ApplicationSet if there are validation errors (#14429)Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: fix link for `argocd-repo-creds.yaml` sample (#15091)Signed-off-by: SHIMADA Kento <shimada.kento8974@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: wrap error objects to include context (#10592) (#15055)* chore: wrap error objects to include context (#10592)Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com>* chore: resolved common_test.go file as per reviewer's feedbackSigned-off-by: Pawank06 <pawan06kumar2003@gmail.com>* chore:changes in ulits.goSigned-off-by: Pawank06 <pawan06kumar2003@gmail.com>* chore: resolving utils_test.go fileSigned-off-by: Pawank06 <pawan06kumar2003@gmail.com>---------Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com>Signed-off-by: B Pawan Kumar <pawan06kumar2003@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(#12862): Update FlinkDeployment health check to support Flink v1.x (#15065)Signed-off-by: Dylan Slavin <dylan@sla.vin>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: add docs for various annotations and labels (#14020)* docs: add docs for various annotationsSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* more infoSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* more docsSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appset): bitbucket server scm provider EOF on empty repo (#14411)* fix bitbucket server scm provider EOF on empty repo default branch checkSigned-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>* add unit test for bitbucketServer empty repoSigned-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>* check for EOF explicitlySigned-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>---------Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: update confusing variable name (#15106)Signed-off-by: jmcshane <james.mcshane@superorbital.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs(progressive syncs): specify which ConfigMap to use (#15119)Signed-off-by: Gaël Jourdan-Weil <gjourdanweil@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(appset): added topic filter for Gitlab SCM (#14965)* added topic (tag) filter for Gitlab SCMSigned-off-by: Prune <prune@lecentre.net>* corrected few commentsSigned-off-by: Prune <prune@lecentre.net>* removed latest tag referencesSigned-off-by: Prune <prune@lecentre.net>---------Signed-off-by: Prune <prune@lecentre.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Add kustomization.yaml for server app RBAC (#15124)This change adds a `kustomization.yaml` file for the example RBACrole/rolebinding for argocd server applications.This makes it easier to include them as resources in another `kustomization.yaml`.Instead of including```yamlapiVersion: kustomize.config.k8s.io/v1beta1kind: Kustomizationresources:- https://raw.githubusercontent.com/argoproj/argo-cd/v2.8.0/examples/k8s-rbac/argocd-server-applications/argocd-server-rbac-clusterrole.yaml- https://raw.githubusercontent.com/argoproj/argo-cd/v2.8.0/examples/k8s-rbac/argocd-server-applications/argocd-server-rbac-clusterrolebinding.yaml```the user can now instead include```yamlapiVersion: kustomize.config.k8s.io/v1beta1kind: Kustomizationresources:- github.com/argoproj/argo-cd/examples/k8s-rbac/argocd-server-applications?ref=v2.8.0```This change was performed by running:```consolekustomize createkustomize edit add resource argocd-server-rbac-clusterrole.yamlkustomize edit add resource argocd-server-rbac-clusterrolebinding.yaml```Signed-off-by: Andreas Lindhé <andreas@lindhe.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: ✏️ fix typo on configmap name for private certs (#9596)Signed-off-by: Gaël Jourdan-Weil <gael.jourdan-weil@kelkoogroup.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* Merge pull request from GHSA-c8xw-vjgf-94hrSigned-off-by: pashakostohrys <pavel@codefresh.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): code lint (#15150)Signed-off-by: ebuildy <ebuildy@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: windows build (#15154)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: run refresh from UI in parallel (#15138)Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(cli): add support for components with non-default names (#10200) (#14605)* fix(cli): add support for components with non-default names (#10200)Co-Authored-By: maheshbaliga <mahesh.baliga@infracloud.io>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: maheshbaliga <mahesh.baliga@infracloud.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Updated docs about using a slash in ignoreDifferences (#15144)Signed-off-by: Christian Hernandez <christian@chernand.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: stop creating new otel interceptor to avoid memory leak (#15174)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add example jq path expression (#15130)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: document sourceNamespaces field (#15195)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appset): Matrix Generator Override not Working for Booleans (#14498) (#14573)* Fix AppSet matrix generator parameter overrideSigned-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com>* Add test case for parameter override fixSigned-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com>---------Signed-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: remove unnecessary version number (#15198)We have versioned docs now, no need for this.Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): switch podgroup notification to tooltip message (#14821)* improve pod grouping uxSigned-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>fix: update log view on container selectSigned-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>* fix(ui): improve pod grouping uxSigned-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>* fix(ui):update the pod grouping messages to tooltipSigned-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>* fix(ui):update the pod grouping messages to tooltipSigned-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>* fix: GroupNodes notificationSigned-off-by: AS <11219262+ashutosh16@users.noreply.github.com>* fix: GroupNodes notificationSigned-off-by: AS <11219262+ashutosh16@users.noreply.github.com>---------Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>Signed-off-by: AS <11219262+ashutosh16@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add upsider to USERS.md (#15228)Signed-off-by: Vlad Fratila <vlad.fratila@up-sider.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: clarify argocd-repo-server repo-cache-expiration HA use case (#15239)Signed-off-by: phanama <yudiandreanp@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: better logs for jq expression errors (#15226)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): Helm chart empty maintainers blow up Argo UI (#15225)Signed-off-by: Carlos Castro carlos.castro@jumo.worldSigned-off-by: Carlos Castro carlos.castro@jumo.worldSigned-off-by: Carlos Castro <carlos.castro@jumo.world>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add Kvist to USERS.md (#15240)Signed-off-by: Fredrik A. Madsen-Malmo <fredrik.malmo@icloud.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: improve doc on labels parameter on scmProvider generator (#15255)Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update ApplicationSet docs (#15269)Signed-off-by: David Muckle <dvdmuckle@dvdmuckle.xyz>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: support extra attributes for opentelemetry (#15071)Signed-off-by: penglongli <pelenli@tencent.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Add Twilio Segment to USERS.md (#15267)Thank you to the Argo community!Signed-off-by: Prasad Katti <prasad.katti@segment.com>Co-authored-by: jannfis <jann@mistrust.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: make WatchResourceTree use namespaced cache key (#15258)* fix: make WatchResourceTree use namespaced application cache keySigned-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com>* chore: add PGS to USERS.mdSigned-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com>---------Signed-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: remove duplicate function (#15123)Signed-off-by: yyzxw <1020938856@qq.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Cache control 404 asset requests (#15327)* backfill cache control header tests for ui assetsSigned-off-by: Scott Windsor <scott.windsor@flexe.com>* Set cache-control header non-cache for assets not foundSigned-off-by: Scott Windsor <scott.windsor@flexe.com>* fix golang-cilint warningSigned-off-by: Scott Windsor <scott.windsor@flexe.com>---------Signed-off-by: Scott Windsor <scott.windsor@flexe.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Fixes a markdown typo in USERS.md (#15362)This removes the whitespace between the link text and the link URL.Signed-off-by: Prasad Katti <prasad.katti@segment.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: upgrade notification engine (#15359)* Update notifications-engine dependenciesSigned-off-by: Mike Splain <mike.splain@gmail.com>* Update docsSigned-off-by: Mike Splain <mike.splain@gmail.com>---------Signed-off-by: Mike Splain <mike.splain@gmail.com>Co-authored-by: pasha-codefresh <pavel@codefresh.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: add Dott to users (#15370)Signed-off-by: Jake Burn <jake@ridedott.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(notifications-catalog): Add nil check for on-deployed trigger (#15363)Signed-off-by: Fs02 <surya.asriadie@gmail.com>Co-authored-by: pasha-codefresh <pavel@codefresh.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: auto respect rbac for discovery/sync (#14381)feat: auto respect rbac for discovery/sync (#14381)Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: Add ARGOCD_CLUSTER_CACHE_LIST_PAGE_BUFFER_SIZE environment variable (#15159)Signed-off-by: Brad West <brad.g.west@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appset): Revert applicationset-name labels (#15324)* fix(15282) Revert applicationset-name labelsSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* fix(15282) fix unit testSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>---------Signed-off-by: gmuselli <geoffrey.muselli@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/golang from 1.21.0 to 1.21.1 (#15391)Bumps library/golang from 1.21.0 to 1.21.1.---updated-dependencies:- dependency-name: library/golang  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/golang from 1.21.0 to 1.21.1 in /test/remote (#15387)Bumps library/golang from 1.21.0 to 1.21.1.---updated-dependencies:- dependency-name: library/golang  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/node from 20.4.0 to 20.6.0 in /test/container (#15366)Bumps library/node from 20.4.0 to 20.6.0.---updated-dependencies:- dependency-name: library/node  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* Merge pull request from GHSA-g687-f2gx-6wm8* feat: use untar with limiterSigned-off-by: pashakostohrys <pavel@codefresh.io>* feat: use untar with limiterSigned-off-by: pashakostohrys <pavel@codefresh.io>---------Signed-off-by: pashakostohrys <pavel@codefresh.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* Merge pull request from GHSA-fwr2-64vr-xv9m* fix: prevent seeing/editing 'kubectl.kubernetes.io/last-applied-configuration' cluster annotationSigned-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>* fix: failing unit testSigned-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>---------Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>Co-authored-by: iam-veeramalla <abhishek.veeramalla@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/node from 20.5.0 to 20.6.0 in /ui-test (#15364)Bumps library/node from 20.5.0 to 20.6.0.---updated-dependencies:- dependency-name: library/node  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: handle annotations for resources with ':' in the name (#15101) (#15380)* fix: handle annotations for resources with ':' in the nameSigned-off-by: Oreon Lothamer <oreon.lothamer@softrams.com>* fix: switch to using splitN for handling annotation splittingSigned-off-by: Oreon Lothamer <oreon.lothamer@softrams.com>* fix: check len(parts) !=3Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com>* Retrigger CI pipelineSigned-off-by: Oreon Lothamer <oreon.lothamer@softrams.com>---------Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Improve RBAC documentation (#15430)* Improve staging-db project nameThis change renames the project to distinguish it from the role.Signed-off-by: Andreas Lindhé <andreas@lindhe.io>* Rename db-staging role to singular formRole names should be singular ("User x has the role admin" as opposed to"User x has the role admins").Signed-off-by: Andreas Lindhé <andreas@lindhe.io>* Remove trailing newlinesSigned-off-by: Andreas Lindhé <andreas@lindhe.io>* Consistently mark `AppProject` as codeSigned-off-by: Andreas Lindhé <andreas@lindhe.io>* Replace ```shell with ```console in suitable placesSigned-off-by: Andreas Lindhé <andreas@lindhe.io>* Use consistent style for unordered listhttps://github.com/DavidAnson/markdownlint/blob/main/doc/md004.mdSigned-off-by: Andreas Lindhé <andreas@lindhe.io>* Use consistent emphasis stylehttps://github.com/DavidAnson/markdownlint/blob/main/doc/md049.mdSigned-off-by: Andreas Lindhé <andreas@lindhe.io>* Fix incorrect description of the staging-db exampleSigned-off-by: Andreas Lindhé <andreas@lindhe.io>---------Signed-off-by: Andreas Lindhé <andreas@lindhe.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appsets): gotemplate can cause panic from nil dereference (#15377) (#15378)* fix(appsets): gotemplate can cause panic from nil deferenceSigned-off-by: rumstead <37445536+rumstead@users.noreply.github.com>* fix(appsets): gotemplate can cause panic from nil dereferenceSigned-off-by: rumstead <37445536+rumstead@users.noreply.github.com>---------Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Fix flaky cluster test (#15433)Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* Fix requeue after for Matrix/Merge with SCM or ClusterDecision generators (#15407)Signed-off-by: Cezar Sa Espinola <cezarsa@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: added shorthand flags for follow and conatainre in app logs (#15400)* feat: added shorthand flags for follow and conatainre in app logsSigned-off-by: ashu <ashupednekar49@gmail.com>* doc: re-generated cli docsSigned-off-by: ashu <ashupednekar49@gmail.com>---------Signed-off-by: ashu <ashupednekar49@gmail.com>Co-authored-by: jannfis <jann@mistrust.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* [Bot] docs: Update Snyk reports (#15437)Signed-off-by: CI <ci@argoproj.com>Co-authored-by: CI <ci@argoproj.com>Co-authored-by: jannfis <jann@mistrust.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Better enforcement of application namespace restrictions (#15431)* fix: Better enforce application namespace restrictionsSigned-off-by: jannfis <jann@mistrust.net>* Only call ValidateDestination when allowedSigned-off-by: jannfis <jann@mistrust.net>---------Signed-off-by: jannfis <jann@mistrust.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: fix bullets (#15446)Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: failed to add cluster when the cluster server address is ipv6 (#8204) (#15350)* fix: failed to add cluster when the cluster server address is ipv6 (#8204)Signed-off-by: huyinhou <huyinhou@bytedance.com>* fix: failed to add cluster when the cluster server address is ipv6 (#8204)Signed-off-by: huyinhou <huyinhou@bytedance.com>* remove unused importSigned-off-by: huyinhou <huyinhou@bytedance.com>* fix: lowercase URI secret name; abbreviated IPv6 addressSigned-off-by: huyinhou <huyinhou@bytedance.com>---------Signed-off-by: huyinhou <huyinhou@bytedance.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: Enable haproxy metrics through helm Chart (#15459)Signed-off-by: Mathias Petermann <mathias.petermann@swisscom.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* Stop appending :443 to the server address when using grpc-web (#15435)Signed-off-by: David Marby <david@dmarby.se>Co-authored-by: jannfis <jann@mistrust.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: appset preserve labels and global preserve fields (#15445)* feat: appset preserve labels and global preserve fieldsSigned-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>* feat: appset preserve labels and global preserve fieldsSigned-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>* docs: updated docsSigned-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>* docs: updated docsSigned-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>---------Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Gitlab scm_provider - don't create transport from scratch (#15424) (#15425)* fix : don't create transport from scratch, clone it insteadSigned-off-by: Antoine Jouve <ant.jouve@gmail.com>* feat: clone http.transport for gitea and gitlab providersSigned-off-by: Antoine Jouve <ant.jouve@gmail.com>* chore: properly format gitea providers with gofmtSigned-off-by: Antoine Jouve <ant.jouve@gmail.com>---------Signed-off-by: Antoine Jouve <ant.jouve@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add Factorial to USERS.md (#15473)Signed-off-by: Alejandro López Sánchez <alejandro.lopez@factorial.co>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>…

vladfr added a commit to vladfr/argo-cd that referenced this pull request

Dec 13, 2023

feat: Allow 'both' option for uibannerposition (argoproj#14623)

82237e7

* fix(ui): Drop ready from Completed container status (#14434) (#14629)Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/go-git/go-git/v5 from 5.7.0 to 5.8.0 (#14641)Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.7.0 to 5.8.0.- [Release notes](https://github.com/go-git/go-git/releases)- [Commits](https://github.com/go-git/go-git/compare/v5.7.0...v5.8.0)---updated-dependencies:- dependency-name: github.com/go-git/go-git/v5  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: webhook handler fails to refresh when alternate application namespaces are configured (#13976)* fix: Add failing test for webhooks in all namespacesThis adds a failing test that properly exercises this functionality overall namespaces. The issue with the code that is under test is that itdoes not pass the namespace correctly to the patch of the application,resulting in the patch not taking place in the correct namespaceSigned-off-by: Nikolas Skoufis <nskoufis@seek.com.au>* fix: queue webhook refresh for apps in all namespacesThis passes the test in the previous commit, to ensure that webhookscorrectly refresh applications across all namespaces.Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au>* fix: Use existing NamespacedName typeUse the existing type instead of a custom typeSigned-off-by: Nikolas Skoufis <nskoufis@seek.com.au>---------Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: ApplicationSet Controller crashes when tag is not closed; panic: Cannot find end tag="}}"(#14227) (#14651)* ApplicationSet bug fixSigned-off-by: schakrad <58915923+schakrad@users.noreply.github.com>* Update applicationset/utils/utils_test.goSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* oopsSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): The default pod group filter should be removed if fewer than 15 pods (#14590)Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(deep-links): sprig support (#14660)Signed-off-by: daftping <21245083+daftping@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Print in-cluster svr addr disabled warning when server starts (#14553)* chore: Print in-cluster svr addr disabled warning when server startsSigned-off-by: Yuan Tang <terrytangyuan@gmail.com>* fix: mockSigned-off-by: Yuan Tang <terrytangyuan@gmail.com>* no interface changeSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Upgrade semver to avoid cve (#14710)Signed-off-by: Yi Cai <yicai@redhat.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: adding a autosync_enabled field  to the argocd_app_info gauge (#14424)Signed-off-by: Gerardo Corea <gerardocorea92@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(controller): log failed attempts to update operation state (#14273)* fix(controller): log failed attempts to update operation stateSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* new package nameSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* Update controller/appcontroller_test.goSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(server): handle PATCH in http/s server (#2677) (#14530)Signed-off-by: mmerrill3 <jjpaacks@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: manifest generation error with null annotations (#14336) (#14680)* fix: manifest generation error with null annotationsSigned-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>* fix testSigned-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>* fix unit testsSigned-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>---------Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* Clean up repeated package import (#13889)Signed-off-by: Zechun Chen <zechun.chen@daocloud.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(sso): Set redirectURI for gitea, google, oauth Dex connectors (#11237)Signed-off-by: ylxianzhe <ylxianzhe@outlook.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(appset): Restrict scm provider urls (#14286)* 9353: Restrict scm provider urlsSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Enforce restrictionSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Fix after reviewSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Remove commentSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Fix units testsSigned-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com>* 9353: Code review, update commentSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Code review, update comment 2Signed-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Remove doc issuesSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Fix e2eSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Fix e2e goTemplateSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Fix e2e pullRequestGeneratorSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>---------Signed-off-by: gmuselli <geoffrey.muselli@gmail.com>Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/go-git/go-git/v5 from 5.8.0 to 5.8.1 (#14744)Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.8.0 to 5.8.1.- [Release notes](https://github.com/go-git/go-git/releases)- [Commits](https://github.com/go-git/go-git/compare/v5.8.0...v5.8.1)---updated-dependencies:- dependency-name: github.com/go-git/go-git/v5  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/aws/aws-sdk-go from 1.44.305 to 1.44.309 (#14746)Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.305 to 1.44.309.- [Release notes](https://github.com/aws/aws-sdk-go/releases)- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.305...v1.44.309)---updated-dependencies:- dependency-name: github.com/aws/aws-sdk-go  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): display valuesobject if set (#14257)* fix: display valuesobject if setWith #11538 we now have the ability to set helm values as an objectinstead of a string, but we also need to be able to correctly displayit in the UI if it is set.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* fix: set valuesobject on saveIf `valuesObject` is present, set it to the value of`input.spec.source.helm.values` on save, as an unmarshaled json string.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* fix: set `helm.values` to empty string on saveIf `valuesObject` exists, set `input.spec.source.helm.values` to anempty string once `valuesObject` has been unmarshalled from thevalues input. This is to prevent unnecessary duplication of the values.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* chore: eslintSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>* chore: eslintSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>* fix: deep clone appThis is so that we can conditionally set `source.helm.values` withoutinadvertently affecting other parts of the app. Only when the editbutton is pressed do we toggle `source.helm.values`.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* chore: eslintSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>---------Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: OCI dependency url can't contain part of repository (#14699)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Add missing value (#14538)Signed-off-by: felix <felix@psy-coding.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* [Bot] docs: Update Snyk reports (#14781)Signed-off-by: CI <ci@argoproj.com>Co-authored-by: CI <ci@argoproj.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/aws/aws-sdk-go from 1.44.309 to 1.44.312 (#14782)Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.309 to 1.44.312.- [Release notes](https://github.com/aws/aws-sdk-go/releases)- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.309...v1.44.312)---updated-dependencies:- dependency-name: github.com/aws/aws-sdk-go  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/xanzy/go-gitlab from 0.88.0 to 0.89.0 (#14784)Bumps [github.com/xanzy/go-gitlab](https://github.com/xanzy/go-gitlab) from 0.88.0 to 0.89.0.- [Changelog](https://github.com/xanzy/go-gitlab/blob/master/releases_test.go)- [Commits](https://github.com/xanzy/go-gitlab/compare/v0.88.0...v0.89.0)---updated-dependencies:- dependency-name: github.com/xanzy/go-gitlab  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/casbin/casbin/v2 from 2.72.1 to 2.73.0 (#14783)Bumps [github.com/casbin/casbin/v2](https://github.com/casbin/casbin) from 2.72.1 to 2.73.0.- [Release notes](https://github.com/casbin/casbin/releases)- [Changelog](https://github.com/casbin/casbin/blob/master/.releaserc.json)- [Commits](https://github.com/casbin/casbin/compare/v2.72.1...v2.73.0)---updated-dependencies:- dependency-name: github.com/casbin/casbin/v2  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add Autodesk to USERS.md (#14778)Signed-off-by: Dylan Page <dylan.page@autodesk.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Add query-scoped cluster URL in Cluster Secret E2E tests (#14446)* Add query-scoped cluster URL in Cluster Secret E2E testsSigned-off-by: Jonathan West <jonwest@redhat.com>* Respond to review commentsSigned-off-by: Jonathan West <jonwest@redhat.com>---------Signed-off-by: Jonathan West <jonwest@redhat.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Clarify that security policy covers last 3 versions (#14786)* docs: Clarify that security policy covers last 3 versionsSigned-off-by: Kostis Kapelonis <kostis@codefresh.io>* Update SECURITY.mdSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Kostis Kapelonis <kostis@codefresh.io>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(controller): cache deadlock on delete and re-add cluster (#14780)Signed-off-by: Nathan Romriell <nateromriell@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: make `helm template` errors less verbose (#14772)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(deep-links): alias `application` as `apps` for consistency with notifications engine (#14761)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): no hyphen for "create job" action + nice icon (#14776) (#14777)* chore(actions): space instead of hyphen in action name (#14776)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* new field for backwards-compatibilitySigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* align icons for maximum synergySigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* delete unused functionSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* revert unnecessary changesSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* Update docs/operator-manual/upgrading/2.7-2.8.mdSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Correct broken `forever` option in pod logs viewer. Fixes #14762 (#14763)Signed-off-by: Alex Collins <alex_collins@intuit.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update application.yaml (#14742)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: add ignoreDifferences name and namespace fields (#14741)* Update application.yamlSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* Update docs/operator-manual/application.yamlSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/node from 20.4.0 to 20.5.0 (#14664)Bumps library/node from 20.4.0 to 20.5.0.---updated-dependencies:- dependency-name: library/node  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/node from 20.4.0 to 20.5.0 in /ui-test (#14662)Bumps library/node from 20.4.0 to 20.5.0.---updated-dependencies:- dependency-name: library/node  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update Controlling-Resource-Modification.md (#14751)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(notifications-catalog): Add nil check for notifications_catalog triggers (#14795)* Add nil check for notifications_catalog triggersSigned-off-by: Trung <trung.hoang@pricehubble.com>* Use correct nil checkSigned-off-by: Trung <trung.hoang@pricehubble.com>* Add missing catalog generation to makefileSigned-off-by: Trung <trung.hoang@pricehubble.com>* Revert changes to update-manifests.shSigned-off-by: Trung <trung.hoang@pricehubble.com>---------Signed-off-by: Trung <trung.hoang@pricehubble.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: ManagedResources API should not return diff for hooks (#14816)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Change Generator docs for List Generator to note any key/value pairs can be used (#14825)This is no longer limited to cluster/url value pairs.Signed-off-by: JesseBot <jessebot@linux.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: improve app destination docstrings (#14836)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: Adding kubelogin capability to argocd-k8s-auth (#9460) (#10700)Signed-off-by: mmerrill3 <jjpaacks@gmail.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Add header support for proxy extension requests  (#14800)* chore: add server URL in the header of proxy extensionsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>* feat: add header support for proxy extension requestsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>* Address review commentsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>* address review commentsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>* Address review commentsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>* Address review commentsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>---------Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: use consistent password in plugin generator examples (#14837)* docs: use consistent password in plugin generator examplesThe example secret with the token is using `strong-password`, but the later examples use `string-password`.This updates all of the examples to use `strong-password`.Signed-off-by: Nicholas Morey <nicholas@morey.tech>* docs: update another-secret example to include `strong-password`Consistent with above example of client token in argocd-secretSigned-off-by: Nicholas Morey <nicholas@morey.tech>---------Signed-off-by: Nicholas Morey <nicholas@morey.tech>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: give context to error logs #10592 (#14851)* chore: give context to error logsSigned-off-by: ashinsabu3 <ashin.sabu@harness.io>* Update reposerver/repository/repository.goSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: ashinsabu3 <ashin.sabu@harness.io>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add more tests in proxy extension headers (#14842)Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: revert #12255 (#14858)This reverts commit c651bd8de551c85fc897c997c1976d6777259921.Due to the imminent release of 2.8, this needs to be rolled back sincethe proposed fix in #14210 cannot make it in time.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Repo URL link for unsupported sources links to https://<argocd>/null/path/to/chart (#14861)* Fix #14860Fix #14860Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com>* Update USERS.mdSigned-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com>---------Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: correct discrepancies in generated swagger file (#14813)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: wrap ComparisonError messages (#14886)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): Fixes health icon positioning (#14708) (#14852)* fix: Fixes health icon positioning #14708Signed-off-by: ashinsabu3 <ashin.sabu@harness.io>* fix: Fixes alignment of app health application status panel #14708Signed-off-by: ashinsabu3 <ashin.sabu@harness.io>* fix: Added line height to App Status to fix its  positioning #14708Signed-off-by: ashinsabu3 <ashin.sabu@harness.io>---------Signed-off-by: ashinsabu3 <ashin.sabu@harness.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: fix non-deterministic test (#14905)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Change underscore (_) back to plus (+) to get valid SemVer when when reading tags from OCI registry (#14537)* fix: Change underscore (_) back to plus (+) to get valid SemVer when reading tags from OCI registrySigned-off-by: xashr <saschasynaos@gmail.com>* Add test coverage for SemVer tags in TestGetTagsFromUrlSigned-off-by: xashr <saschasynaos@gmail.com>---------Signed-off-by: xashr <saschasynaos@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appset): typo in ARGOCD_APPLICATIONSET_CONTROLLER_ALLOWED_SCM_PROVIDERS (#14902) (#14913)Signed-off-by: gmuselli <geoffrey.muselli@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: provide short revision in ARGOCD_APP_REVISION_SHORT env variable (#14926)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/aws/aws-sdk-go from 1.44.312 to 1.44.317 (#14925)Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.312 to 1.44.317.- [Release notes](https://github.com/aws/aws-sdk-go/releases)- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.312...v1.44.317)---updated-dependencies:- dependency-name: github.com/aws/aws-sdk-go  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump golang.org/x/oauth2 from 0.10.0 to 0.11.0 (#14922)Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.10.0 to 0.11.0.- [Commits](https://github.com/golang/oauth2/compare/v0.10.0...v0.11.0)---updated-dependencies:- dependency-name: golang.org/x/oauth2  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update Generators-Git.md (#14921)Remove a misleading symbol from the pattern for the path.Match function. The pipe symbol doesn't have any special meaning.Signed-off-by: German Lashevich <german.lashevich@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update helm.md - add missing syntax highlighting for YAML and Dockerfile blocks (#14911)Signed-off-by: JesseBot <jessebot@linux.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): COPY JSON for ArgoCD version should include trailing newline (#5117) (#14917)Signed-off-by: Vipin M S <vipinachar2016@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* [Bot] docs: Update Snyk reports (#14919)Signed-off-by: CI <ci@argoproj.com>Co-authored-by: CI <ci@argoproj.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: give context to error logs (#10592) (#14915)* chore: wrap error objects to include contextSigned-off-by: Vipin M S <vipinachar2016@gmail.com>* chore: wrap error objects to include contextSigned-off-by: Vipin M S <vipinachar2016@gmail.com>* chore: wrap error objects to include contextSigned-off-by: Vipin M S <vipinachar2016@gmail.com>* chore: wrap error objects to include contextSigned-off-by: Vipin M S <vipinachar2016@gmail.com>* Update applicationset/controllers/applicationset_controller.goSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Vipin M S <vipinachar2016@gmail.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(appset): Add SCM Provider option for Gitlab generator to filter shared projects from subgroups projects (#14831)* added option to disable gitlab to fetch shared project from a subgroupSigned-off-by: Prune <prune@lecentre.net>* Correct gitlab SCM provider mock testSigned-off-by: Prune <prune@lecentre.net>* updated test to validate shared-groupsSigned-off-by: Prune <prune@lecentre.net>* reworked shared project testsSigned-off-by: Prune <prune@lecentre.net>* added subgroups only testSigned-off-by: Prune <prune@lecentre.net>---------Signed-off-by: Prune <prune@lecentre.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(cmp): send sigterm to cmp commands before sigkill to allow for potential cleanup (#9180) (#14955)* fix: send sigterm to cmp commands before sigkill to allow for potential cleanupSigned-off-by: Ashin Sabu <ashin.sabu@harness.io>* fix: unit test for runCommand in cmpserver to test cleanup modifiedSigned-off-by: Ashin Sabu <ashin.sabu@harness.io>* fix: change unit test for plugin/runCommand to avoid bad trap along with lint fixSigned-off-by: Ashin Sabu <ashin.sabu@harness.io>---------Signed-off-by: Ashin Sabu <ashin.sabu@harness.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Feature bounty proposal (Experimental) (#14234)* Create bounty proposalSigned-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>---------Signed-off-by: Dan Garfield <dan@codefresh.io>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(actions): check if CronWorkflow has labels in create-workflow action (#14962) (#14974)Signed-off-by: Mickaël Canévet <mickael.canevet@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add Jellysmack in USERS.md (#14975)Signed-off-by: Mickaël Canévet <mickael.canevet@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump actions/setup-go from 4.0.1 to 4.1.0 (#14970)Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4.0.1 to 4.1.0.- [Release notes](https://github.com/actions/setup-go/releases)- [Commits](https://github.com/actions/setup-go/compare/fac708d6674e30b6ba41289acaab6d4b75aa0753...93397bea11091df50f3d7e59dc26a7711a8bcfbe)---updated-dependencies:- dependency-name: actions/setup-go  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Adding native OCI support proposal (#13516)Signed-off-by: Andrew Block <andy.block@gmail.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: space in 'Argo CD' (#14987)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: Add Support for AzureDevops Webhooks (#14969)* feat: Add Support for AzureDevops WebhooksSigned-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>* document azure devops webhook configurationSigned-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>---------Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: api server fails to call dex with istio (#14995)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): Update default and max count for maxCookieNumber (#14979)* Update default and max count for maxCookieNumberSigned-off-by: zvlb <vl.zemtsov@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: correct the swagger ui link to support --rootpath (#14845)Signed-off-by: Kevin Yue <yuezk001@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): upgrade nhooyr.io/websocket dependency (#15000)Upgrade from 1.8.6 to 1.8.7 due to high security issueWas solved in dependency with https://github.com/nhooyr/websocket/pull/291Signed-off-by: jmeridth <jmeridth@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: upgrade to go 1.21 (#14992)Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump goreleaser/goreleaser-action from 4.3.0 to 4.4.0 (#14996)Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 4.3.0 to 4.4.0.- [Release notes](https://github.com/goreleaser/goreleaser-action/releases)- [Commits](https://github.com/goreleaser/goreleaser-action/compare/336e29918d653399e599bfca99fadc1d7ffbc9f7...3fa32b8bb5620a2c1afe798654bbad59f9da4906)---updated-dependencies:- dependency-name: goreleaser/goreleaser-action  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: bump ubuntu base image (#15020) (#15021)Latest version of the ubuntu image addresses CVE-2023-38408.https://ubuntu.com/security/notices/USN-6242-1https://github.com/docker-library/repo-info/blob/master/repos/ubuntu/remote/22.04.mdresolves #15020Signed-off-by: Mason Cole <macole@beyondtrust.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: give context to errors (#10592) (#15022)* chore: give context to errorsSigned-off-by: Vipin M S <vipinachar2016@gmail.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/tls/tls.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/tls/tls.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/tls/tls.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Apply suggestions from code reviewSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Vipin M S <vipinachar2016@gmail.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: give context to errors (#15019)* chore: give context to error logs in reposerverSigned-off-by: Ashin Sabu <ashin.sabu@harness.io>* chore: give context to errors in applicationsetSigned-off-by: Ashin Sabu <ashin.sabu@harness.io>* chore: give context to errors(tweaks in error messages)Signed-off-by: Ashin Sabu <ashin.sabu@harness.io>* chore: give context to errors(fix unit test)Signed-off-by: Ashin Sabu <ashin.sabu@harness.io>---------Signed-off-by: Ashin Sabu <ashin.sabu@harness.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add Carrefour Group to USERS.md (#15039)Signed-off-by: Zadkiel Aharonian <zadkiel_aharonian@carrefour.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(health): spec.executor.instances is Optional, Support a flexible number of executors (#11877)Support a flexible number of executors. For example with a mounted ConfigMap inside the Spark-Operator.Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* [Bot] docs: Update Snyk reports (#15031)Signed-off-by: CI <ci@argoproj.com>Co-authored-by: CI <ci@argoproj.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(reposerver): loosen source not permitted helm errors (#14210)* fix: loosen source not permitted helm errorsWith #12255, we check if a source is first permitted before running`helm template`. This works a bit too well, since this may breakpreviously working manifests. If an `AppProject` has a set of`sourceRepos` which are more restrictive than `*`, and it also has Helmpublic dependencies (repos with credentials would not work with 2.7xdue to the fact they get filtered out before ending up on the reposerver). Whereas before this would work, this currently fails on`HEAD` but not in `2.7x`.What we instead do here is that we only run this check if the chartfailed to download - if it does then we run a check to see if the repois in the allowed repos list. If the repo is not in the allowed reposlist, we return the same error as in #12555, otherwise we bubble up theerror.Should fix #13833.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* fix: check for 401 unauthorized in errorThe regex check works fine for OCI artifacts, but the flow is slightlydifferent for standard Helm charts (specifically when running`helm repo add`). To get around that, we also check the error for`401 Unauthorized`.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* fix: loosen string checkSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>* Revert "chore: revert #12255 (#14858)"This reverts commit c8ae5bc3e79fa985632861f75669c07523f5ded6.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* wipSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>* wipSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>* chore: reword test to reduce confusionSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>---------Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appset): Fix helm valuesObject with ApplicationSet (#14912) (#14920)Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(cli): support apply out of sync flag only (#14624)* feat: support apply out of sync flag onlySigned-off-by: pashakostohrys <pavel@codefresh.io>* update engine versionSigned-off-by: pashakostohrys <pavel@codefresh.io>* update gitops engine versionSigned-off-by: pashakostohrys <pavel@codefresh.io>* add cli optionSigned-off-by: pashakostohrys <pavel@codefresh.io>* feat: verify apply out of sync flagSigned-off-by: pashakostohrys <pavel@codefresh.io>* redundant commentSigned-off-by: pashakostohrys <pavel@codefresh.io>* improve test logicSigned-off-by: pashakostohrys <pavel@codefresh.io>* change command description and do codegenSigned-off-by: pashakostohrys <pavel@codefresh.io>---------Signed-off-by: pashakostohrys <pavel@codefresh.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs(github): comment out notational pieces of PR template (#14888)- the DCO and FAQ sentences are not filled out during PRs and are purely notational  - comment them out with HTML comments, as is common practice    - example from argo-helm: https://github.com/argoproj/argo-helm/blob/962342fe2acef6022ac5c1a3eb352b336308b3eb/.github/pull_request_template.md?plain=1#L1      - copied this practice from other repos I maintain and from other repos before that- these comments are still visible to the PR author, just not visible when rendered, keeping the PR more conciseSigned-off-by: Anton Gilgur <agilgur5@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump golangci/golangci-lint-action from 3.6.0 to 3.7.0 (#15053)Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.6.0 to 3.7.0.- [Release notes](https://github.com/golangci/golangci-lint-action/releases)- [Commits](https://github.com/golangci/golangci-lint-action/compare/639cd343e1d3b897ff35927a75193d57cfcba299...3a919529898de77ec3da873e3063ca4b10e7f5cc)---updated-dependencies:- dependency-name: golangci/golangci-lint-action  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump actions/setup-node from 3.7.0 to 3.8.0 (#15054)Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.7.0 to 3.8.0.- [Release notes](https://github.com/actions/setup-node/releases)- [Commits](https://github.com/actions/setup-node/compare/e33196f7422957bea03ed53f6fbb155025ffc7b8...bea5baf987ba7aa777a8a0b4ace377a21c45c381)---updated-dependencies:- dependency-name: actions/setup-node  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update bank vaults link to point to the new org (#15069)Bank-Vaults recently migrated to a new organization. The old repository is archived.Signed-off-by: Anton Lindholm <LinAnt@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: improve error logs (#10592) (#15059)* chore: improve error logsSigned-off-by: AvhiMaz <avhimazumder5@outlook.com>* chore: Changes made according to the reviewerSigned-off-by: AvhiMaz <avhimazumder5@outlook.com>* chore: Chnages according to the reviewerI"Signed-off-by: AvhiMaz <avhimazumder5@outlook.com>* Update cmpserver/apiclient/plugin.pb.goSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: AvhiMaz <avhimazumder5@outlook.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update link to KubeCon China 2021 talk in README.md (#14887)Signed-off-by: Yuan (Terry) Tang <terrytangyuan@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: document permitOnlyProjectScopedClusters field (#15076)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: kubectl to synchronize argocd apps (#14881)We can use kubectl to synchronize argocd applications the same way we can usethe argocd cli or ui, however there's no documentation.This PR adds documentation for kubectl.Signed-off-by: Jordi Grant Esteve <jgrant.esteve@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: fix typo (#15083)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: add timeout for update cluster info (#14511)* chore: simplified parsing of startup parametersSigned-off-by: yyzxw <1020938856@qq.com>* feat: add timeout for update cluster infoSigned-off-by: yyzxw <1020938856@qq.com>---------Signed-off-by: yyzxw <1020938856@qq.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: requeue ApplicationSet if there are validation errors (#14429)Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: fix link for `argocd-repo-creds.yaml` sample (#15091)Signed-off-by: SHIMADA Kento <shimada.kento8974@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: wrap error objects to include context (#10592) (#15055)* chore: wrap error objects to include context (#10592)Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com>* chore: resolved common_test.go file as per reviewer's feedbackSigned-off-by: Pawank06 <pawan06kumar2003@gmail.com>* chore:changes in ulits.goSigned-off-by: Pawank06 <pawan06kumar2003@gmail.com>* chore: resolving utils_test.go fileSigned-off-by: Pawank06 <pawan06kumar2003@gmail.com>---------Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com>Signed-off-by: B Pawan Kumar <pawan06kumar2003@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(#12862): Update FlinkDeployment health check to support Flink v1.x (#15065)Signed-off-by: Dylan Slavin <dylan@sla.vin>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: add docs for various annotations and labels (#14020)* docs: add docs for various annotationsSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* more infoSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* more docsSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appset): bitbucket server scm provider EOF on empty repo (#14411)* fix bitbucket server scm provider EOF on empty repo default branch checkSigned-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>* add unit test for bitbucketServer empty repoSigned-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>* check for EOF explicitlySigned-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>---------Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: update confusing variable name (#15106)Signed-off-by: jmcshane <james.mcshane@superorbital.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs(progressive syncs): specify which ConfigMap to use (#15119)Signed-off-by: Gaël Jourdan-Weil <gjourdanweil@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(appset): added topic filter for Gitlab SCM (#14965)* added topic (tag) filter for Gitlab SCMSigned-off-by: Prune <prune@lecentre.net>* corrected few commentsSigned-off-by: Prune <prune@lecentre.net>* removed latest tag referencesSigned-off-by: Prune <prune@lecentre.net>---------Signed-off-by: Prune <prune@lecentre.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Add kustomization.yaml for server app RBAC (#15124)This change adds a `kustomization.yaml` file for the example RBACrole/rolebinding for argocd server applications.This makes it easier to include them as resources in another `kustomization.yaml`.Instead of including```yamlapiVersion: kustomize.config.k8s.io/v1beta1kind: Kustomizationresources:- https://raw.githubusercontent.com/argoproj/argo-cd/v2.8.0/examples/k8s-rbac/argocd-server-applications/argocd-server-rbac-clusterrole.yaml- https://raw.githubusercontent.com/argoproj/argo-cd/v2.8.0/examples/k8s-rbac/argocd-server-applications/argocd-server-rbac-clusterrolebinding.yaml```the user can now instead include```yamlapiVersion: kustomize.config.k8s.io/v1beta1kind: Kustomizationresources:- github.com/argoproj/argo-cd/examples/k8s-rbac/argocd-server-applications?ref=v2.8.0```This change was performed by running:```consolekustomize createkustomize edit add resource argocd-server-rbac-clusterrole.yamlkustomize edit add resource argocd-server-rbac-clusterrolebinding.yaml```Signed-off-by: Andreas Lindhé <andreas@lindhe.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: ✏️ fix typo on configmap name for private certs (#9596)Signed-off-by: Gaël Jourdan-Weil <gael.jourdan-weil@kelkoogroup.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* Merge pull request from GHSA-c8xw-vjgf-94hrSigned-off-by: pashakostohrys <pavel@codefresh.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): code lint (#15150)Signed-off-by: ebuildy <ebuildy@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: windows build (#15154)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: run refresh from UI in parallel (#15138)Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(cli): add support for components with non-default names (#10200) (#14605)* fix(cli): add support for components with non-default names (#10200)Co-Authored-By: maheshbaliga <mahesh.baliga@infracloud.io>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: maheshbaliga <mahesh.baliga@infracloud.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Updated docs about using a slash in ignoreDifferences (#15144)Signed-off-by: Christian Hernandez <christian@chernand.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: stop creating new otel interceptor to avoid memory leak (#15174)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add example jq path expression (#15130)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: document sourceNamespaces field (#15195)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appset): Matrix Generator Override not Working for Booleans (#14498) (#14573)* Fix AppSet matrix generator parameter overrideSigned-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com>* Add test case for parameter override fixSigned-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com>---------Signed-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: remove unnecessary version number (#15198)We have versioned docs now, no need for this.Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): switch podgroup notification to tooltip message (#14821)* improve pod grouping uxSigned-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>fix: update log view on container selectSigned-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>* fix(ui): improve pod grouping uxSigned-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>* fix(ui):update the pod grouping messages to tooltipSigned-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>* fix(ui):update the pod grouping messages to tooltipSigned-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>* fix: GroupNodes notificationSigned-off-by: AS <11219262+ashutosh16@users.noreply.github.com>* fix: GroupNodes notificationSigned-off-by: AS <11219262+ashutosh16@users.noreply.github.com>---------Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>Signed-off-by: AS <11219262+ashutosh16@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add upsider to USERS.md (#15228)Signed-off-by: Vlad Fratila <vlad.fratila@up-sider.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: clarify argocd-repo-server repo-cache-expiration HA use case (#15239)Signed-off-by: phanama <yudiandreanp@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: better logs for jq expression errors (#15226)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): Helm chart empty maintainers blow up Argo UI (#15225)Signed-off-by: Carlos Castro carlos.castro@jumo.worldSigned-off-by: Carlos Castro carlos.castro@jumo.worldSigned-off-by: Carlos Castro <carlos.castro@jumo.world>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add Kvist to USERS.md (#15240)Signed-off-by: Fredrik A. Madsen-Malmo <fredrik.malmo@icloud.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: improve doc on labels parameter on scmProvider generator (#15255)Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update ApplicationSet docs (#15269)Signed-off-by: David Muckle <dvdmuckle@dvdmuckle.xyz>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: support extra attributes for opentelemetry (#15071)Signed-off-by: penglongli <pelenli@tencent.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Add Twilio Segment to USERS.md (#15267)Thank you to the Argo community!Signed-off-by: Prasad Katti <prasad.katti@segment.com>Co-authored-by: jannfis <jann@mistrust.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: make WatchResourceTree use namespaced cache key (#15258)* fix: make WatchResourceTree use namespaced application cache keySigned-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com>* chore: add PGS to USERS.mdSigned-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com>---------Signed-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: remove duplicate function (#15123)Signed-off-by: yyzxw <1020938856@qq.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Cache control 404 asset requests (#15327)* backfill cache control header tests for ui assetsSigned-off-by: Scott Windsor <scott.windsor@flexe.com>* Set cache-control header non-cache for assets not foundSigned-off-by: Scott Windsor <scott.windsor@flexe.com>* fix golang-cilint warningSigned-off-by: Scott Windsor <scott.windsor@flexe.com>---------Signed-off-by: Scott Windsor <scott.windsor@flexe.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Fixes a markdown typo in USERS.md (#15362)This removes the whitespace between the link text and the link URL.Signed-off-by: Prasad Katti <prasad.katti@segment.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: upgrade notification engine (#15359)* Update notifications-engine dependenciesSigned-off-by: Mike Splain <mike.splain@gmail.com>* Update docsSigned-off-by: Mike Splain <mike.splain@gmail.com>---------Signed-off-by: Mike Splain <mike.splain@gmail.com>Co-authored-by: pasha-codefresh <pavel@codefresh.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: add Dott to users (#15370)Signed-off-by: Jake Burn <jake@ridedott.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(notifications-catalog): Add nil check for on-deployed trigger (#15363)Signed-off-by: Fs02 <surya.asriadie@gmail.com>Co-authored-by: pasha-codefresh <pavel@codefresh.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: auto respect rbac for discovery/sync (#14381)feat: auto respect rbac for discovery/sync (#14381)Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: Add ARGOCD_CLUSTER_CACHE_LIST_PAGE_BUFFER_SIZE environment variable (#15159)Signed-off-by: Brad West <brad.g.west@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appset): Revert applicationset-name labels (#15324)* fix(15282) Revert applicationset-name labelsSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* fix(15282) fix unit testSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>---------Signed-off-by: gmuselli <geoffrey.muselli@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/golang from 1.21.0 to 1.21.1 (#15391)Bumps library/golang from 1.21.0 to 1.21.1.---updated-dependencies:- dependency-name: library/golang  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/golang from 1.21.0 to 1.21.1 in /test/remote (#15387)Bumps library/golang from 1.21.0 to 1.21.1.---updated-dependencies:- dependency-name: library/golang  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/node from 20.4.0 to 20.6.0 in /test/container (#15366)Bumps library/node from 20.4.0 to 20.6.0.---updated-dependencies:- dependency-name: library/node  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* Merge pull request from GHSA-g687-f2gx-6wm8* feat: use untar with limiterSigned-off-by: pashakostohrys <pavel@codefresh.io>* feat: use untar with limiterSigned-off-by: pashakostohrys <pavel@codefresh.io>---------Signed-off-by: pashakostohrys <pavel@codefresh.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* Merge pull request from GHSA-fwr2-64vr-xv9m* fix: prevent seeing/editing 'kubectl.kubernetes.io/last-applied-configuration' cluster annotationSigned-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>* fix: failing unit testSigned-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>---------Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>Co-authored-by: iam-veeramalla <abhishek.veeramalla@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/node from 20.5.0 to 20.6.0 in /ui-test (#15364)Bumps library/node from 20.5.0 to 20.6.0.---updated-dependencies:- dependency-name: library/node  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: handle annotations for resources with ':' in the name (#15101) (#15380)* fix: handle annotations for resources with ':' in the nameSigned-off-by: Oreon Lothamer <oreon.lothamer@softrams.com>* fix: switch to using splitN for handling annotation splittingSigned-off-by: Oreon Lothamer <oreon.lothamer@softrams.com>* fix: check len(parts) !=3Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com>* Retrigger CI pipelineSigned-off-by: Oreon Lothamer <oreon.lothamer@softrams.com>---------Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Improve RBAC documentation (#15430)* Improve staging-db project nameThis change renames the project to distinguish it from the role.Signed-off-by: Andreas Lindhé <andreas@lindhe.io>* Rename db-staging role to singular formRole names should be singular ("User x has the role admin" as opposed to"User x has the role admins").Signed-off-by: Andreas Lindhé <andreas@lindhe.io>* Remove trailing newlinesSigned-off-by: Andreas Lindhé <andreas@lindhe.io>* Consistently mark `AppProject` as codeSigned-off-by: Andreas Lindhé <andreas@lindhe.io>* Replace ```shell with ```console in suitable placesSigned-off-by: Andreas Lindhé <andreas@lindhe.io>* Use consistent style for unordered listhttps://github.com/DavidAnson/markdownlint/blob/main/doc/md004.mdSigned-off-by: Andreas Lindhé <andreas@lindhe.io>* Use consistent emphasis stylehttps://github.com/DavidAnson/markdownlint/blob/main/doc/md049.mdSigned-off-by: Andreas Lindhé <andreas@lindhe.io>* Fix incorrect description of the staging-db exampleSigned-off-by: Andreas Lindhé <andreas@lindhe.io>---------Signed-off-by: Andreas Lindhé <andreas@lindhe.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appsets): gotemplate can cause panic from nil dereference (#15377) (#15378)* fix(appsets): gotemplate can cause panic from nil deferenceSigned-off-by: rumstead <37445536+rumstead@users.noreply.github.com>* fix(appsets): gotemplate can cause panic from nil dereferenceSigned-off-by: rumstead <37445536+rumstead@users.noreply.github.com>---------Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Fix flaky cluster test (#15433)Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* Fix requeue after for Matrix/Merge with SCM or ClusterDecision generators (#15407)Signed-off-by: Cezar Sa Espinola <cezarsa@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: added shorthand flags for follow and conatainre in app logs (#15400)* feat: added shorthand flags for follow and conatainre in app logsSigned-off-by: ashu <ashupednekar49@gmail.com>* doc: re-generated cli docsSigned-off-by: ashu <ashupednekar49@gmail.com>---------Signed-off-by: ashu <ashupednekar49@gmail.com>Co-authored-by: jannfis <jann@mistrust.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* [Bot] docs: Update Snyk reports (#15437)Signed-off-by: CI <ci@argoproj.com>Co-authored-by: CI <ci@argoproj.com>Co-authored-by: jannfis <jann@mistrust.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Better enforcement of application namespace restrictions (#15431)* fix: Better enforce application namespace restrictionsSigned-off-by: jannfis <jann@mistrust.net>* Only call ValidateDestination when allowedSigned-off-by: jannfis <jann@mistrust.net>---------Signed-off-by: jannfis <jann@mistrust.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: fix bullets (#15446)Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: failed to add cluster when the cluster server address is ipv6 (#8204) (#15350)* fix: failed to add cluster when the cluster server address is ipv6 (#8204)Signed-off-by: huyinhou <huyinhou@bytedance.com>* fix: failed to add cluster when the cluster server address is ipv6 (#8204)Signed-off-by: huyinhou <huyinhou@bytedance.com>* remove …

tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request

Dec 16, 2023

chore(deps): upgrade nhooyr.io/websocket dependency (argoproj#15000)

2d88cbf

Upgrade from 1.8.6 to 1.8.7 due to high security issueWas solved in dependency withcoder/websocket#291Signed-off-by: jmeridth <jmeridth@gmail.com>

tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request

Dec 16, 2023

feat: Allow 'both' option for uibannerposition (argoproj#14623)

559c3a1

* fix(ui): Drop ready from Completed container status (#14434) (#14629)Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/go-git/go-git/v5 from 5.7.0 to 5.8.0 (#14641)Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.7.0 to 5.8.0.- [Release notes](https://github.com/go-git/go-git/releases)- [Commits](https://github.com/go-git/go-git/compare/v5.7.0...v5.8.0)---updated-dependencies:- dependency-name: github.com/go-git/go-git/v5  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: webhook handler fails to refresh when alternate application namespaces are configured (#13976)* fix: Add failing test for webhooks in all namespacesThis adds a failing test that properly exercises this functionality overall namespaces. The issue with the code that is under test is that itdoes not pass the namespace correctly to the patch of the application,resulting in the patch not taking place in the correct namespaceSigned-off-by: Nikolas Skoufis <nskoufis@seek.com.au>* fix: queue webhook refresh for apps in all namespacesThis passes the test in the previous commit, to ensure that webhookscorrectly refresh applications across all namespaces.Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au>* fix: Use existing NamespacedName typeUse the existing type instead of a custom typeSigned-off-by: Nikolas Skoufis <nskoufis@seek.com.au>---------Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: ApplicationSet Controller crashes when tag is not closed; panic: Cannot find end tag="}}"(#14227) (#14651)* ApplicationSet bug fixSigned-off-by: schakrad <58915923+schakrad@users.noreply.github.com>* Update applicationset/utils/utils_test.goSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* oopsSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): The default pod group filter should be removed if fewer than 15 pods (#14590)Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(deep-links): sprig support (#14660)Signed-off-by: daftping <21245083+daftping@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Print in-cluster svr addr disabled warning when server starts (#14553)* chore: Print in-cluster svr addr disabled warning when server startsSigned-off-by: Yuan Tang <terrytangyuan@gmail.com>* fix: mockSigned-off-by: Yuan Tang <terrytangyuan@gmail.com>* no interface changeSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Upgrade semver to avoid cve (#14710)Signed-off-by: Yi Cai <yicai@redhat.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: adding a autosync_enabled field  to the argocd_app_info gauge (#14424)Signed-off-by: Gerardo Corea <gerardocorea92@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(controller): log failed attempts to update operation state (#14273)* fix(controller): log failed attempts to update operation stateSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* new package nameSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* Update controller/appcontroller_test.goSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(server): handle PATCH in http/s server (#2677) (#14530)Signed-off-by: mmerrill3 <jjpaacks@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: manifest generation error with null annotations (#14336) (#14680)* fix: manifest generation error with null annotationsSigned-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>* fix testSigned-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>* fix unit testsSigned-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>---------Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* Clean up repeated package import (#13889)Signed-off-by: Zechun Chen <zechun.chen@daocloud.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(sso): Set redirectURI for gitea, google, oauth Dex connectors (#11237)Signed-off-by: ylxianzhe <ylxianzhe@outlook.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(appset): Restrict scm provider urls (#14286)* 9353: Restrict scm provider urlsSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Enforce restrictionSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Fix after reviewSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Remove commentSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Fix units testsSigned-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com>* 9353: Code review, update commentSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Code review, update comment 2Signed-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Remove doc issuesSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Fix e2eSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Fix e2e goTemplateSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Fix e2e pullRequestGeneratorSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>---------Signed-off-by: gmuselli <geoffrey.muselli@gmail.com>Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/go-git/go-git/v5 from 5.8.0 to 5.8.1 (#14744)Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.8.0 to 5.8.1.- [Release notes](https://github.com/go-git/go-git/releases)- [Commits](https://github.com/go-git/go-git/compare/v5.8.0...v5.8.1)---updated-dependencies:- dependency-name: github.com/go-git/go-git/v5  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/aws/aws-sdk-go from 1.44.305 to 1.44.309 (#14746)Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.305 to 1.44.309.- [Release notes](https://github.com/aws/aws-sdk-go/releases)- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.305...v1.44.309)---updated-dependencies:- dependency-name: github.com/aws/aws-sdk-go  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): display valuesobject if set (#14257)* fix: display valuesobject if setWith #11538 we now have the ability to set helm values as an objectinstead of a string, but we also need to be able to correctly displayit in the UI if it is set.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* fix: set valuesobject on saveIf `valuesObject` is present, set it to the value of`input.spec.source.helm.values` on save, as an unmarshaled json string.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* fix: set `helm.values` to empty string on saveIf `valuesObject` exists, set `input.spec.source.helm.values` to anempty string once `valuesObject` has been unmarshalled from thevalues input. This is to prevent unnecessary duplication of the values.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* chore: eslintSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>* chore: eslintSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>* fix: deep clone appThis is so that we can conditionally set `source.helm.values` withoutinadvertently affecting other parts of the app. Only when the editbutton is pressed do we toggle `source.helm.values`.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* chore: eslintSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>---------Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: OCI dependency url can't contain part of repository (#14699)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Add missing value (#14538)Signed-off-by: felix <felix@psy-coding.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* [Bot] docs: Update Snyk reports (#14781)Signed-off-by: CI <ci@argoproj.com>Co-authored-by: CI <ci@argoproj.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/aws/aws-sdk-go from 1.44.309 to 1.44.312 (#14782)Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.309 to 1.44.312.- [Release notes](https://github.com/aws/aws-sdk-go/releases)- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.309...v1.44.312)---updated-dependencies:- dependency-name: github.com/aws/aws-sdk-go  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/xanzy/go-gitlab from 0.88.0 to 0.89.0 (#14784)Bumps [github.com/xanzy/go-gitlab](https://github.com/xanzy/go-gitlab) from 0.88.0 to 0.89.0.- [Changelog](https://github.com/xanzy/go-gitlab/blob/master/releases_test.go)- [Commits](https://github.com/xanzy/go-gitlab/compare/v0.88.0...v0.89.0)---updated-dependencies:- dependency-name: github.com/xanzy/go-gitlab  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/casbin/casbin/v2 from 2.72.1 to 2.73.0 (#14783)Bumps [github.com/casbin/casbin/v2](https://github.com/casbin/casbin) from 2.72.1 to 2.73.0.- [Release notes](https://github.com/casbin/casbin/releases)- [Changelog](https://github.com/casbin/casbin/blob/master/.releaserc.json)- [Commits](https://github.com/casbin/casbin/compare/v2.72.1...v2.73.0)---updated-dependencies:- dependency-name: github.com/casbin/casbin/v2  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add Autodesk to USERS.md (#14778)Signed-off-by: Dylan Page <dylan.page@autodesk.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Add query-scoped cluster URL in Cluster Secret E2E tests (#14446)* Add query-scoped cluster URL in Cluster Secret E2E testsSigned-off-by: Jonathan West <jonwest@redhat.com>* Respond to review commentsSigned-off-by: Jonathan West <jonwest@redhat.com>---------Signed-off-by: Jonathan West <jonwest@redhat.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Clarify that security policy covers last 3 versions (#14786)* docs: Clarify that security policy covers last 3 versionsSigned-off-by: Kostis Kapelonis <kostis@codefresh.io>* Update SECURITY.mdSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Kostis Kapelonis <kostis@codefresh.io>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(controller): cache deadlock on delete and re-add cluster (#14780)Signed-off-by: Nathan Romriell <nateromriell@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: make `helm template` errors less verbose (#14772)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(deep-links): alias `application` as `apps` for consistency with notifications engine (#14761)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): no hyphen for "create job" action + nice icon (#14776) (#14777)* chore(actions): space instead of hyphen in action name (#14776)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* new field for backwards-compatibilitySigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* align icons for maximum synergySigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* delete unused functionSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* revert unnecessary changesSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* Update docs/operator-manual/upgrading/2.7-2.8.mdSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Correct broken `forever` option in pod logs viewer. Fixes #14762 (#14763)Signed-off-by: Alex Collins <alex_collins@intuit.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update application.yaml (#14742)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: add ignoreDifferences name and namespace fields (#14741)* Update application.yamlSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* Update docs/operator-manual/application.yamlSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/node from 20.4.0 to 20.5.0 (#14664)Bumps library/node from 20.4.0 to 20.5.0.---updated-dependencies:- dependency-name: library/node  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/node from 20.4.0 to 20.5.0 in /ui-test (#14662)Bumps library/node from 20.4.0 to 20.5.0.---updated-dependencies:- dependency-name: library/node  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update Controlling-Resource-Modification.md (#14751)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(notifications-catalog): Add nil check for notifications_catalog triggers (#14795)* Add nil check for notifications_catalog triggersSigned-off-by: Trung <trung.hoang@pricehubble.com>* Use correct nil checkSigned-off-by: Trung <trung.hoang@pricehubble.com>* Add missing catalog generation to makefileSigned-off-by: Trung <trung.hoang@pricehubble.com>* Revert changes to update-manifests.shSigned-off-by: Trung <trung.hoang@pricehubble.com>---------Signed-off-by: Trung <trung.hoang@pricehubble.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: ManagedResources API should not return diff for hooks (#14816)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Change Generator docs for List Generator to note any key/value pairs can be used (#14825)This is no longer limited to cluster/url value pairs.Signed-off-by: JesseBot <jessebot@linux.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: improve app destination docstrings (#14836)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: Adding kubelogin capability to argocd-k8s-auth (#9460) (#10700)Signed-off-by: mmerrill3 <jjpaacks@gmail.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Add header support for proxy extension requests  (#14800)* chore: add server URL in the header of proxy extensionsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>* feat: add header support for proxy extension requestsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>* Address review commentsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>* address review commentsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>* Address review commentsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>* Address review commentsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>---------Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: use consistent password in plugin generator examples (#14837)* docs: use consistent password in plugin generator examplesThe example secret with the token is using `strong-password`, but the later examples use `string-password`.This updates all of the examples to use `strong-password`.Signed-off-by: Nicholas Morey <nicholas@morey.tech>* docs: update another-secret example to include `strong-password`Consistent with above example of client token in argocd-secretSigned-off-by: Nicholas Morey <nicholas@morey.tech>---------Signed-off-by: Nicholas Morey <nicholas@morey.tech>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: give context to error logs #10592 (#14851)* chore: give context to error logsSigned-off-by: ashinsabu3 <ashin.sabu@harness.io>* Update reposerver/repository/repository.goSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: ashinsabu3 <ashin.sabu@harness.io>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add more tests in proxy extension headers (#14842)Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: revert #12255 (#14858)This reverts commit c651bd8de551c85fc897c997c1976d6777259921.Due to the imminent release of 2.8, this needs to be rolled back sincethe proposed fix in #14210 cannot make it in time.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Repo URL link for unsupported sources links to https://<argocd>/null/path/to/chart (#14861)* Fix #14860Fix #14860Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com>* Update USERS.mdSigned-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com>---------Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: correct discrepancies in generated swagger file (#14813)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: wrap ComparisonError messages (#14886)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): Fixes health icon positioning (#14708) (#14852)* fix: Fixes health icon positioning #14708Signed-off-by: ashinsabu3 <ashin.sabu@harness.io>* fix: Fixes alignment of app health application status panel #14708Signed-off-by: ashinsabu3 <ashin.sabu@harness.io>* fix: Added line height to App Status to fix its  positioning #14708Signed-off-by: ashinsabu3 <ashin.sabu@harness.io>---------Signed-off-by: ashinsabu3 <ashin.sabu@harness.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: fix non-deterministic test (#14905)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Change underscore (_) back to plus (+) to get valid SemVer when when reading tags from OCI registry (#14537)* fix: Change underscore (_) back to plus (+) to get valid SemVer when reading tags from OCI registrySigned-off-by: xashr <saschasynaos@gmail.com>* Add test coverage for SemVer tags in TestGetTagsFromUrlSigned-off-by: xashr <saschasynaos@gmail.com>---------Signed-off-by: xashr <saschasynaos@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appset): typo in ARGOCD_APPLICATIONSET_CONTROLLER_ALLOWED_SCM_PROVIDERS (#14902) (#14913)Signed-off-by: gmuselli <geoffrey.muselli@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: provide short revision in ARGOCD_APP_REVISION_SHORT env variable (#14926)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/aws/aws-sdk-go from 1.44.312 to 1.44.317 (#14925)Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.312 to 1.44.317.- [Release notes](https://github.com/aws/aws-sdk-go/releases)- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.312...v1.44.317)---updated-dependencies:- dependency-name: github.com/aws/aws-sdk-go  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump golang.org/x/oauth2 from 0.10.0 to 0.11.0 (#14922)Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.10.0 to 0.11.0.- [Commits](https://github.com/golang/oauth2/compare/v0.10.0...v0.11.0)---updated-dependencies:- dependency-name: golang.org/x/oauth2  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update Generators-Git.md (#14921)Remove a misleading symbol from the pattern for the path.Match function. The pipe symbol doesn't have any special meaning.Signed-off-by: German Lashevich <german.lashevich@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update helm.md - add missing syntax highlighting for YAML and Dockerfile blocks (#14911)Signed-off-by: JesseBot <jessebot@linux.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): COPY JSON for ArgoCD version should include trailing newline (#5117) (#14917)Signed-off-by: Vipin M S <vipinachar2016@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* [Bot] docs: Update Snyk reports (#14919)Signed-off-by: CI <ci@argoproj.com>Co-authored-by: CI <ci@argoproj.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: give context to error logs (#10592) (#14915)* chore: wrap error objects to include contextSigned-off-by: Vipin M S <vipinachar2016@gmail.com>* chore: wrap error objects to include contextSigned-off-by: Vipin M S <vipinachar2016@gmail.com>* chore: wrap error objects to include contextSigned-off-by: Vipin M S <vipinachar2016@gmail.com>* chore: wrap error objects to include contextSigned-off-by: Vipin M S <vipinachar2016@gmail.com>* Update applicationset/controllers/applicationset_controller.goSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Vipin M S <vipinachar2016@gmail.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(appset): Add SCM Provider option for Gitlab generator to filter shared projects from subgroups projects (#14831)* added option to disable gitlab to fetch shared project from a subgroupSigned-off-by: Prune <prune@lecentre.net>* Correct gitlab SCM provider mock testSigned-off-by: Prune <prune@lecentre.net>* updated test to validate shared-groupsSigned-off-by: Prune <prune@lecentre.net>* reworked shared project testsSigned-off-by: Prune <prune@lecentre.net>* added subgroups only testSigned-off-by: Prune <prune@lecentre.net>---------Signed-off-by: Prune <prune@lecentre.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(cmp): send sigterm to cmp commands before sigkill to allow for potential cleanup (#9180) (#14955)* fix: send sigterm to cmp commands before sigkill to allow for potential cleanupSigned-off-by: Ashin Sabu <ashin.sabu@harness.io>* fix: unit test for runCommand in cmpserver to test cleanup modifiedSigned-off-by: Ashin Sabu <ashin.sabu@harness.io>* fix: change unit test for plugin/runCommand to avoid bad trap along with lint fixSigned-off-by: Ashin Sabu <ashin.sabu@harness.io>---------Signed-off-by: Ashin Sabu <ashin.sabu@harness.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Feature bounty proposal (Experimental) (#14234)* Create bounty proposalSigned-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>---------Signed-off-by: Dan Garfield <dan@codefresh.io>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(actions): check if CronWorkflow has labels in create-workflow action (#14962) (#14974)Signed-off-by: Mickaël Canévet <mickael.canevet@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add Jellysmack in USERS.md (#14975)Signed-off-by: Mickaël Canévet <mickael.canevet@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump actions/setup-go from 4.0.1 to 4.1.0 (#14970)Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4.0.1 to 4.1.0.- [Release notes](https://github.com/actions/setup-go/releases)- [Commits](https://github.com/actions/setup-go/compare/fac708d6674e30b6ba41289acaab6d4b75aa0753...93397bea11091df50f3d7e59dc26a7711a8bcfbe)---updated-dependencies:- dependency-name: actions/setup-go  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Adding native OCI support proposal (#13516)Signed-off-by: Andrew Block <andy.block@gmail.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: space in 'Argo CD' (#14987)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: Add Support for AzureDevops Webhooks (#14969)* feat: Add Support for AzureDevops WebhooksSigned-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>* document azure devops webhook configurationSigned-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>---------Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: api server fails to call dex with istio (#14995)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): Update default and max count for maxCookieNumber (#14979)* Update default and max count for maxCookieNumberSigned-off-by: zvlb <vl.zemtsov@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: correct the swagger ui link to support --rootpath (#14845)Signed-off-by: Kevin Yue <yuezk001@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): upgrade nhooyr.io/websocket dependency (#15000)Upgrade from 1.8.6 to 1.8.7 due to high security issueWas solved in dependency with https://github.com/nhooyr/websocket/pull/291Signed-off-by: jmeridth <jmeridth@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: upgrade to go 1.21 (#14992)Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump goreleaser/goreleaser-action from 4.3.0 to 4.4.0 (#14996)Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 4.3.0 to 4.4.0.- [Release notes](https://github.com/goreleaser/goreleaser-action/releases)- [Commits](https://github.com/goreleaser/goreleaser-action/compare/336e29918d653399e599bfca99fadc1d7ffbc9f7...3fa32b8bb5620a2c1afe798654bbad59f9da4906)---updated-dependencies:- dependency-name: goreleaser/goreleaser-action  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: bump ubuntu base image (#15020) (#15021)Latest version of the ubuntu image addresses CVE-2023-38408.https://ubuntu.com/security/notices/USN-6242-1https://github.com/docker-library/repo-info/blob/master/repos/ubuntu/remote/22.04.mdresolves #15020Signed-off-by: Mason Cole <macole@beyondtrust.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: give context to errors (#10592) (#15022)* chore: give context to errorsSigned-off-by: Vipin M S <vipinachar2016@gmail.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/tls/tls.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/tls/tls.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/tls/tls.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Apply suggestions from code reviewSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Vipin M S <vipinachar2016@gmail.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: give context to errors (#15019)* chore: give context to error logs in reposerverSigned-off-by: Ashin Sabu <ashin.sabu@harness.io>* chore: give context to errors in applicationsetSigned-off-by: Ashin Sabu <ashin.sabu@harness.io>* chore: give context to errors(tweaks in error messages)Signed-off-by: Ashin Sabu <ashin.sabu@harness.io>* chore: give context to errors(fix unit test)Signed-off-by: Ashin Sabu <ashin.sabu@harness.io>---------Signed-off-by: Ashin Sabu <ashin.sabu@harness.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add Carrefour Group to USERS.md (#15039)Signed-off-by: Zadkiel Aharonian <zadkiel_aharonian@carrefour.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(health): spec.executor.instances is Optional, Support a flexible number of executors (#11877)Support a flexible number of executors. For example with a mounted ConfigMap inside the Spark-Operator.Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* [Bot] docs: Update Snyk reports (#15031)Signed-off-by: CI <ci@argoproj.com>Co-authored-by: CI <ci@argoproj.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(reposerver): loosen source not permitted helm errors (#14210)* fix: loosen source not permitted helm errorsWith #12255, we check if a source is first permitted before running`helm template`. This works a bit too well, since this may breakpreviously working manifests. If an `AppProject` has a set of`sourceRepos` which are more restrictive than `*`, and it also has Helmpublic dependencies (repos with credentials would not work with 2.7xdue to the fact they get filtered out before ending up on the reposerver). Whereas before this would work, this currently fails on`HEAD` but not in `2.7x`.What we instead do here is that we only run this check if the chartfailed to download - if it does then we run a check to see if the repois in the allowed repos list. If the repo is not in the allowed reposlist, we return the same error as in #12555, otherwise we bubble up theerror.Should fix #13833.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* fix: check for 401 unauthorized in errorThe regex check works fine for OCI artifacts, but the flow is slightlydifferent for standard Helm charts (specifically when running`helm repo add`). To get around that, we also check the error for`401 Unauthorized`.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* fix: loosen string checkSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>* Revert "chore: revert #12255 (#14858)"This reverts commit c8ae5bc3e79fa985632861f75669c07523f5ded6.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* wipSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>* wipSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>* chore: reword test to reduce confusionSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>---------Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appset): Fix helm valuesObject with ApplicationSet (#14912) (#14920)Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(cli): support apply out of sync flag only (#14624)* feat: support apply out of sync flag onlySigned-off-by: pashakostohrys <pavel@codefresh.io>* update engine versionSigned-off-by: pashakostohrys <pavel@codefresh.io>* update gitops engine versionSigned-off-by: pashakostohrys <pavel@codefresh.io>* add cli optionSigned-off-by: pashakostohrys <pavel@codefresh.io>* feat: verify apply out of sync flagSigned-off-by: pashakostohrys <pavel@codefresh.io>* redundant commentSigned-off-by: pashakostohrys <pavel@codefresh.io>* improve test logicSigned-off-by: pashakostohrys <pavel@codefresh.io>* change command description and do codegenSigned-off-by: pashakostohrys <pavel@codefresh.io>---------Signed-off-by: pashakostohrys <pavel@codefresh.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs(github): comment out notational pieces of PR template (#14888)- the DCO and FAQ sentences are not filled out during PRs and are purely notational  - comment them out with HTML comments, as is common practice    - example from argo-helm: https://github.com/argoproj/argo-helm/blob/962342fe2acef6022ac5c1a3eb352b336308b3eb/.github/pull_request_template.md?plain=1#L1      - copied this practice from other repos I maintain and from other repos before that- these comments are still visible to the PR author, just not visible when rendered, keeping the PR more conciseSigned-off-by: Anton Gilgur <agilgur5@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump golangci/golangci-lint-action from 3.6.0 to 3.7.0 (#15053)Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.6.0 to 3.7.0.- [Release notes](https://github.com/golangci/golangci-lint-action/releases)- [Commits](https://github.com/golangci/golangci-lint-action/compare/639cd343e1d3b897ff35927a75193d57cfcba299...3a919529898de77ec3da873e3063ca4b10e7f5cc)---updated-dependencies:- dependency-name: golangci/golangci-lint-action  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump actions/setup-node from 3.7.0 to 3.8.0 (#15054)Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.7.0 to 3.8.0.- [Release notes](https://github.com/actions/setup-node/releases)- [Commits](https://github.com/actions/setup-node/compare/e33196f7422957bea03ed53f6fbb155025ffc7b8...bea5baf987ba7aa777a8a0b4ace377a21c45c381)---updated-dependencies:- dependency-name: actions/setup-node  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update bank vaults link to point to the new org (#15069)Bank-Vaults recently migrated to a new organization. The old repository is archived.Signed-off-by: Anton Lindholm <LinAnt@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: improve error logs (#10592) (#15059)* chore: improve error logsSigned-off-by: AvhiMaz <avhimazumder5@outlook.com>* chore: Changes made according to the reviewerSigned-off-by: AvhiMaz <avhimazumder5@outlook.com>* chore: Chnages according to the reviewerI"Signed-off-by: AvhiMaz <avhimazumder5@outlook.com>* Update cmpserver/apiclient/plugin.pb.goSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: AvhiMaz <avhimazumder5@outlook.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update link to KubeCon China 2021 talk in README.md (#14887)Signed-off-by: Yuan (Terry) Tang <terrytangyuan@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: document permitOnlyProjectScopedClusters field (#15076)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: kubectl to synchronize argocd apps (#14881)We can use kubectl to synchronize argocd applications the same way we can usethe argocd cli or ui, however there's no documentation.This PR adds documentation for kubectl.Signed-off-by: Jordi Grant Esteve <jgrant.esteve@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: fix typo (#15083)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: add timeout for update cluster info (#14511)* chore: simplified parsing of startup parametersSigned-off-by: yyzxw <1020938856@qq.com>* feat: add timeout for update cluster infoSigned-off-by: yyzxw <1020938856@qq.com>---------Signed-off-by: yyzxw <1020938856@qq.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: requeue ApplicationSet if there are validation errors (#14429)Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: fix link for `argocd-repo-creds.yaml` sample (#15091)Signed-off-by: SHIMADA Kento <shimada.kento8974@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: wrap error objects to include context (#10592) (#15055)* chore: wrap error objects to include context (#10592)Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com>* chore: resolved common_test.go file as per reviewer's feedbackSigned-off-by: Pawank06 <pawan06kumar2003@gmail.com>* chore:changes in ulits.goSigned-off-by: Pawank06 <pawan06kumar2003@gmail.com>* chore: resolving utils_test.go fileSigned-off-by: Pawank06 <pawan06kumar2003@gmail.com>---------Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com>Signed-off-by: B Pawan Kumar <pawan06kumar2003@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(#12862): Update FlinkDeployment health check to support Flink v1.x (#15065)Signed-off-by: Dylan Slavin <dylan@sla.vin>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: add docs for various annotations and labels (#14020)* docs: add docs for various annotationsSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* more infoSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* more docsSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appset): bitbucket server scm provider EOF on empty repo (#14411)* fix bitbucket server scm provider EOF on empty repo default branch checkSigned-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>* add unit test for bitbucketServer empty repoSigned-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>* check for EOF explicitlySigned-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>---------Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: update confusing variable name (#15106)Signed-off-by: jmcshane <james.mcshane@superorbital.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs(progressive syncs): specify which ConfigMap to use (#15119)Signed-off-by: Gaël Jourdan-Weil <gjourdanweil@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(appset): added topic filter for Gitlab SCM (#14965)* added topic (tag) filter for Gitlab SCMSigned-off-by: Prune <prune@lecentre.net>* corrected few commentsSigned-off-by: Prune <prune@lecentre.net>* removed latest tag referencesSigned-off-by: Prune <prune@lecentre.net>---------Signed-off-by: Prune <prune@lecentre.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Add kustomization.yaml for server app RBAC (#15124)This change adds a `kustomization.yaml` file for the example RBACrole/rolebinding for argocd server applications.This makes it easier to include them as resources in another `kustomization.yaml`.Instead of including```yamlapiVersion: kustomize.config.k8s.io/v1beta1kind: Kustomizationresources:- https://raw.githubusercontent.com/argoproj/argo-cd/v2.8.0/examples/k8s-rbac/argocd-server-applications/argocd-server-rbac-clusterrole.yaml- https://raw.githubusercontent.com/argoproj/argo-cd/v2.8.0/examples/k8s-rbac/argocd-server-applications/argocd-server-rbac-clusterrolebinding.yaml```the user can now instead include```yamlapiVersion: kustomize.config.k8s.io/v1beta1kind: Kustomizationresources:- github.com/argoproj/argo-cd/examples/k8s-rbac/argocd-server-applications?ref=v2.8.0```This change was performed by running:```consolekustomize createkustomize edit add resource argocd-server-rbac-clusterrole.yamlkustomize edit add resource argocd-server-rbac-clusterrolebinding.yaml```Signed-off-by: Andreas Lindhé <andreas@lindhe.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: ✏️ fix typo on configmap name for private certs (#9596)Signed-off-by: Gaël Jourdan-Weil <gael.jourdan-weil@kelkoogroup.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* Merge pull request from GHSA-c8xw-vjgf-94hrSigned-off-by: pashakostohrys <pavel@codefresh.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): code lint (#15150)Signed-off-by: ebuildy <ebuildy@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: windows build (#15154)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: run refresh from UI in parallel (#15138)Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(cli): add support for components with non-default names (#10200) (#14605)* fix(cli): add support for components with non-default names (#10200)Co-Authored-By: maheshbaliga <mahesh.baliga@infracloud.io>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: maheshbaliga <mahesh.baliga@infracloud.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Updated docs about using a slash in ignoreDifferences (#15144)Signed-off-by: Christian Hernandez <christian@chernand.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: stop creating new otel interceptor to avoid memory leak (#15174)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add example jq path expression (#15130)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: document sourceNamespaces field (#15195)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appset): Matrix Generator Override not Working for Booleans (#14498) (#14573)* Fix AppSet matrix generator parameter overrideSigned-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com>* Add test case for parameter override fixSigned-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com>---------Signed-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: remove unnecessary version number (#15198)We have versioned docs now, no need for this.Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): switch podgroup notification to tooltip message (#14821)* improve pod grouping uxSigned-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>fix: update log view on container selectSigned-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>* fix(ui): improve pod grouping uxSigned-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>* fix(ui):update the pod grouping messages to tooltipSigned-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>* fix(ui):update the pod grouping messages to tooltipSigned-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>* fix: GroupNodes notificationSigned-off-by: AS <11219262+ashutosh16@users.noreply.github.com>* fix: GroupNodes notificationSigned-off-by: AS <11219262+ashutosh16@users.noreply.github.com>---------Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>Signed-off-by: AS <11219262+ashutosh16@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add upsider to USERS.md (#15228)Signed-off-by: Vlad Fratila <vlad.fratila@up-sider.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: clarify argocd-repo-server repo-cache-expiration HA use case (#15239)Signed-off-by: phanama <yudiandreanp@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: better logs for jq expression errors (#15226)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): Helm chart empty maintainers blow up Argo UI (#15225)Signed-off-by: Carlos Castro carlos.castro@jumo.worldSigned-off-by: Carlos Castro carlos.castro@jumo.worldSigned-off-by: Carlos Castro <carlos.castro@jumo.world>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add Kvist to USERS.md (#15240)Signed-off-by: Fredrik A. Madsen-Malmo <fredrik.malmo@icloud.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: improve doc on labels parameter on scmProvider generator (#15255)Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update ApplicationSet docs (#15269)Signed-off-by: David Muckle <dvdmuckle@dvdmuckle.xyz>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: support extra attributes for opentelemetry (#15071)Signed-off-by: penglongli <pelenli@tencent.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Add Twilio Segment to USERS.md (#15267)Thank you to the Argo community!Signed-off-by: Prasad Katti <prasad.katti@segment.com>Co-authored-by: jannfis <jann@mistrust.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: make WatchResourceTree use namespaced cache key (#15258)* fix: make WatchResourceTree use namespaced application cache keySigned-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com>* chore: add PGS to USERS.mdSigned-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com>---------Signed-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: remove duplicate function (#15123)Signed-off-by: yyzxw <1020938856@qq.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Cache control 404 asset requests (#15327)* backfill cache control header tests for ui assetsSigned-off-by: Scott Windsor <scott.windsor@flexe.com>* Set cache-control header non-cache for assets not foundSigned-off-by: Scott Windsor <scott.windsor@flexe.com>* fix golang-cilint warningSigned-off-by: Scott Windsor <scott.windsor@flexe.com>---------Signed-off-by: Scott Windsor <scott.windsor@flexe.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Fixes a markdown typo in USERS.md (#15362)This removes the whitespace between the link text and the link URL.Signed-off-by: Prasad Katti <prasad.katti@segment.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: upgrade notification engine (#15359)* Update notifications-engine dependenciesSigned-off-by: Mike Splain <mike.splain@gmail.com>* Update docsSigned-off-by: Mike Splain <mike.splain@gmail.com>---------Signed-off-by: Mike Splain <mike.splain@gmail.com>Co-authored-by: pasha-codefresh <pavel@codefresh.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: add Dott to users (#15370)Signed-off-by: Jake Burn <jake@ridedott.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(notifications-catalog): Add nil check for on-deployed trigger (#15363)Signed-off-by: Fs02 <surya.asriadie@gmail.com>Co-authored-by: pasha-codefresh <pavel@codefresh.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: auto respect rbac for discovery/sync (#14381)feat: auto respect rbac for discovery/sync (#14381)Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: Add ARGOCD_CLUSTER_CACHE_LIST_PAGE_BUFFER_SIZE environment variable (#15159)Signed-off-by: Brad West <brad.g.west@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appset): Revert applicationset-name labels (#15324)* fix(15282) Revert applicationset-name labelsSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* fix(15282) fix unit testSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>---------Signed-off-by: gmuselli <geoffrey.muselli@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/golang from 1.21.0 to 1.21.1 (#15391)Bumps library/golang from 1.21.0 to 1.21.1.---updated-dependencies:- dependency-name: library/golang  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/golang from 1.21.0 to 1.21.1 in /test/remote (#15387)Bumps library/golang from 1.21.0 to 1.21.1.---updated-dependencies:- dependency-name: library/golang  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/node from 20.4.0 to 20.6.0 in /test/container (#15366)Bumps library/node from 20.4.0 to 20.6.0.---updated-dependencies:- dependency-name: library/node  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* Merge pull request from GHSA-g687-f2gx-6wm8* feat: use untar with limiterSigned-off-by: pashakostohrys <pavel@codefresh.io>* feat: use untar with limiterSigned-off-by: pashakostohrys <pavel@codefresh.io>---------Signed-off-by: pashakostohrys <pavel@codefresh.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* Merge pull request from GHSA-fwr2-64vr-xv9m* fix: prevent seeing/editing 'kubectl.kubernetes.io/last-applied-configuration' cluster annotationSigned-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>* fix: failing unit testSigned-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>---------Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>Co-authored-by: iam-veeramalla <abhishek.veeramalla@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/node from 20.5.0 to 20.6.0 in /ui-test (#15364)Bumps library/node from 20.5.0 to 20.6.0.---updated-dependencies:- dependency-name: library/node  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: handle annotations for resources with ':' in the name (#15101) (#15380)* fix: handle annotations for resources with ':' in the nameSigned-off-by: Oreon Lothamer <oreon.lothamer@softrams.com>* fix: switch to using splitN for handling annotation splittingSigned-off-by: Oreon Lothamer <oreon.lothamer@softrams.com>* fix: check len(parts) !=3Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com>* Retrigger CI pipelineSigned-off-by: Oreon Lothamer <oreon.lothamer@softrams.com>---------Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Improve RBAC documentation (#15430)* Improve staging-db project nameThis change renames the project to distinguish it from the role.Signed-off-by: Andreas Lindhé <andreas@lindhe.io>* Rename db-staging role to singular formRole names should be singular ("User x has the role admin" as opposed to"User x has the role admins").Signed-off-by: Andreas Lindhé <andreas@lindhe.io>* Remove trailing newlinesSigned-off-by: Andreas Lindhé <andreas@lindhe.io>* Consistently mark `AppProject` as codeSigned-off-by: Andreas Lindhé <andreas@lindhe.io>* Replace ```shell with ```console in suitable placesSigned-off-by: Andreas Lindhé <andreas@lindhe.io>* Use consistent style for unordered listhttps://github.com/DavidAnson/markdownlint/blob/main/doc/md004.mdSigned-off-by: Andreas Lindhé <andreas@lindhe.io>* Use consistent emphasis stylehttps://github.com/DavidAnson/markdownlint/blob/main/doc/md049.mdSigned-off-by: Andreas Lindhé <andreas@lindhe.io>* Fix incorrect description of the staging-db exampleSigned-off-by: Andreas Lindhé <andreas@lindhe.io>---------Signed-off-by: Andreas Lindhé <andreas@lindhe.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appsets): gotemplate can cause panic from nil dereference (#15377) (#15378)* fix(appsets): gotemplate can cause panic from nil deferenceSigned-off-by: rumstead <37445536+rumstead@users.noreply.github.com>* fix(appsets): gotemplate can cause panic from nil dereferenceSigned-off-by: rumstead <37445536+rumstead@users.noreply.github.com>---------Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Fix flaky cluster test (#15433)Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* Fix requeue after for Matrix/Merge with SCM or ClusterDecision generators (#15407)Signed-off-by: Cezar Sa Espinola <cezarsa@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: added shorthand flags for follow and conatainre in app logs (#15400)* feat: added shorthand flags for follow and conatainre in app logsSigned-off-by: ashu <ashupednekar49@gmail.com>* doc: re-generated cli docsSigned-off-by: ashu <ashupednekar49@gmail.com>---------Signed-off-by: ashu <ashupednekar49@gmail.com>Co-authored-by: jannfis <jann@mistrust.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* [Bot] docs: Update Snyk reports (#15437)Signed-off-by: CI <ci@argoproj.com>Co-authored-by: CI <ci@argoproj.com>Co-authored-by: jannfis <jann@mistrust.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Better enforcement of application namespace restrictions (#15431)* fix: Better enforce application namespace restrictionsSigned-off-by: jannfis <jann@mistrust.net>* Only call ValidateDestination when allowedSigned-off-by: jannfis <jann@mistrust.net>---------Signed-off-by: jannfis <jann@mistrust.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: fix bullets (#15446)Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: failed to add cluster when the cluster server address is ipv6 (#8204) (#15350)* fix: failed to add cluster when the cluster server address is ipv6 (#8204)Signed-off-by: huyinhou <huyinhou@bytedance.com>* fix: failed to add cluster when the cluster server address is ipv6 (#8204)Signed-off-by: huyinhou <huyinhou@bytedance.com>* remove …

lyda pushed a commit to lyda/argo-cd that referenced this pull request

Mar 28, 2024

feat: Allow 'both' option for uibannerposition (argoproj#14623)

0625be9

* fix(ui): Drop ready from Completed container status (#14434) (#14629)Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/go-git/go-git/v5 from 5.7.0 to 5.8.0 (#14641)Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.7.0 to 5.8.0.- [Release notes](https://github.com/go-git/go-git/releases)- [Commits](https://github.com/go-git/go-git/compare/v5.7.0...v5.8.0)---updated-dependencies:- dependency-name: github.com/go-git/go-git/v5  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: webhook handler fails to refresh when alternate application namespaces are configured (#13976)* fix: Add failing test for webhooks in all namespacesThis adds a failing test that properly exercises this functionality overall namespaces. The issue with the code that is under test is that itdoes not pass the namespace correctly to the patch of the application,resulting in the patch not taking place in the correct namespaceSigned-off-by: Nikolas Skoufis <nskoufis@seek.com.au>* fix: queue webhook refresh for apps in all namespacesThis passes the test in the previous commit, to ensure that webhookscorrectly refresh applications across all namespaces.Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au>* fix: Use existing NamespacedName typeUse the existing type instead of a custom typeSigned-off-by: Nikolas Skoufis <nskoufis@seek.com.au>---------Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: ApplicationSet Controller crashes when tag is not closed; panic: Cannot find end tag="}}"(#14227) (#14651)* ApplicationSet bug fixSigned-off-by: schakrad <58915923+schakrad@users.noreply.github.com>* Update applicationset/utils/utils_test.goSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* oopsSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): The default pod group filter should be removed if fewer than 15 pods (#14590)Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(deep-links): sprig support (#14660)Signed-off-by: daftping <21245083+daftping@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Print in-cluster svr addr disabled warning when server starts (#14553)* chore: Print in-cluster svr addr disabled warning when server startsSigned-off-by: Yuan Tang <terrytangyuan@gmail.com>* fix: mockSigned-off-by: Yuan Tang <terrytangyuan@gmail.com>* no interface changeSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Upgrade semver to avoid cve (#14710)Signed-off-by: Yi Cai <yicai@redhat.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: adding a autosync_enabled field  to the argocd_app_info gauge (#14424)Signed-off-by: Gerardo Corea <gerardocorea92@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(controller): log failed attempts to update operation state (#14273)* fix(controller): log failed attempts to update operation stateSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* new package nameSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* Update controller/appcontroller_test.goSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(server): handle PATCH in http/s server (#2677) (#14530)Signed-off-by: mmerrill3 <jjpaacks@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: manifest generation error with null annotations (#14336) (#14680)* fix: manifest generation error with null annotationsSigned-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>* fix testSigned-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>* fix unit testsSigned-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>---------Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* Clean up repeated package import (#13889)Signed-off-by: Zechun Chen <zechun.chen@daocloud.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(sso): Set redirectURI for gitea, google, oauth Dex connectors (#11237)Signed-off-by: ylxianzhe <ylxianzhe@outlook.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(appset): Restrict scm provider urls (#14286)* 9353: Restrict scm provider urlsSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Enforce restrictionSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Fix after reviewSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Remove commentSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Fix units testsSigned-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com>* 9353: Code review, update commentSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Code review, update comment 2Signed-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Remove doc issuesSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Fix e2eSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Fix e2e goTemplateSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Fix e2e pullRequestGeneratorSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>---------Signed-off-by: gmuselli <geoffrey.muselli@gmail.com>Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/go-git/go-git/v5 from 5.8.0 to 5.8.1 (#14744)Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.8.0 to 5.8.1.- [Release notes](https://github.com/go-git/go-git/releases)- [Commits](https://github.com/go-git/go-git/compare/v5.8.0...v5.8.1)---updated-dependencies:- dependency-name: github.com/go-git/go-git/v5  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/aws/aws-sdk-go from 1.44.305 to 1.44.309 (#14746)Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.305 to 1.44.309.- [Release notes](https://github.com/aws/aws-sdk-go/releases)- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.305...v1.44.309)---updated-dependencies:- dependency-name: github.com/aws/aws-sdk-go  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): display valuesobject if set (#14257)* fix: display valuesobject if setWith #11538 we now have the ability to set helm values as an objectinstead of a string, but we also need to be able to correctly displayit in the UI if it is set.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* fix: set valuesobject on saveIf `valuesObject` is present, set it to the value of`input.spec.source.helm.values` on save, as an unmarshaled json string.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* fix: set `helm.values` to empty string on saveIf `valuesObject` exists, set `input.spec.source.helm.values` to anempty string once `valuesObject` has been unmarshalled from thevalues input. This is to prevent unnecessary duplication of the values.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* chore: eslintSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>* chore: eslintSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>* fix: deep clone appThis is so that we can conditionally set `source.helm.values` withoutinadvertently affecting other parts of the app. Only when the editbutton is pressed do we toggle `source.helm.values`.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* chore: eslintSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>---------Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: OCI dependency url can't contain part of repository (#14699)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Add missing value (#14538)Signed-off-by: felix <felix@psy-coding.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* [Bot] docs: Update Snyk reports (#14781)Signed-off-by: CI <ci@argoproj.com>Co-authored-by: CI <ci@argoproj.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/aws/aws-sdk-go from 1.44.309 to 1.44.312 (#14782)Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.309 to 1.44.312.- [Release notes](https://github.com/aws/aws-sdk-go/releases)- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.309...v1.44.312)---updated-dependencies:- dependency-name: github.com/aws/aws-sdk-go  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/xanzy/go-gitlab from 0.88.0 to 0.89.0 (#14784)Bumps [github.com/xanzy/go-gitlab](https://github.com/xanzy/go-gitlab) from 0.88.0 to 0.89.0.- [Changelog](https://github.com/xanzy/go-gitlab/blob/master/releases_test.go)- [Commits](https://github.com/xanzy/go-gitlab/compare/v0.88.0...v0.89.0)---updated-dependencies:- dependency-name: github.com/xanzy/go-gitlab  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/casbin/casbin/v2 from 2.72.1 to 2.73.0 (#14783)Bumps [github.com/casbin/casbin/v2](https://github.com/casbin/casbin) from 2.72.1 to 2.73.0.- [Release notes](https://github.com/casbin/casbin/releases)- [Changelog](https://github.com/casbin/casbin/blob/master/.releaserc.json)- [Commits](https://github.com/casbin/casbin/compare/v2.72.1...v2.73.0)---updated-dependencies:- dependency-name: github.com/casbin/casbin/v2  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add Autodesk to USERS.md (#14778)Signed-off-by: Dylan Page <dylan.page@autodesk.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Add query-scoped cluster URL in Cluster Secret E2E tests (#14446)* Add query-scoped cluster URL in Cluster Secret E2E testsSigned-off-by: Jonathan West <jonwest@redhat.com>* Respond to review commentsSigned-off-by: Jonathan West <jonwest@redhat.com>---------Signed-off-by: Jonathan West <jonwest@redhat.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Clarify that security policy covers last 3 versions (#14786)* docs: Clarify that security policy covers last 3 versionsSigned-off-by: Kostis Kapelonis <kostis@codefresh.io>* Update SECURITY.mdSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Kostis Kapelonis <kostis@codefresh.io>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(controller): cache deadlock on delete and re-add cluster (#14780)Signed-off-by: Nathan Romriell <nateromriell@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: make `helm template` errors less verbose (#14772)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(deep-links): alias `application` as `apps` for consistency with notifications engine (#14761)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): no hyphen for "create job" action + nice icon (#14776) (#14777)* chore(actions): space instead of hyphen in action name (#14776)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* new field for backwards-compatibilitySigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* align icons for maximum synergySigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* delete unused functionSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* revert unnecessary changesSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* Update docs/operator-manual/upgrading/2.7-2.8.mdSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Correct broken `forever` option in pod logs viewer. Fixes #14762 (#14763)Signed-off-by: Alex Collins <alex_collins@intuit.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update application.yaml (#14742)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: add ignoreDifferences name and namespace fields (#14741)* Update application.yamlSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* Update docs/operator-manual/application.yamlSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/node from 20.4.0 to 20.5.0 (#14664)Bumps library/node from 20.4.0 to 20.5.0.---updated-dependencies:- dependency-name: library/node  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/node from 20.4.0 to 20.5.0 in /ui-test (#14662)Bumps library/node from 20.4.0 to 20.5.0.---updated-dependencies:- dependency-name: library/node  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update Controlling-Resource-Modification.md (#14751)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(notifications-catalog): Add nil check for notifications_catalog triggers (#14795)* Add nil check for notifications_catalog triggersSigned-off-by: Trung <trung.hoang@pricehubble.com>* Use correct nil checkSigned-off-by: Trung <trung.hoang@pricehubble.com>* Add missing catalog generation to makefileSigned-off-by: Trung <trung.hoang@pricehubble.com>* Revert changes to update-manifests.shSigned-off-by: Trung <trung.hoang@pricehubble.com>---------Signed-off-by: Trung <trung.hoang@pricehubble.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: ManagedResources API should not return diff for hooks (#14816)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Change Generator docs for List Generator to note any key/value pairs can be used (#14825)This is no longer limited to cluster/url value pairs.Signed-off-by: JesseBot <jessebot@linux.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: improve app destination docstrings (#14836)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: Adding kubelogin capability to argocd-k8s-auth (#9460) (#10700)Signed-off-by: mmerrill3 <jjpaacks@gmail.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Add header support for proxy extension requests  (#14800)* chore: add server URL in the header of proxy extensionsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>* feat: add header support for proxy extension requestsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>* Address review commentsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>* address review commentsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>* Address review commentsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>* Address review commentsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>---------Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: use consistent password in plugin generator examples (#14837)* docs: use consistent password in plugin generator examplesThe example secret with the token is using `strong-password`, but the later examples use `string-password`.This updates all of the examples to use `strong-password`.Signed-off-by: Nicholas Morey <nicholas@morey.tech>* docs: update another-secret example to include `strong-password`Consistent with above example of client token in argocd-secretSigned-off-by: Nicholas Morey <nicholas@morey.tech>---------Signed-off-by: Nicholas Morey <nicholas@morey.tech>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: give context to error logs #10592 (#14851)* chore: give context to error logsSigned-off-by: ashinsabu3 <ashin.sabu@harness.io>* Update reposerver/repository/repository.goSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: ashinsabu3 <ashin.sabu@harness.io>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add more tests in proxy extension headers (#14842)Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: revert #12255 (#14858)This reverts commit c651bd8de551c85fc897c997c1976d6777259921.Due to the imminent release of 2.8, this needs to be rolled back sincethe proposed fix in #14210 cannot make it in time.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Repo URL link for unsupported sources links to https://<argocd>/null/path/to/chart (#14861)* Fix #14860Fix #14860Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com>* Update USERS.mdSigned-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com>---------Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: correct discrepancies in generated swagger file (#14813)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: wrap ComparisonError messages (#14886)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): Fixes health icon positioning (#14708) (#14852)* fix: Fixes health icon positioning #14708Signed-off-by: ashinsabu3 <ashin.sabu@harness.io>* fix: Fixes alignment of app health application status panel #14708Signed-off-by: ashinsabu3 <ashin.sabu@harness.io>* fix: Added line height to App Status to fix its  positioning #14708Signed-off-by: ashinsabu3 <ashin.sabu@harness.io>---------Signed-off-by: ashinsabu3 <ashin.sabu@harness.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: fix non-deterministic test (#14905)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Change underscore (_) back to plus (+) to get valid SemVer when when reading tags from OCI registry (#14537)* fix: Change underscore (_) back to plus (+) to get valid SemVer when reading tags from OCI registrySigned-off-by: xashr <saschasynaos@gmail.com>* Add test coverage for SemVer tags in TestGetTagsFromUrlSigned-off-by: xashr <saschasynaos@gmail.com>---------Signed-off-by: xashr <saschasynaos@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appset): typo in ARGOCD_APPLICATIONSET_CONTROLLER_ALLOWED_SCM_PROVIDERS (#14902) (#14913)Signed-off-by: gmuselli <geoffrey.muselli@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: provide short revision in ARGOCD_APP_REVISION_SHORT env variable (#14926)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/aws/aws-sdk-go from 1.44.312 to 1.44.317 (#14925)Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.312 to 1.44.317.- [Release notes](https://github.com/aws/aws-sdk-go/releases)- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.312...v1.44.317)---updated-dependencies:- dependency-name: github.com/aws/aws-sdk-go  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump golang.org/x/oauth2 from 0.10.0 to 0.11.0 (#14922)Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.10.0 to 0.11.0.- [Commits](https://github.com/golang/oauth2/compare/v0.10.0...v0.11.0)---updated-dependencies:- dependency-name: golang.org/x/oauth2  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update Generators-Git.md (#14921)Remove a misleading symbol from the pattern for the path.Match function. The pipe symbol doesn't have any special meaning.Signed-off-by: German Lashevich <german.lashevich@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update helm.md - add missing syntax highlighting for YAML and Dockerfile blocks (#14911)Signed-off-by: JesseBot <jessebot@linux.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): COPY JSON for ArgoCD version should include trailing newline (#5117) (#14917)Signed-off-by: Vipin M S <vipinachar2016@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* [Bot] docs: Update Snyk reports (#14919)Signed-off-by: CI <ci@argoproj.com>Co-authored-by: CI <ci@argoproj.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: give context to error logs (#10592) (#14915)* chore: wrap error objects to include contextSigned-off-by: Vipin M S <vipinachar2016@gmail.com>* chore: wrap error objects to include contextSigned-off-by: Vipin M S <vipinachar2016@gmail.com>* chore: wrap error objects to include contextSigned-off-by: Vipin M S <vipinachar2016@gmail.com>* chore: wrap error objects to include contextSigned-off-by: Vipin M S <vipinachar2016@gmail.com>* Update applicationset/controllers/applicationset_controller.goSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Vipin M S <vipinachar2016@gmail.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(appset): Add SCM Provider option for Gitlab generator to filter shared projects from subgroups projects (#14831)* added option to disable gitlab to fetch shared project from a subgroupSigned-off-by: Prune <prune@lecentre.net>* Correct gitlab SCM provider mock testSigned-off-by: Prune <prune@lecentre.net>* updated test to validate shared-groupsSigned-off-by: Prune <prune@lecentre.net>* reworked shared project testsSigned-off-by: Prune <prune@lecentre.net>* added subgroups only testSigned-off-by: Prune <prune@lecentre.net>---------Signed-off-by: Prune <prune@lecentre.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(cmp): send sigterm to cmp commands before sigkill to allow for potential cleanup (#9180) (#14955)* fix: send sigterm to cmp commands before sigkill to allow for potential cleanupSigned-off-by: Ashin Sabu <ashin.sabu@harness.io>* fix: unit test for runCommand in cmpserver to test cleanup modifiedSigned-off-by: Ashin Sabu <ashin.sabu@harness.io>* fix: change unit test for plugin/runCommand to avoid bad trap along with lint fixSigned-off-by: Ashin Sabu <ashin.sabu@harness.io>---------Signed-off-by: Ashin Sabu <ashin.sabu@harness.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Feature bounty proposal (Experimental) (#14234)* Create bounty proposalSigned-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>---------Signed-off-by: Dan Garfield <dan@codefresh.io>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(actions): check if CronWorkflow has labels in create-workflow action (#14962) (#14974)Signed-off-by: Mickaël Canévet <mickael.canevet@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add Jellysmack in USERS.md (#14975)Signed-off-by: Mickaël Canévet <mickael.canevet@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump actions/setup-go from 4.0.1 to 4.1.0 (#14970)Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4.0.1 to 4.1.0.- [Release notes](https://github.com/actions/setup-go/releases)- [Commits](https://github.com/actions/setup-go/compare/fac708d6674e30b6ba41289acaab6d4b75aa0753...93397bea11091df50f3d7e59dc26a7711a8bcfbe)---updated-dependencies:- dependency-name: actions/setup-go  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Adding native OCI support proposal (#13516)Signed-off-by: Andrew Block <andy.block@gmail.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: space in 'Argo CD' (#14987)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: Add Support for AzureDevops Webhooks (#14969)* feat: Add Support for AzureDevops WebhooksSigned-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>* document azure devops webhook configurationSigned-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>---------Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: api server fails to call dex with istio (#14995)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): Update default and max count for maxCookieNumber (#14979)* Update default and max count for maxCookieNumberSigned-off-by: zvlb <vl.zemtsov@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: correct the swagger ui link to support --rootpath (#14845)Signed-off-by: Kevin Yue <yuezk001@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): upgrade nhooyr.io/websocket dependency (#15000)Upgrade from 1.8.6 to 1.8.7 due to high security issueWas solved in dependency with https://github.com/nhooyr/websocket/pull/291Signed-off-by: jmeridth <jmeridth@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: upgrade to go 1.21 (#14992)Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump goreleaser/goreleaser-action from 4.3.0 to 4.4.0 (#14996)Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 4.3.0 to 4.4.0.- [Release notes](https://github.com/goreleaser/goreleaser-action/releases)- [Commits](https://github.com/goreleaser/goreleaser-action/compare/336e29918d653399e599bfca99fadc1d7ffbc9f7...3fa32b8bb5620a2c1afe798654bbad59f9da4906)---updated-dependencies:- dependency-name: goreleaser/goreleaser-action  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: bump ubuntu base image (#15020) (#15021)Latest version of the ubuntu image addresses CVE-2023-38408.https://ubuntu.com/security/notices/USN-6242-1https://github.com/docker-library/repo-info/blob/master/repos/ubuntu/remote/22.04.mdresolves #15020Signed-off-by: Mason Cole <macole@beyondtrust.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: give context to errors (#10592) (#15022)* chore: give context to errorsSigned-off-by: Vipin M S <vipinachar2016@gmail.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/tls/tls.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/tls/tls.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/tls/tls.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Apply suggestions from code reviewSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Vipin M S <vipinachar2016@gmail.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: give context to errors (#15019)* chore: give context to error logs in reposerverSigned-off-by: Ashin Sabu <ashin.sabu@harness.io>* chore: give context to errors in applicationsetSigned-off-by: Ashin Sabu <ashin.sabu@harness.io>* chore: give context to errors(tweaks in error messages)Signed-off-by: Ashin Sabu <ashin.sabu@harness.io>* chore: give context to errors(fix unit test)Signed-off-by: Ashin Sabu <ashin.sabu@harness.io>---------Signed-off-by: Ashin Sabu <ashin.sabu@harness.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add Carrefour Group to USERS.md (#15039)Signed-off-by: Zadkiel Aharonian <zadkiel_aharonian@carrefour.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(health): spec.executor.instances is Optional, Support a flexible number of executors (#11877)Support a flexible number of executors. For example with a mounted ConfigMap inside the Spark-Operator.Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* [Bot] docs: Update Snyk reports (#15031)Signed-off-by: CI <ci@argoproj.com>Co-authored-by: CI <ci@argoproj.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(reposerver): loosen source not permitted helm errors (#14210)* fix: loosen source not permitted helm errorsWith #12255, we check if a source is first permitted before running`helm template`. This works a bit too well, since this may breakpreviously working manifests. If an `AppProject` has a set of`sourceRepos` which are more restrictive than `*`, and it also has Helmpublic dependencies (repos with credentials would not work with 2.7xdue to the fact they get filtered out before ending up on the reposerver). Whereas before this would work, this currently fails on`HEAD` but not in `2.7x`.What we instead do here is that we only run this check if the chartfailed to download - if it does then we run a check to see if the repois in the allowed repos list. If the repo is not in the allowed reposlist, we return the same error as in #12555, otherwise we bubble up theerror.Should fix #13833.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* fix: check for 401 unauthorized in errorThe regex check works fine for OCI artifacts, but the flow is slightlydifferent for standard Helm charts (specifically when running`helm repo add`). To get around that, we also check the error for`401 Unauthorized`.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* fix: loosen string checkSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>* Revert "chore: revert #12255 (#14858)"This reverts commit c8ae5bc3e79fa985632861f75669c07523f5ded6.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* wipSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>* wipSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>* chore: reword test to reduce confusionSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>---------Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appset): Fix helm valuesObject with ApplicationSet (#14912) (#14920)Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(cli): support apply out of sync flag only (#14624)* feat: support apply out of sync flag onlySigned-off-by: pashakostohrys <pavel@codefresh.io>* update engine versionSigned-off-by: pashakostohrys <pavel@codefresh.io>* update gitops engine versionSigned-off-by: pashakostohrys <pavel@codefresh.io>* add cli optionSigned-off-by: pashakostohrys <pavel@codefresh.io>* feat: verify apply out of sync flagSigned-off-by: pashakostohrys <pavel@codefresh.io>* redundant commentSigned-off-by: pashakostohrys <pavel@codefresh.io>* improve test logicSigned-off-by: pashakostohrys <pavel@codefresh.io>* change command description and do codegenSigned-off-by: pashakostohrys <pavel@codefresh.io>---------Signed-off-by: pashakostohrys <pavel@codefresh.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs(github): comment out notational pieces of PR template (#14888)- the DCO and FAQ sentences are not filled out during PRs and are purely notational  - comment them out with HTML comments, as is common practice    - example from argo-helm: https://github.com/argoproj/argo-helm/blob/962342fe2acef6022ac5c1a3eb352b336308b3eb/.github/pull_request_template.md?plain=1#L1      - copied this practice from other repos I maintain and from other repos before that- these comments are still visible to the PR author, just not visible when rendered, keeping the PR more conciseSigned-off-by: Anton Gilgur <agilgur5@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump golangci/golangci-lint-action from 3.6.0 to 3.7.0 (#15053)Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.6.0 to 3.7.0.- [Release notes](https://github.com/golangci/golangci-lint-action/releases)- [Commits](https://github.com/golangci/golangci-lint-action/compare/639cd343e1d3b897ff35927a75193d57cfcba299...3a919529898de77ec3da873e3063ca4b10e7f5cc)---updated-dependencies:- dependency-name: golangci/golangci-lint-action  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump actions/setup-node from 3.7.0 to 3.8.0 (#15054)Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.7.0 to 3.8.0.- [Release notes](https://github.com/actions/setup-node/releases)- [Commits](https://github.com/actions/setup-node/compare/e33196f7422957bea03ed53f6fbb155025ffc7b8...bea5baf987ba7aa777a8a0b4ace377a21c45c381)---updated-dependencies:- dependency-name: actions/setup-node  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update bank vaults link to point to the new org (#15069)Bank-Vaults recently migrated to a new organization. The old repository is archived.Signed-off-by: Anton Lindholm <LinAnt@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: improve error logs (#10592) (#15059)* chore: improve error logsSigned-off-by: AvhiMaz <avhimazumder5@outlook.com>* chore: Changes made according to the reviewerSigned-off-by: AvhiMaz <avhimazumder5@outlook.com>* chore: Chnages according to the reviewerI"Signed-off-by: AvhiMaz <avhimazumder5@outlook.com>* Update cmpserver/apiclient/plugin.pb.goSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: AvhiMaz <avhimazumder5@outlook.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update link to KubeCon China 2021 talk in README.md (#14887)Signed-off-by: Yuan (Terry) Tang <terrytangyuan@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: document permitOnlyProjectScopedClusters field (#15076)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: kubectl to synchronize argocd apps (#14881)We can use kubectl to synchronize argocd applications the same way we can usethe argocd cli or ui, however there's no documentation.This PR adds documentation for kubectl.Signed-off-by: Jordi Grant Esteve <jgrant.esteve@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: fix typo (#15083)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: add timeout for update cluster info (#14511)* chore: simplified parsing of startup parametersSigned-off-by: yyzxw <1020938856@qq.com>* feat: add timeout for update cluster infoSigned-off-by: yyzxw <1020938856@qq.com>---------Signed-off-by: yyzxw <1020938856@qq.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: requeue ApplicationSet if there are validation errors (#14429)Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: fix link for `argocd-repo-creds.yaml` sample (#15091)Signed-off-by: SHIMADA Kento <shimada.kento8974@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: wrap error objects to include context (#10592) (#15055)* chore: wrap error objects to include context (#10592)Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com>* chore: resolved common_test.go file as per reviewer's feedbackSigned-off-by: Pawank06 <pawan06kumar2003@gmail.com>* chore:changes in ulits.goSigned-off-by: Pawank06 <pawan06kumar2003@gmail.com>* chore: resolving utils_test.go fileSigned-off-by: Pawank06 <pawan06kumar2003@gmail.com>---------Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com>Signed-off-by: B Pawan Kumar <pawan06kumar2003@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(#12862): Update FlinkDeployment health check to support Flink v1.x (#15065)Signed-off-by: Dylan Slavin <dylan@sla.vin>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: add docs for various annotations and labels (#14020)* docs: add docs for various annotationsSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* more infoSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* more docsSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appset): bitbucket server scm provider EOF on empty repo (#14411)* fix bitbucket server scm provider EOF on empty repo default branch checkSigned-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>* add unit test for bitbucketServer empty repoSigned-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>* check for EOF explicitlySigned-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>---------Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: update confusing variable name (#15106)Signed-off-by: jmcshane <james.mcshane@superorbital.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs(progressive syncs): specify which ConfigMap to use (#15119)Signed-off-by: Gaël Jourdan-Weil <gjourdanweil@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(appset): added topic filter for Gitlab SCM (#14965)* added topic (tag) filter for Gitlab SCMSigned-off-by: Prune <prune@lecentre.net>* corrected few commentsSigned-off-by: Prune <prune@lecentre.net>* removed latest tag referencesSigned-off-by: Prune <prune@lecentre.net>---------Signed-off-by: Prune <prune@lecentre.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Add kustomization.yaml for server app RBAC (#15124)This change adds a `kustomization.yaml` file for the example RBACrole/rolebinding for argocd server applications.This makes it easier to include them as resources in another `kustomization.yaml`.Instead of including```yamlapiVersion: kustomize.config.k8s.io/v1beta1kind: Kustomizationresources:- https://raw.githubusercontent.com/argoproj/argo-cd/v2.8.0/examples/k8s-rbac/argocd-server-applications/argocd-server-rbac-clusterrole.yaml- https://raw.githubusercontent.com/argoproj/argo-cd/v2.8.0/examples/k8s-rbac/argocd-server-applications/argocd-server-rbac-clusterrolebinding.yaml```the user can now instead include```yamlapiVersion: kustomize.config.k8s.io/v1beta1kind: Kustomizationresources:- github.com/argoproj/argo-cd/examples/k8s-rbac/argocd-server-applications?ref=v2.8.0```This change was performed by running:```consolekustomize createkustomize edit add resource argocd-server-rbac-clusterrole.yamlkustomize edit add resource argocd-server-rbac-clusterrolebinding.yaml```Signed-off-by: Andreas Lindhé <andreas@lindhe.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: ✏️ fix typo on configmap name for private certs (#9596)Signed-off-by: Gaël Jourdan-Weil <gael.jourdan-weil@kelkoogroup.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* Merge pull request from GHSA-c8xw-vjgf-94hrSigned-off-by: pashakostohrys <pavel@codefresh.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): code lint (#15150)Signed-off-by: ebuildy <ebuildy@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: windows build (#15154)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: run refresh from UI in parallel (#15138)Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(cli): add support for components with non-default names (#10200) (#14605)* fix(cli): add support for components with non-default names (#10200)Co-Authored-By: maheshbaliga <mahesh.baliga@infracloud.io>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: maheshbaliga <mahesh.baliga@infracloud.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Updated docs about using a slash in ignoreDifferences (#15144)Signed-off-by: Christian Hernandez <christian@chernand.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: stop creating new otel interceptor to avoid memory leak (#15174)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add example jq path expression (#15130)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: document sourceNamespaces field (#15195)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appset): Matrix Generator Override not Working for Booleans (#14498) (#14573)* Fix AppSet matrix generator parameter overrideSigned-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com>* Add test case for parameter override fixSigned-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com>---------Signed-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: remove unnecessary version number (#15198)We have versioned docs now, no need for this.Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): switch podgroup notification to tooltip message (#14821)* improve pod grouping uxSigned-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>fix: update log view on container selectSigned-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>* fix(ui): improve pod grouping uxSigned-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>* fix(ui):update the pod grouping messages to tooltipSigned-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>* fix(ui):update the pod grouping messages to tooltipSigned-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>* fix: GroupNodes notificationSigned-off-by: AS <11219262+ashutosh16@users.noreply.github.com>* fix: GroupNodes notificationSigned-off-by: AS <11219262+ashutosh16@users.noreply.github.com>---------Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>Signed-off-by: AS <11219262+ashutosh16@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add upsider to USERS.md (#15228)Signed-off-by: Vlad Fratila <vlad.fratila@up-sider.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: clarify argocd-repo-server repo-cache-expiration HA use case (#15239)Signed-off-by: phanama <yudiandreanp@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: better logs for jq expression errors (#15226)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): Helm chart empty maintainers blow up Argo UI (#15225)Signed-off-by: Carlos Castro carlos.castro@jumo.worldSigned-off-by: Carlos Castro carlos.castro@jumo.worldSigned-off-by: Carlos Castro <carlos.castro@jumo.world>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add Kvist to USERS.md (#15240)Signed-off-by: Fredrik A. Madsen-Malmo <fredrik.malmo@icloud.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: improve doc on labels parameter on scmProvider generator (#15255)Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update ApplicationSet docs (#15269)Signed-off-by: David Muckle <dvdmuckle@dvdmuckle.xyz>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: support extra attributes for opentelemetry (#15071)Signed-off-by: penglongli <pelenli@tencent.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Add Twilio Segment to USERS.md (#15267)Thank you to the Argo community!Signed-off-by: Prasad Katti <prasad.katti@segment.com>Co-authored-by: jannfis <jann@mistrust.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: make WatchResourceTree use namespaced cache key (#15258)* fix: make WatchResourceTree use namespaced application cache keySigned-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com>* chore: add PGS to USERS.mdSigned-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com>---------Signed-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: remove duplicate function (#15123)Signed-off-by: yyzxw <1020938856@qq.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Cache control 404 asset requests (#15327)* backfill cache control header tests for ui assetsSigned-off-by: Scott Windsor <scott.windsor@flexe.com>* Set cache-control header non-cache for assets not foundSigned-off-by: Scott Windsor <scott.windsor@flexe.com>* fix golang-cilint warningSigned-off-by: Scott Windsor <scott.windsor@flexe.com>---------Signed-off-by: Scott Windsor <scott.windsor@flexe.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Fixes a markdown typo in USERS.md (#15362)This removes the whitespace between the link text and the link URL.Signed-off-by: Prasad Katti <prasad.katti@segment.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: upgrade notification engine (#15359)* Update notifications-engine dependenciesSigned-off-by: Mike Splain <mike.splain@gmail.com>* Update docsSigned-off-by: Mike Splain <mike.splain@gmail.com>---------Signed-off-by: Mike Splain <mike.splain@gmail.com>Co-authored-by: pasha-codefresh <pavel@codefresh.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: add Dott to users (#15370)Signed-off-by: Jake Burn <jake@ridedott.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(notifications-catalog): Add nil check for on-deployed trigger (#15363)Signed-off-by: Fs02 <surya.asriadie@gmail.com>Co-authored-by: pasha-codefresh <pavel@codefresh.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: auto respect rbac for discovery/sync (#14381)feat: auto respect rbac for discovery/sync (#14381)Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: Add ARGOCD_CLUSTER_CACHE_LIST_PAGE_BUFFER_SIZE environment variable (#15159)Signed-off-by: Brad West <brad.g.west@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appset): Revert applicationset-name labels (#15324)* fix(15282) Revert applicationset-name labelsSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* fix(15282) fix unit testSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>---------Signed-off-by: gmuselli <geoffrey.muselli@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/golang from 1.21.0 to 1.21.1 (#15391)Bumps library/golang from 1.21.0 to 1.21.1.---updated-dependencies:- dependency-name: library/golang  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/golang from 1.21.0 to 1.21.1 in /test/remote (#15387)Bumps library/golang from 1.21.0 to 1.21.1.---updated-dependencies:- dependency-name: library/golang  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/node from 20.4.0 to 20.6.0 in /test/container (#15366)Bumps library/node from 20.4.0 to 20.6.0.---updated-dependencies:- dependency-name: library/node  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* Merge pull request from GHSA-g687-f2gx-6wm8* feat: use untar with limiterSigned-off-by: pashakostohrys <pavel@codefresh.io>* feat: use untar with limiterSigned-off-by: pashakostohrys <pavel@codefresh.io>---------Signed-off-by: pashakostohrys <pavel@codefresh.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* Merge pull request from GHSA-fwr2-64vr-xv9m* fix: prevent seeing/editing 'kubectl.kubernetes.io/last-applied-configuration' cluster annotationSigned-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>* fix: failing unit testSigned-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>---------Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>Co-authored-by: iam-veeramalla <abhishek.veeramalla@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/node from 20.5.0 to 20.6.0 in /ui-test (#15364)Bumps library/node from 20.5.0 to 20.6.0.---updated-dependencies:- dependency-name: library/node  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: handle annotations for resources with ':' in the name (#15101) (#15380)* fix: handle annotations for resources with ':' in the nameSigned-off-by: Oreon Lothamer <oreon.lothamer@softrams.com>* fix: switch to using splitN for handling annotation splittingSigned-off-by: Oreon Lothamer <oreon.lothamer@softrams.com>* fix: check len(parts) !=3Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com>* Retrigger CI pipelineSigned-off-by: Oreon Lothamer <oreon.lothamer@softrams.com>---------Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Improve RBAC documentation (#15430)* Improve staging-db project nameThis change renames the project to distinguish it from the role.Signed-off-by: Andreas Lindhé <andreas@lindhe.io>* Rename db-staging role to singular formRole names should be singular ("User x has the role admin" as opposed to"User x has the role admins").Signed-off-by: Andreas Lindhé <andreas@lindhe.io>* Remove trailing newlinesSigned-off-by: Andreas Lindhé <andreas@lindhe.io>* Consistently mark `AppProject` as codeSigned-off-by: Andreas Lindhé <andreas@lindhe.io>* Replace ```shell with ```console in suitable placesSigned-off-by: Andreas Lindhé <andreas@lindhe.io>* Use consistent style for unordered listhttps://github.com/DavidAnson/markdownlint/blob/main/doc/md004.mdSigned-off-by: Andreas Lindhé <andreas@lindhe.io>* Use consistent emphasis stylehttps://github.com/DavidAnson/markdownlint/blob/main/doc/md049.mdSigned-off-by: Andreas Lindhé <andreas@lindhe.io>* Fix incorrect description of the staging-db exampleSigned-off-by: Andreas Lindhé <andreas@lindhe.io>---------Signed-off-by: Andreas Lindhé <andreas@lindhe.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appsets): gotemplate can cause panic from nil dereference (#15377) (#15378)* fix(appsets): gotemplate can cause panic from nil deferenceSigned-off-by: rumstead <37445536+rumstead@users.noreply.github.com>* fix(appsets): gotemplate can cause panic from nil dereferenceSigned-off-by: rumstead <37445536+rumstead@users.noreply.github.com>---------Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Fix flaky cluster test (#15433)Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* Fix requeue after for Matrix/Merge with SCM or ClusterDecision generators (#15407)Signed-off-by: Cezar Sa Espinola <cezarsa@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: added shorthand flags for follow and conatainre in app logs (#15400)* feat: added shorthand flags for follow and conatainre in app logsSigned-off-by: ashu <ashupednekar49@gmail.com>* doc: re-generated cli docsSigned-off-by: ashu <ashupednekar49@gmail.com>---------Signed-off-by: ashu <ashupednekar49@gmail.com>Co-authored-by: jannfis <jann@mistrust.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* [Bot] docs: Update Snyk reports (#15437)Signed-off-by: CI <ci@argoproj.com>Co-authored-by: CI <ci@argoproj.com>Co-authored-by: jannfis <jann@mistrust.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Better enforcement of application namespace restrictions (#15431)* fix: Better enforce application namespace restrictionsSigned-off-by: jannfis <jann@mistrust.net>* Only call ValidateDestination when allowedSigned-off-by: jannfis <jann@mistrust.net>---------Signed-off-by: jannfis <jann@mistrust.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: fix bullets (#15446)Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: failed to add cluster when the cluster server address is ipv6 (#8204) (#15350)* fix: failed to add cluster when the cluster server address is ipv6 (#8204)Signed-off-by: huyinhou <huyinhou@bytedance.com>* fix: failed to add cluster when the cluster server address is ipv6 (#8204)Signed-off-by: huyinhou <huyinhou@bytedance.com>* remove unused importSigned-off-by: huyinhou <huyinhou@bytedance.com>* fix: lowercase URI secret name; abbreviated IPv6 addressSigned-off-by: huyinhou <huyinhou@bytedance.com>---------Signed-off-by: huyinhou <huyinhou@bytedance.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: Enable haproxy metrics through helm Chart (#15459)Signed-off-by: Mathias Petermann <mathias.petermann@swisscom.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* Stop appending :443 to the server address when using grpc-web (#15435)Signed-off-by: David Marby <david@dmarby.se>Co-authored-by: jannfis <jann@mistrust.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: appset preserve labels and global preserve fields (#15445)* feat: appset preserve labels and global preserve fieldsSigned-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>* feat: appset preserve labels and global preserve fieldsSigned-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>* docs: updated docsSigned-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>* docs: updated docsSigned-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>---------Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Gitlab scm_provider - don't create transport from scratch (#15424) (#15425)* fix : don't create transport from scratch, clone it insteadSigned-off-by: Antoine Jouve <ant.jouve@gmail.com>* feat: clone http.transport for gitea and gitlab providersSigned-off-by: Antoine Jouve <ant.jouve@gmail.com>* chore: properly format gitea providers with gofmtSigned-off-by: Antoine Jouve <ant.jouve@gmail.com>---------Signed-off-by: Antoine Jouve <ant.jouve@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add Factorial to USERS.md (#15473)Signed-off-by: Alejandro López Sánchez <alejandro.lopez@factorial.co>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>…

Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request

Jun 16, 2024

feat: Allow 'both' option for uibannerposition (argoproj#14623)

f1442bf

* fix(ui): Drop ready from Completed container status (#14434) (#14629)Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/go-git/go-git/v5 from 5.7.0 to 5.8.0 (#14641)Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.7.0 to 5.8.0.- [Release notes](https://github.com/go-git/go-git/releases)- [Commits](https://github.com/go-git/go-git/compare/v5.7.0...v5.8.0)---updated-dependencies:- dependency-name: github.com/go-git/go-git/v5  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: webhook handler fails to refresh when alternate application namespaces are configured (#13976)* fix: Add failing test for webhooks in all namespacesThis adds a failing test that properly exercises this functionality overall namespaces. The issue with the code that is under test is that itdoes not pass the namespace correctly to the patch of the application,resulting in the patch not taking place in the correct namespaceSigned-off-by: Nikolas Skoufis <nskoufis@seek.com.au>* fix: queue webhook refresh for apps in all namespacesThis passes the test in the previous commit, to ensure that webhookscorrectly refresh applications across all namespaces.Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au>* fix: Use existing NamespacedName typeUse the existing type instead of a custom typeSigned-off-by: Nikolas Skoufis <nskoufis@seek.com.au>---------Signed-off-by: Nikolas Skoufis <nskoufis@seek.com.au>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: ApplicationSet Controller crashes when tag is not closed; panic: Cannot find end tag="}}"(#14227) (#14651)* ApplicationSet bug fixSigned-off-by: schakrad <58915923+schakrad@users.noreply.github.com>* Update applicationset/utils/utils_test.goSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* oopsSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): The default pod group filter should be removed if fewer than 15 pods (#14590)Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(deep-links): sprig support (#14660)Signed-off-by: daftping <21245083+daftping@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Print in-cluster svr addr disabled warning when server starts (#14553)* chore: Print in-cluster svr addr disabled warning when server startsSigned-off-by: Yuan Tang <terrytangyuan@gmail.com>* fix: mockSigned-off-by: Yuan Tang <terrytangyuan@gmail.com>* no interface changeSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Upgrade semver to avoid cve (#14710)Signed-off-by: Yi Cai <yicai@redhat.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: adding a autosync_enabled field  to the argocd_app_info gauge (#14424)Signed-off-by: Gerardo Corea <gerardocorea92@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(controller): log failed attempts to update operation state (#14273)* fix(controller): log failed attempts to update operation stateSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* new package nameSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* Update controller/appcontroller_test.goSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(server): handle PATCH in http/s server (#2677) (#14530)Signed-off-by: mmerrill3 <jjpaacks@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: manifest generation error with null annotations (#14336) (#14680)* fix: manifest generation error with null annotationsSigned-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>* fix testSigned-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>* fix unit testsSigned-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>---------Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* Clean up repeated package import (#13889)Signed-off-by: Zechun Chen <zechun.chen@daocloud.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(sso): Set redirectURI for gitea, google, oauth Dex connectors (#11237)Signed-off-by: ylxianzhe <ylxianzhe@outlook.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(appset): Restrict scm provider urls (#14286)* 9353: Restrict scm provider urlsSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Enforce restrictionSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Fix after reviewSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Remove commentSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Fix units testsSigned-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com>* 9353: Code review, update commentSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Code review, update comment 2Signed-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Remove doc issuesSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Fix e2eSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Fix e2e goTemplateSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* 9353: Fix e2e pullRequestGeneratorSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>---------Signed-off-by: gmuselli <geoffrey.muselli@gmail.com>Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/go-git/go-git/v5 from 5.8.0 to 5.8.1 (#14744)Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.8.0 to 5.8.1.- [Release notes](https://github.com/go-git/go-git/releases)- [Commits](https://github.com/go-git/go-git/compare/v5.8.0...v5.8.1)---updated-dependencies:- dependency-name: github.com/go-git/go-git/v5  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/aws/aws-sdk-go from 1.44.305 to 1.44.309 (#14746)Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.305 to 1.44.309.- [Release notes](https://github.com/aws/aws-sdk-go/releases)- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.305...v1.44.309)---updated-dependencies:- dependency-name: github.com/aws/aws-sdk-go  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): display valuesobject if set (#14257)* fix: display valuesobject if setWith #11538 we now have the ability to set helm values as an objectinstead of a string, but we also need to be able to correctly displayit in the UI if it is set.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* fix: set valuesobject on saveIf `valuesObject` is present, set it to the value of`input.spec.source.helm.values` on save, as an unmarshaled json string.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* fix: set `helm.values` to empty string on saveIf `valuesObject` exists, set `input.spec.source.helm.values` to anempty string once `valuesObject` has been unmarshalled from thevalues input. This is to prevent unnecessary duplication of the values.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* chore: eslintSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>* chore: eslintSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>* fix: deep clone appThis is so that we can conditionally set `source.helm.values` withoutinadvertently affecting other parts of the app. Only when the editbutton is pressed do we toggle `source.helm.values`.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* chore: eslintSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>---------Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: OCI dependency url can't contain part of repository (#14699)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Add missing value (#14538)Signed-off-by: felix <felix@psy-coding.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* [Bot] docs: Update Snyk reports (#14781)Signed-off-by: CI <ci@argoproj.com>Co-authored-by: CI <ci@argoproj.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/aws/aws-sdk-go from 1.44.309 to 1.44.312 (#14782)Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.309 to 1.44.312.- [Release notes](https://github.com/aws/aws-sdk-go/releases)- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.309...v1.44.312)---updated-dependencies:- dependency-name: github.com/aws/aws-sdk-go  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/xanzy/go-gitlab from 0.88.0 to 0.89.0 (#14784)Bumps [github.com/xanzy/go-gitlab](https://github.com/xanzy/go-gitlab) from 0.88.0 to 0.89.0.- [Changelog](https://github.com/xanzy/go-gitlab/blob/master/releases_test.go)- [Commits](https://github.com/xanzy/go-gitlab/compare/v0.88.0...v0.89.0)---updated-dependencies:- dependency-name: github.com/xanzy/go-gitlab  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/casbin/casbin/v2 from 2.72.1 to 2.73.0 (#14783)Bumps [github.com/casbin/casbin/v2](https://github.com/casbin/casbin) from 2.72.1 to 2.73.0.- [Release notes](https://github.com/casbin/casbin/releases)- [Changelog](https://github.com/casbin/casbin/blob/master/.releaserc.json)- [Commits](https://github.com/casbin/casbin/compare/v2.72.1...v2.73.0)---updated-dependencies:- dependency-name: github.com/casbin/casbin/v2  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add Autodesk to USERS.md (#14778)Signed-off-by: Dylan Page <dylan.page@autodesk.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Add query-scoped cluster URL in Cluster Secret E2E tests (#14446)* Add query-scoped cluster URL in Cluster Secret E2E testsSigned-off-by: Jonathan West <jonwest@redhat.com>* Respond to review commentsSigned-off-by: Jonathan West <jonwest@redhat.com>---------Signed-off-by: Jonathan West <jonwest@redhat.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Clarify that security policy covers last 3 versions (#14786)* docs: Clarify that security policy covers last 3 versionsSigned-off-by: Kostis Kapelonis <kostis@codefresh.io>* Update SECURITY.mdSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Kostis Kapelonis <kostis@codefresh.io>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(controller): cache deadlock on delete and re-add cluster (#14780)Signed-off-by: Nathan Romriell <nateromriell@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: make `helm template` errors less verbose (#14772)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(deep-links): alias `application` as `apps` for consistency with notifications engine (#14761)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): no hyphen for "create job" action + nice icon (#14776) (#14777)* chore(actions): space instead of hyphen in action name (#14776)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* new field for backwards-compatibilitySigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* align icons for maximum synergySigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* delete unused functionSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* revert unnecessary changesSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* Update docs/operator-manual/upgrading/2.7-2.8.mdSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Correct broken `forever` option in pod logs viewer. Fixes #14762 (#14763)Signed-off-by: Alex Collins <alex_collins@intuit.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update application.yaml (#14742)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: add ignoreDifferences name and namespace fields (#14741)* Update application.yamlSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* Update docs/operator-manual/application.yamlSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/node from 20.4.0 to 20.5.0 (#14664)Bumps library/node from 20.4.0 to 20.5.0.---updated-dependencies:- dependency-name: library/node  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/node from 20.4.0 to 20.5.0 in /ui-test (#14662)Bumps library/node from 20.4.0 to 20.5.0.---updated-dependencies:- dependency-name: library/node  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update Controlling-Resource-Modification.md (#14751)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(notifications-catalog): Add nil check for notifications_catalog triggers (#14795)* Add nil check for notifications_catalog triggersSigned-off-by: Trung <trung.hoang@pricehubble.com>* Use correct nil checkSigned-off-by: Trung <trung.hoang@pricehubble.com>* Add missing catalog generation to makefileSigned-off-by: Trung <trung.hoang@pricehubble.com>* Revert changes to update-manifests.shSigned-off-by: Trung <trung.hoang@pricehubble.com>---------Signed-off-by: Trung <trung.hoang@pricehubble.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: ManagedResources API should not return diff for hooks (#14816)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Change Generator docs for List Generator to note any key/value pairs can be used (#14825)This is no longer limited to cluster/url value pairs.Signed-off-by: JesseBot <jessebot@linux.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: improve app destination docstrings (#14836)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: Adding kubelogin capability to argocd-k8s-auth (#9460) (#10700)Signed-off-by: mmerrill3 <jjpaacks@gmail.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Add header support for proxy extension requests  (#14800)* chore: add server URL in the header of proxy extensionsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>* feat: add header support for proxy extension requestsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>* Address review commentsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>* address review commentsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>* Address review commentsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>* Address review commentsSigned-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>---------Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: use consistent password in plugin generator examples (#14837)* docs: use consistent password in plugin generator examplesThe example secret with the token is using `strong-password`, but the later examples use `string-password`.This updates all of the examples to use `strong-password`.Signed-off-by: Nicholas Morey <nicholas@morey.tech>* docs: update another-secret example to include `strong-password`Consistent with above example of client token in argocd-secretSigned-off-by: Nicholas Morey <nicholas@morey.tech>---------Signed-off-by: Nicholas Morey <nicholas@morey.tech>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: give context to error logs #10592 (#14851)* chore: give context to error logsSigned-off-by: ashinsabu3 <ashin.sabu@harness.io>* Update reposerver/repository/repository.goSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: ashinsabu3 <ashin.sabu@harness.io>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add more tests in proxy extension headers (#14842)Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: revert #12255 (#14858)This reverts commit c651bd8de551c85fc897c997c1976d6777259921.Due to the imminent release of 2.8, this needs to be rolled back sincethe proposed fix in #14210 cannot make it in time.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Repo URL link for unsupported sources links to https://<argocd>/null/path/to/chart (#14861)* Fix #14860Fix #14860Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com>* Update USERS.mdSigned-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com>---------Signed-off-by: Talia Stocks <928827+taliastocks@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: correct discrepancies in generated swagger file (#14813)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: wrap ComparisonError messages (#14886)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): Fixes health icon positioning (#14708) (#14852)* fix: Fixes health icon positioning #14708Signed-off-by: ashinsabu3 <ashin.sabu@harness.io>* fix: Fixes alignment of app health application status panel #14708Signed-off-by: ashinsabu3 <ashin.sabu@harness.io>* fix: Added line height to App Status to fix its  positioning #14708Signed-off-by: ashinsabu3 <ashin.sabu@harness.io>---------Signed-off-by: ashinsabu3 <ashin.sabu@harness.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: fix non-deterministic test (#14905)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Change underscore (_) back to plus (+) to get valid SemVer when when reading tags from OCI registry (#14537)* fix: Change underscore (_) back to plus (+) to get valid SemVer when reading tags from OCI registrySigned-off-by: xashr <saschasynaos@gmail.com>* Add test coverage for SemVer tags in TestGetTagsFromUrlSigned-off-by: xashr <saschasynaos@gmail.com>---------Signed-off-by: xashr <saschasynaos@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appset): typo in ARGOCD_APPLICATIONSET_CONTROLLER_ALLOWED_SCM_PROVIDERS (#14902) (#14913)Signed-off-by: gmuselli <geoffrey.muselli@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: provide short revision in ARGOCD_APP_REVISION_SHORT env variable (#14926)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump github.com/aws/aws-sdk-go from 1.44.312 to 1.44.317 (#14925)Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.312 to 1.44.317.- [Release notes](https://github.com/aws/aws-sdk-go/releases)- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.44.312...v1.44.317)---updated-dependencies:- dependency-name: github.com/aws/aws-sdk-go  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump golang.org/x/oauth2 from 0.10.0 to 0.11.0 (#14922)Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.10.0 to 0.11.0.- [Commits](https://github.com/golang/oauth2/compare/v0.10.0...v0.11.0)---updated-dependencies:- dependency-name: golang.org/x/oauth2  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update Generators-Git.md (#14921)Remove a misleading symbol from the pattern for the path.Match function. The pipe symbol doesn't have any special meaning.Signed-off-by: German Lashevich <german.lashevich@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update helm.md - add missing syntax highlighting for YAML and Dockerfile blocks (#14911)Signed-off-by: JesseBot <jessebot@linux.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): COPY JSON for ArgoCD version should include trailing newline (#5117) (#14917)Signed-off-by: Vipin M S <vipinachar2016@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* [Bot] docs: Update Snyk reports (#14919)Signed-off-by: CI <ci@argoproj.com>Co-authored-by: CI <ci@argoproj.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: give context to error logs (#10592) (#14915)* chore: wrap error objects to include contextSigned-off-by: Vipin M S <vipinachar2016@gmail.com>* chore: wrap error objects to include contextSigned-off-by: Vipin M S <vipinachar2016@gmail.com>* chore: wrap error objects to include contextSigned-off-by: Vipin M S <vipinachar2016@gmail.com>* chore: wrap error objects to include contextSigned-off-by: Vipin M S <vipinachar2016@gmail.com>* Update applicationset/controllers/applicationset_controller.goSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Vipin M S <vipinachar2016@gmail.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(appset): Add SCM Provider option for Gitlab generator to filter shared projects from subgroups projects (#14831)* added option to disable gitlab to fetch shared project from a subgroupSigned-off-by: Prune <prune@lecentre.net>* Correct gitlab SCM provider mock testSigned-off-by: Prune <prune@lecentre.net>* updated test to validate shared-groupsSigned-off-by: Prune <prune@lecentre.net>* reworked shared project testsSigned-off-by: Prune <prune@lecentre.net>* added subgroups only testSigned-off-by: Prune <prune@lecentre.net>---------Signed-off-by: Prune <prune@lecentre.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(cmp): send sigterm to cmp commands before sigkill to allow for potential cleanup (#9180) (#14955)* fix: send sigterm to cmp commands before sigkill to allow for potential cleanupSigned-off-by: Ashin Sabu <ashin.sabu@harness.io>* fix: unit test for runCommand in cmpserver to test cleanup modifiedSigned-off-by: Ashin Sabu <ashin.sabu@harness.io>* fix: change unit test for plugin/runCommand to avoid bad trap along with lint fixSigned-off-by: Ashin Sabu <ashin.sabu@harness.io>---------Signed-off-by: Ashin Sabu <ashin.sabu@harness.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Feature bounty proposal (Experimental) (#14234)* Create bounty proposalSigned-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>* Update docs/proposals/feature-bounties.mdSigned-off-by: Dan Garfield <dan@codefresh.io>---------Signed-off-by: Dan Garfield <dan@codefresh.io>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(actions): check if CronWorkflow has labels in create-workflow action (#14962) (#14974)Signed-off-by: Mickaël Canévet <mickael.canevet@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add Jellysmack in USERS.md (#14975)Signed-off-by: Mickaël Canévet <mickael.canevet@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump actions/setup-go from 4.0.1 to 4.1.0 (#14970)Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4.0.1 to 4.1.0.- [Release notes](https://github.com/actions/setup-go/releases)- [Commits](https://github.com/actions/setup-go/compare/fac708d6674e30b6ba41289acaab6d4b75aa0753...93397bea11091df50f3d7e59dc26a7711a8bcfbe)---updated-dependencies:- dependency-name: actions/setup-go  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Adding native OCI support proposal (#13516)Signed-off-by: Andrew Block <andy.block@gmail.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: space in 'Argo CD' (#14987)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: Add Support for AzureDevops Webhooks (#14969)* feat: Add Support for AzureDevops WebhooksSigned-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>* document azure devops webhook configurationSigned-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>---------Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: api server fails to call dex with istio (#14995)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): Update default and max count for maxCookieNumber (#14979)* Update default and max count for maxCookieNumberSigned-off-by: zvlb <vl.zemtsov@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: correct the swagger ui link to support --rootpath (#14845)Signed-off-by: Kevin Yue <yuezk001@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): upgrade nhooyr.io/websocket dependency (#15000)Upgrade from 1.8.6 to 1.8.7 due to high security issueWas solved in dependency with https://github.com/nhooyr/websocket/pull/291Signed-off-by: jmeridth <jmeridth@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: upgrade to go 1.21 (#14992)Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump goreleaser/goreleaser-action from 4.3.0 to 4.4.0 (#14996)Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 4.3.0 to 4.4.0.- [Release notes](https://github.com/goreleaser/goreleaser-action/releases)- [Commits](https://github.com/goreleaser/goreleaser-action/compare/336e29918d653399e599bfca99fadc1d7ffbc9f7...3fa32b8bb5620a2c1afe798654bbad59f9da4906)---updated-dependencies:- dependency-name: goreleaser/goreleaser-action  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: bump ubuntu base image (#15020) (#15021)Latest version of the ubuntu image addresses CVE-2023-38408.https://ubuntu.com/security/notices/USN-6242-1https://github.com/docker-library/repo-info/blob/master/repos/ubuntu/remote/22.04.mdresolves #15020Signed-off-by: Mason Cole <macole@beyondtrust.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: give context to errors (#10592) (#15022)* chore: give context to errorsSigned-off-by: Vipin M S <vipinachar2016@gmail.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/tls/tls.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/settings/settings.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/tls/tls.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Update util/tls/tls.goCo-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>* Apply suggestions from code reviewSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Vipin M S <vipinachar2016@gmail.com>Signed-off-by: Vipin M S <40431065+vipinachar@users.noreply.github.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: give context to errors (#15019)* chore: give context to error logs in reposerverSigned-off-by: Ashin Sabu <ashin.sabu@harness.io>* chore: give context to errors in applicationsetSigned-off-by: Ashin Sabu <ashin.sabu@harness.io>* chore: give context to errors(tweaks in error messages)Signed-off-by: Ashin Sabu <ashin.sabu@harness.io>* chore: give context to errors(fix unit test)Signed-off-by: Ashin Sabu <ashin.sabu@harness.io>---------Signed-off-by: Ashin Sabu <ashin.sabu@harness.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add Carrefour Group to USERS.md (#15039)Signed-off-by: Zadkiel Aharonian <zadkiel_aharonian@carrefour.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(health): spec.executor.instances is Optional, Support a flexible number of executors (#11877)Support a flexible number of executors. For example with a mounted ConfigMap inside the Spark-Operator.Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* [Bot] docs: Update Snyk reports (#15031)Signed-off-by: CI <ci@argoproj.com>Co-authored-by: CI <ci@argoproj.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(reposerver): loosen source not permitted helm errors (#14210)* fix: loosen source not permitted helm errorsWith #12255, we check if a source is first permitted before running`helm template`. This works a bit too well, since this may breakpreviously working manifests. If an `AppProject` has a set of`sourceRepos` which are more restrictive than `*`, and it also has Helmpublic dependencies (repos with credentials would not work with 2.7xdue to the fact they get filtered out before ending up on the reposerver). Whereas before this would work, this currently fails on`HEAD` but not in `2.7x`.What we instead do here is that we only run this check if the chartfailed to download - if it does then we run a check to see if the repois in the allowed repos list. If the repo is not in the allowed reposlist, we return the same error as in #12555, otherwise we bubble up theerror.Should fix #13833.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* fix: check for 401 unauthorized in errorThe regex check works fine for OCI artifacts, but the flow is slightlydifferent for standard Helm charts (specifically when running`helm repo add`). To get around that, we also check the error for`401 Unauthorized`.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* fix: loosen string checkSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>* Revert "chore: revert #12255 (#14858)"This reverts commit c8ae5bc3e79fa985632861f75669c07523f5ded6.Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>* wipSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>* wipSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>* chore: reword test to reduce confusionSigned-off-by: Blake Pettersson <blake.pettersson@gmail.com>---------Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appset): Fix helm valuesObject with ApplicationSet (#14912) (#14920)Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(cli): support apply out of sync flag only (#14624)* feat: support apply out of sync flag onlySigned-off-by: pashakostohrys <pavel@codefresh.io>* update engine versionSigned-off-by: pashakostohrys <pavel@codefresh.io>* update gitops engine versionSigned-off-by: pashakostohrys <pavel@codefresh.io>* add cli optionSigned-off-by: pashakostohrys <pavel@codefresh.io>* feat: verify apply out of sync flagSigned-off-by: pashakostohrys <pavel@codefresh.io>* redundant commentSigned-off-by: pashakostohrys <pavel@codefresh.io>* improve test logicSigned-off-by: pashakostohrys <pavel@codefresh.io>* change command description and do codegenSigned-off-by: pashakostohrys <pavel@codefresh.io>---------Signed-off-by: pashakostohrys <pavel@codefresh.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs(github): comment out notational pieces of PR template (#14888)- the DCO and FAQ sentences are not filled out during PRs and are purely notational  - comment them out with HTML comments, as is common practice    - example from argo-helm: https://github.com/argoproj/argo-helm/blob/962342fe2acef6022ac5c1a3eb352b336308b3eb/.github/pull_request_template.md?plain=1#L1      - copied this practice from other repos I maintain and from other repos before that- these comments are still visible to the PR author, just not visible when rendered, keeping the PR more conciseSigned-off-by: Anton Gilgur <agilgur5@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump golangci/golangci-lint-action from 3.6.0 to 3.7.0 (#15053)Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3.6.0 to 3.7.0.- [Release notes](https://github.com/golangci/golangci-lint-action/releases)- [Commits](https://github.com/golangci/golangci-lint-action/compare/639cd343e1d3b897ff35927a75193d57cfcba299...3a919529898de77ec3da873e3063ca4b10e7f5cc)---updated-dependencies:- dependency-name: golangci/golangci-lint-action  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump actions/setup-node from 3.7.0 to 3.8.0 (#15054)Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.7.0 to 3.8.0.- [Release notes](https://github.com/actions/setup-node/releases)- [Commits](https://github.com/actions/setup-node/compare/e33196f7422957bea03ed53f6fbb155025ffc7b8...bea5baf987ba7aa777a8a0b4ace377a21c45c381)---updated-dependencies:- dependency-name: actions/setup-node  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update bank vaults link to point to the new org (#15069)Bank-Vaults recently migrated to a new organization. The old repository is archived.Signed-off-by: Anton Lindholm <LinAnt@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: improve error logs (#10592) (#15059)* chore: improve error logsSigned-off-by: AvhiMaz <avhimazumder5@outlook.com>* chore: Changes made according to the reviewerSigned-off-by: AvhiMaz <avhimazumder5@outlook.com>* chore: Chnages according to the reviewerI"Signed-off-by: AvhiMaz <avhimazumder5@outlook.com>* Update cmpserver/apiclient/plugin.pb.goSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: AvhiMaz <avhimazumder5@outlook.com>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update link to KubeCon China 2021 talk in README.md (#14887)Signed-off-by: Yuan (Terry) Tang <terrytangyuan@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: document permitOnlyProjectScopedClusters field (#15076)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: kubectl to synchronize argocd apps (#14881)We can use kubectl to synchronize argocd applications the same way we can usethe argocd cli or ui, however there's no documentation.This PR adds documentation for kubectl.Signed-off-by: Jordi Grant Esteve <jgrant.esteve@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: fix typo (#15083)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: add timeout for update cluster info (#14511)* chore: simplified parsing of startup parametersSigned-off-by: yyzxw <1020938856@qq.com>* feat: add timeout for update cluster infoSigned-off-by: yyzxw <1020938856@qq.com>---------Signed-off-by: yyzxw <1020938856@qq.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: requeue ApplicationSet if there are validation errors (#14429)Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: fix link for `argocd-repo-creds.yaml` sample (#15091)Signed-off-by: SHIMADA Kento <shimada.kento8974@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: wrap error objects to include context (#10592) (#15055)* chore: wrap error objects to include context (#10592)Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com>* chore: resolved common_test.go file as per reviewer's feedbackSigned-off-by: Pawank06 <pawan06kumar2003@gmail.com>* chore:changes in ulits.goSigned-off-by: Pawank06 <pawan06kumar2003@gmail.com>* chore: resolving utils_test.go fileSigned-off-by: Pawank06 <pawan06kumar2003@gmail.com>---------Signed-off-by: Pawank06 <pawan06kumar2003@gmail.com>Signed-off-by: B Pawan Kumar <pawan06kumar2003@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(#12862): Update FlinkDeployment health check to support Flink v1.x (#15065)Signed-off-by: Dylan Slavin <dylan@sla.vin>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: add docs for various annotations and labels (#14020)* docs: add docs for various annotationsSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* more infoSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>* more docsSigned-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appset): bitbucket server scm provider EOF on empty repo (#14411)* fix bitbucket server scm provider EOF on empty repo default branch checkSigned-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>* add unit test for bitbucketServer empty repoSigned-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>* check for EOF explicitlySigned-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>---------Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: update confusing variable name (#15106)Signed-off-by: jmcshane <james.mcshane@superorbital.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs(progressive syncs): specify which ConfigMap to use (#15119)Signed-off-by: Gaël Jourdan-Weil <gjourdanweil@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat(appset): added topic filter for Gitlab SCM (#14965)* added topic (tag) filter for Gitlab SCMSigned-off-by: Prune <prune@lecentre.net>* corrected few commentsSigned-off-by: Prune <prune@lecentre.net>* removed latest tag referencesSigned-off-by: Prune <prune@lecentre.net>---------Signed-off-by: Prune <prune@lecentre.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Add kustomization.yaml for server app RBAC (#15124)This change adds a `kustomization.yaml` file for the example RBACrole/rolebinding for argocd server applications.This makes it easier to include them as resources in another `kustomization.yaml`.Instead of including```yamlapiVersion: kustomize.config.k8s.io/v1beta1kind: Kustomizationresources:- https://raw.githubusercontent.com/argoproj/argo-cd/v2.8.0/examples/k8s-rbac/argocd-server-applications/argocd-server-rbac-clusterrole.yaml- https://raw.githubusercontent.com/argoproj/argo-cd/v2.8.0/examples/k8s-rbac/argocd-server-applications/argocd-server-rbac-clusterrolebinding.yaml```the user can now instead include```yamlapiVersion: kustomize.config.k8s.io/v1beta1kind: Kustomizationresources:- github.com/argoproj/argo-cd/examples/k8s-rbac/argocd-server-applications?ref=v2.8.0```This change was performed by running:```consolekustomize createkustomize edit add resource argocd-server-rbac-clusterrole.yamlkustomize edit add resource argocd-server-rbac-clusterrolebinding.yaml```Signed-off-by: Andreas Lindhé <andreas@lindhe.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: ✏️ fix typo on configmap name for private certs (#9596)Signed-off-by: Gaël Jourdan-Weil <gael.jourdan-weil@kelkoogroup.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* Merge pull request from GHSA-c8xw-vjgf-94hrSigned-off-by: pashakostohrys <pavel@codefresh.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): code lint (#15150)Signed-off-by: ebuildy <ebuildy@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: windows build (#15154)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: run refresh from UI in parallel (#15138)Signed-off-by: Lukas Wöhrl <lukas.woehrl@plentymarkets.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(cli): add support for components with non-default names (#10200) (#14605)* fix(cli): add support for components with non-default names (#10200)Co-Authored-By: maheshbaliga <mahesh.baliga@infracloud.io>Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>---------Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Co-authored-by: maheshbaliga <mahesh.baliga@infracloud.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Updated docs about using a slash in ignoreDifferences (#15144)Signed-off-by: Christian Hernandez <christian@chernand.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: stop creating new otel interceptor to avoid memory leak (#15174)Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add example jq path expression (#15130)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: document sourceNamespaces field (#15195)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appset): Matrix Generator Override not Working for Booleans (#14498) (#14573)* Fix AppSet matrix generator parameter overrideSigned-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com>* Add test case for parameter override fixSigned-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com>---------Signed-off-by: Alexander Bellhäuser <alexbde@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: remove unnecessary version number (#15198)We have versioned docs now, no need for this.Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): switch podgroup notification to tooltip message (#14821)* improve pod grouping uxSigned-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>fix: update log view on container selectSigned-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>* fix(ui): improve pod grouping uxSigned-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>* fix(ui):update the pod grouping messages to tooltipSigned-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>* fix(ui):update the pod grouping messages to tooltipSigned-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>* fix: GroupNodes notificationSigned-off-by: AS <11219262+ashutosh16@users.noreply.github.com>* fix: GroupNodes notificationSigned-off-by: AS <11219262+ashutosh16@users.noreply.github.com>---------Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>Signed-off-by: AS <11219262+ashutosh16@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add upsider to USERS.md (#15228)Signed-off-by: Vlad Fratila <vlad.fratila@up-sider.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: clarify argocd-repo-server repo-cache-expiration HA use case (#15239)Signed-off-by: phanama <yudiandreanp@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: better logs for jq expression errors (#15226)Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(ui): Helm chart empty maintainers blow up Argo UI (#15225)Signed-off-by: Carlos Castro carlos.castro@jumo.worldSigned-off-by: Carlos Castro carlos.castro@jumo.worldSigned-off-by: Carlos Castro <carlos.castro@jumo.world>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: add Kvist to USERS.md (#15240)Signed-off-by: Fredrik A. Madsen-Malmo <fredrik.malmo@icloud.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: improve doc on labels parameter on scmProvider generator (#15255)Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Update ApplicationSet docs (#15269)Signed-off-by: David Muckle <dvdmuckle@dvdmuckle.xyz>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: support extra attributes for opentelemetry (#15071)Signed-off-by: penglongli <pelenli@tencent.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Add Twilio Segment to USERS.md (#15267)Thank you to the Argo community!Signed-off-by: Prasad Katti <prasad.katti@segment.com>Co-authored-by: jannfis <jann@mistrust.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: make WatchResourceTree use namespaced cache key (#15258)* fix: make WatchResourceTree use namespaced application cache keySigned-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com>* chore: add PGS to USERS.mdSigned-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com>---------Signed-off-by: Torbjørn Fjørtoft <torbjorn.fjortoft@pgs.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: remove duplicate function (#15123)Signed-off-by: yyzxw <1020938856@qq.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Cache control 404 asset requests (#15327)* backfill cache control header tests for ui assetsSigned-off-by: Scott Windsor <scott.windsor@flexe.com>* Set cache-control header non-cache for assets not foundSigned-off-by: Scott Windsor <scott.windsor@flexe.com>* fix golang-cilint warningSigned-off-by: Scott Windsor <scott.windsor@flexe.com>---------Signed-off-by: Scott Windsor <scott.windsor@flexe.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Fixes a markdown typo in USERS.md (#15362)This removes the whitespace between the link text and the link URL.Signed-off-by: Prasad Katti <prasad.katti@segment.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: upgrade notification engine (#15359)* Update notifications-engine dependenciesSigned-off-by: Mike Splain <mike.splain@gmail.com>* Update docsSigned-off-by: Mike Splain <mike.splain@gmail.com>---------Signed-off-by: Mike Splain <mike.splain@gmail.com>Co-authored-by: pasha-codefresh <pavel@codefresh.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: add Dott to users (#15370)Signed-off-by: Jake Burn <jake@ridedott.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(notifications-catalog): Add nil check for on-deployed trigger (#15363)Signed-off-by: Fs02 <surya.asriadie@gmail.com>Co-authored-by: pasha-codefresh <pavel@codefresh.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: auto respect rbac for discovery/sync (#14381)feat: auto respect rbac for discovery/sync (#14381)Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: Add ARGOCD_CLUSTER_CACHE_LIST_PAGE_BUFFER_SIZE environment variable (#15159)Signed-off-by: Brad West <brad.g.west@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appset): Revert applicationset-name labels (#15324)* fix(15282) Revert applicationset-name labelsSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>* fix(15282) fix unit testSigned-off-by: gmuselli <geoffrey.muselli@gmail.com>---------Signed-off-by: gmuselli <geoffrey.muselli@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/golang from 1.21.0 to 1.21.1 (#15391)Bumps library/golang from 1.21.0 to 1.21.1.---updated-dependencies:- dependency-name: library/golang  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/golang from 1.21.0 to 1.21.1 in /test/remote (#15387)Bumps library/golang from 1.21.0 to 1.21.1.---updated-dependencies:- dependency-name: library/golang  dependency-type: direct:production  update-type: version-update:semver-patch...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/node from 20.4.0 to 20.6.0 in /test/container (#15366)Bumps library/node from 20.4.0 to 20.6.0.---updated-dependencies:- dependency-name: library/node  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* Merge pull request from GHSA-g687-f2gx-6wm8* feat: use untar with limiterSigned-off-by: pashakostohrys <pavel@codefresh.io>* feat: use untar with limiterSigned-off-by: pashakostohrys <pavel@codefresh.io>---------Signed-off-by: pashakostohrys <pavel@codefresh.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* Merge pull request from GHSA-fwr2-64vr-xv9m* fix: prevent seeing/editing 'kubectl.kubernetes.io/last-applied-configuration' cluster annotationSigned-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>* fix: failing unit testSigned-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>---------Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>Co-authored-by: iam-veeramalla <abhishek.veeramalla@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore(deps): bump library/node from 20.5.0 to 20.6.0 in /ui-test (#15364)Bumps library/node from 20.5.0 to 20.6.0.---updated-dependencies:- dependency-name: library/node  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: handle annotations for resources with ':' in the name (#15101) (#15380)* fix: handle annotations for resources with ':' in the nameSigned-off-by: Oreon Lothamer <oreon.lothamer@softrams.com>* fix: switch to using splitN for handling annotation splittingSigned-off-by: Oreon Lothamer <oreon.lothamer@softrams.com>* fix: check len(parts) !=3Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com>* Retrigger CI pipelineSigned-off-by: Oreon Lothamer <oreon.lothamer@softrams.com>---------Signed-off-by: Oreon Lothamer <oreon.lothamer@softrams.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: Improve RBAC documentation (#15430)* Improve staging-db project nameThis change renames the project to distinguish it from the role.Signed-off-by: Andreas Lindhé <andreas@lindhe.io>* Rename db-staging role to singular formRole names should be singular ("User x has the role admin" as opposed to"User x has the role admins").Signed-off-by: Andreas Lindhé <andreas@lindhe.io>* Remove trailing newlinesSigned-off-by: Andreas Lindhé <andreas@lindhe.io>* Consistently mark `AppProject` as codeSigned-off-by: Andreas Lindhé <andreas@lindhe.io>* Replace ```shell with ```console in suitable placesSigned-off-by: Andreas Lindhé <andreas@lindhe.io>* Use consistent style for unordered listhttps://github.com/DavidAnson/markdownlint/blob/main/doc/md004.mdSigned-off-by: Andreas Lindhé <andreas@lindhe.io>* Use consistent emphasis stylehttps://github.com/DavidAnson/markdownlint/blob/main/doc/md049.mdSigned-off-by: Andreas Lindhé <andreas@lindhe.io>* Fix incorrect description of the staging-db exampleSigned-off-by: Andreas Lindhé <andreas@lindhe.io>---------Signed-off-by: Andreas Lindhé <andreas@lindhe.io>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix(appsets): gotemplate can cause panic from nil dereference (#15377) (#15378)* fix(appsets): gotemplate can cause panic from nil deferenceSigned-off-by: rumstead <37445536+rumstead@users.noreply.github.com>* fix(appsets): gotemplate can cause panic from nil dereferenceSigned-off-by: rumstead <37445536+rumstead@users.noreply.github.com>---------Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* chore: Fix flaky cluster test (#15433)Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* Fix requeue after for Matrix/Merge with SCM or ClusterDecision generators (#15407)Signed-off-by: Cezar Sa Espinola <cezarsa@gmail.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* feat: added shorthand flags for follow and conatainre in app logs (#15400)* feat: added shorthand flags for follow and conatainre in app logsSigned-off-by: ashu <ashupednekar49@gmail.com>* doc: re-generated cli docsSigned-off-by: ashu <ashupednekar49@gmail.com>---------Signed-off-by: ashu <ashupednekar49@gmail.com>Co-authored-by: jannfis <jann@mistrust.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* [Bot] docs: Update Snyk reports (#15437)Signed-off-by: CI <ci@argoproj.com>Co-authored-by: CI <ci@argoproj.com>Co-authored-by: jannfis <jann@mistrust.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: Better enforcement of application namespace restrictions (#15431)* fix: Better enforce application namespace restrictionsSigned-off-by: jannfis <jann@mistrust.net>* Only call ValidateDestination when allowedSigned-off-by: jannfis <jann@mistrust.net>---------Signed-off-by: jannfis <jann@mistrust.net>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* docs: fix bullets (#15446)Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>Signed-off-by: Jimmy Neville <jimmyeneville@gmail.com>* fix: failed to add cluster when the cluster server address is ipv6 (#8204) (#15350)* fix: failed to add cluster when the cluster server address is ipv6 (#8204)Signed-off-by: huyinhou <huyinhou@bytedance.com>* fix: failed to add cluster when the cluster server address is ipv6 (#8204)Signed-off-by: huyinhou <huyinhou@bytedance.com>* remove …

Labels

None yet

1 participant

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix DOS attack from malicious pongs#291

Fix DOS attack from malicious pongs#291

Conversation

nhooyr commentedApr 7, 2021•
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Movatterモバイル変換

Fix DOS attack from malicious pongs#291

Fix DOS attack from malicious pongs#291

Conversation

nhooyr commentedApr 7, 2021• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

Uh oh!

nhooyr commentedApr 7, 2021•
edited
Loading