- Notifications
You must be signed in to change notification settings - Fork329
Merge master into dev#277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Allow *http.Client with Timeout set
HTTP header values, as opposed to header keys,are case sensitive, but implementation of headerTokens()before this patch would return lowered values always.This old behavior could lead to chromium (v87) WebSocketrejecting connnection because negotiated subprotocol,returned in Sec-WebSocket-Protocol header (loweredbe headerToken() function) would not match one sentby client, in case client specified value with capitalletters.
Thank you@icholy for identifying these in#259 (comment)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were a few PRs merged into the master branch that were then not
merged into the dev branch. This branch merges those changes in cleanly.