- Notifications
You must be signed in to change notification settings - Fork329
removing bad newline#266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
// It ensures the client speaks the echo subprotocol and | ||
// only allows one message every 100ms with a 10 message burst. | ||
typeechoServerstruct { | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Great catch!
I prefer to avoid small dependencies. idt this is common enough a bug to justify incorporating I disagree that It's |
For my personal Golang projects, I've found a tremendous amount of value in using golanci-lint. If you want to keep it simple and not use it, that's fine - I just thought I would throw it out there for consideration. golanci-lint has some linters enabled by default and some disabled by default. My typical workflow is that I enable every single linter that it offers. This generates a lot of noise, so then I go through and manually disable the ones that I disagree with, and the ones that are noisy. After that, I am left with a few legitimate issues / bugs in my code, which I clean up, making the whole process worth it. =) An example yaml config file: |
Fair but the line has grown ever thin. code formatting isn't far from automated linting imo.
That's wild and definitely puts a dent in
Yea I appreciate the thoughts and discussion but for now I'm definitely in favour of keeping things as minimal as possible. Perhaps I'll switch the library toStaticcheck which seems like it's highly recommended from that thread and a sort of successor to golint. |
Uh oh!
There was an error while loading.Please reload this page.
this seems like a pointless newline, correct me if I am wrong.
furthermore, I would recommend usingwsl in CI to automatically detect these kinds of errors in the future.
wsl is included ingolangci-lint, which is the defacto golang linter, which it seems like youdon't use currently.