Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Clone options#259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nhooyr merged 1 commit intocoder:devfromabursavich:options
Sep 24, 2020
Merged

Clone options#259

nhooyr merged 1 commit intocoder:devfromabursavich:options
Sep 24, 2020

Conversation

abursavich
Copy link
Contributor

opts = &*opts is a no-op.

See:https://staticcheck.io/docs/checks#SA4001

nhooyr reacted with heart emoji
@nhooyr
Copy link
Contributor

Nice catch! Can confirm. I tested it at the time and thought it worked but I guess I got confused.

Copy link
Contributor

@nhooyrnhooyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for contributing@abursavich!

@nhooyrnhooyr merged commitfdc4079 intocoder:devSep 24, 2020
@icholy
Copy link

There are still 2 more instances of this.

$ git grep "\&\*dial.go:        copts = &*coptsinternal/test/wstest/pipe.go:   dialOpts = &*dialOpts

@nhooyr
Copy link
Contributor

nhooyr commentedOct 2, 2020•
edited
Loading

Good eye@icholy, I've made note of those in my TODO and will have a PR up to fix shortly.

nhooyr added a commit that referenced this pull requestJan 9, 2021
Thank you@icholy for identifying these in#259 (comment)
nhooyr added a commit that referenced this pull requestJan 9, 2021
Thank you@icholy for identifying these in#259 (comment)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
1 more reviewer

@nhooyrnhooyrnhooyr approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@abursavich@nhooyr@icholy
[8]ページ先頭
©2009-2025 Movatter.jp