Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Make compression negotiation more lenient#258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nhooyr merged 4 commits intocoder:devfromabursavich:compression
Oct 13, 2023

Conversation

abursavich
Copy link
Contributor

@abursavichabursavich commentedSep 9, 2020
edited
Loading

I ran into a server this morning that was being extra-super-duper explicit and specifyingserver_max_window_bits=15, so I started digging into the RFC and the negotiation code... These are the changes I would like to make:

  1. Client allows server to specifyserver_max_window_bits: The server may use a smaller sliding window for compression without affecting the client's decompression.
  2. Server allows client to specifyserver_max_window_bits=15: Although the server can't support a smaller sliding window at the moment, it doesn't hurt to accept the specification of 15 bits from a client.
  3. Server declines unacceptable compression offers without rejecting the request and selects the first acceptable offer: According to the RFC, the client may send multiple offers in its preferential order and the server may accept its preferred offer or decline all of them. Declining a compression offer doesn't mean the connection must be terminated.
  4. Removes deadx-webkit-deflate-frame code.

nhooyr reacted with heart emoji
@abursavich
Copy link
ContributorAuthor

abursavich commentedSep 9, 2020
edited
Loading

The RFCs allow for some strange formatting of the extensions. For instance, the parameter values may be quoted (e.g.server_max_window_bits="15"). I went ahead and implemented full parsing in a different branch. It's not necessary to fix the specific issue I ran into, but it's here if you're interested:abursavich/websocket@compression...abursavich:headers

nhooyr reacted with heart emoji

@abursavichabursavich changed the titleMake compression negotiation more more lenientMake compression negotiation more lenientSep 9, 2020
@nhooyr
Copy link
Contributor

Thanks for contributing@abursavich! <3

Unfortunately I'm going to be a busy this week until the weekend. I'll try and review these changes then.

Have a great rest of your week!

Copy link
Contributor

@nhooyrnhooyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Beautiful, sorry for the delay.

abursavich reacted with thumbs up emoji
@nhooyrnhooyr merged commit97d7f90 intocoder:devOct 13, 2023
@nhooyr
Copy link
Contributor

Thanks@abursavich!

abursavich reacted with rocket emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
1 more reviewer

@nhooyrnhooyrnhooyr approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.8.8
Development

Successfully merging this pull request may close these issues.

2 participants
@abursavich@nhooyr

[8]ページ先頭

©2009-2025 Movatter.jp