- Notifications
You must be signed in to change notification settings - Fork329
v1.8.8#256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This way we don't pollute the directory tree.
NetConn has to close the connection to interrupt in progress readsand writes. However, it can block reads and writes that occurafter the deadline instead of closing the connection.Closes#228
Disable compression by default and switch to stdlib compress
Closes#248Luckily, due to the 5s timeout on the close handshake, this would havehad very minimal effects on anyone in production.
Thank you@icholy for identifying these in#259 (comment)
Merge master into dev
netconn.go: Disable read limit on WebSocket
Unfortunately going to have to delay this. The autobahn test suite is failing. |
Contributor
maggie44 commentedOct 19, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
40MB? 🤨. Or Kb? |
Glad no one ran into this in production.
Oh haha yes KB not MB. |
77f7262 toe72696eCompareRelease notes are complete. Docs have been updated. Will release Friday at noon. |
No longer needed :)
Underscores in symbols are ok sometimes...
Tricky tricky.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will document release notes in this PR soon.