Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

netconn.go: Disable read limit on WebSocket#254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nhooyr merged 2 commits intodevfromnetconn-readlimit
Jan 9, 2021
Merged

Conversation

nhooyr
Copy link
Contributor

Closes#245

@nhooyr
Copy link
ContributorAuthor

Please review@cmoog

@nhooyr
Copy link
ContributorAuthor

Will need a test.

@nhooyrnhooyr changed the titlenetconn: Disable read limit on WebSocketnetconn.go: Disable read limit on WebSocketJul 4, 2020
@nhooyrnhooyr merged commit642a013 intodevJan 9, 2021
@nhooyrnhooyr deleted the netconn-readlimit branchJanuary 9, 2021 13:15
tmessi added a commit to hashicorp/boundary that referenced this pull requestOct 6, 2023
When the boundary client establishes a connection to the websocket usedto communicate with a worker, it was configured with a max websocketmessage size of 32KiB. This was the default behavior for v1.8.7 ofnhooyr/websocket. However, there are cases where the worker can sendmessages to the client that are larger than 32KiB. When this happens theclient returns an error and terminates the connection.Notably this seems to only currently impact sessions made to SSHTargets, although it could theoretically impact any target typedepending on the details of how the worker performs the writing of themessages. The issue can be reproduced by attempting to scp a largeenough file from an SSH Target to the client. In this case theconnection gets terminated and results in a partial transfer of thefile.This message size limit appears to be unnecessary, and the defaultbehavior is changing in v1.8.8 of nhooyr/websocket to make the messagesize unlimited. Since this version is not yet released, this commitswitches the dependency to a fork with a version that is v1.8.7 plus thepatch to disable the limit. Once v1.8.8 is release this dependency canbe set back.See:coder/websocket#254coder/websocket#256
tmessi added a commit to hashicorp/boundary that referenced this pull requestOct 6, 2023
When the boundary client establishes a connection to the websocket usedto communicate with a worker, it was configured with a max websocketmessage size of 32KiB. This was the default behavior for v1.8.7 ofnhooyr/websocket. However, there are cases where the worker can sendmessages to the client that are larger than 32KiB. When this happens theclient returns an error and terminates the connection.Notably this seems to only currently impact sessions made to SSHTargets, although it could theoretically impact any target typedepending on the details of how the worker performs the writing of themessages. The issue can be reproduced by attempting to scp a largeenough file from an SSH Target to the client. In this case theconnection gets terminated and results in a partial transfer of thefile.This message size limit appears to be unnecessary, and the defaultbehavior is changing in v1.8.8 of nhooyr/websocket to make the messagesize unlimited. Since this version is not yet released, this commitswitches the dependency to a fork with a version that is v1.8.7 plus thepatch to disable the limit. Once v1.8.8 is release this dependency canbe set back.See:coder/websocket#254coder/websocket#256
tmessi added a commit to hashicorp/boundary that referenced this pull requestOct 6, 2023
When the boundary client establishes a connection to the websocket usedto communicate with a worker, it was configured with a max websocketmessage size of 32KiB. This was the default behavior for v1.8.7 ofnhooyr/websocket. However, there are cases where the worker can sendmessages to the client that are larger than 32KiB. When this happens theclient returns an error and terminates the connection.Notably this seems to only currently impact sessions made to SSHTargets, although it could theoretically impact any target typedepending on the details of how the worker performs the writing of themessages. The issue can be reproduced by attempting to scp a largeenough file from an SSH Target to the client. In this case theconnection gets terminated and results in a partial transfer of thefile.This message size limit appears to be unnecessary, and the defaultbehavior is changing in v1.8.8 of nhooyr/websocket to make the messagesize unlimited. Since this version is not yet released, this commitswitches the dependency to a fork with a version that is v1.8.7 plus thepatch to disable the limit. Once v1.8.8 is release this dependency canbe set back.See:coder/websocket#254coder/websocket#256
tmessi added a commit to hashicorp/boundary that referenced this pull requestOct 6, 2023
When the boundary client establishes a connection to the websocket usedto communicate with a worker, it was configured with a max websocketmessage size of 32KiB. This was the default behavior for v1.8.7 ofnhooyr/websocket. However, there are cases where the worker can sendmessages to the client that are larger than 32KiB. When this happens theclient returns an error and terminates the connection.Notably this seems to only currently impact sessions made to SSHTargets, although it could theoretically impact any target typedepending on the details of how the worker performs the writing of themessages. The issue can be reproduced by attempting to scp a largeenough file from an SSH Target to the client. In this case theconnection gets terminated and results in a partial transfer of thefile.This message size limit appears to be unnecessary, and the defaultbehavior is changing in v1.8.8 of nhooyr/websocket to make the messagesize unlimited. Since this version is not yet released, this commitswitches the dependency to a fork with a version that is v1.8.7 plus thepatch to disable the limit. Once v1.8.8 is release this dependency canbe set back.See:coder/websocket#254coder/websocket#256(cherry picked from commit88bb253)
nhooyr added a commit that referenced this pull requestOct 25, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@nhooyr

[8]ページ先頭

©2009-2025 Movatter.jp