Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Rewrite with compression support#163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nhooyr merged 56 commits intomasterfromcompress
Feb 16, 2020
Merged

Rewrite with compression support#163

nhooyr merged 56 commits intomasterfromcompress
Feb 16, 2020

Conversation

nhooyr
Copy link
Contributor

ptman reacted with thumbs up emoji
@nhooyr
Copy link
ContributorAuthor

Memory usage is still a problem but I think this feature can still be useful in some cases and it is standard so might as well implement it given it doesn't add too much to the API.

@nhooyr
Copy link
ContributorAuthor

Thoughts on the API?@andersfylling@coadler@FZambia

@codercoder deleted a comment fromgithub-actionsbotOct 15, 2019
@nhooyrnhooyr changed the base branch frommaster tocompress2October 15, 2019 01:55
@nhooyrnhooyr changed the titleImplement RFC 7692 WebSocket Compression ExtensionsImplement RFC 7692 WebSocket Compression Extensions PR 1Oct 15, 2019
@nhooyrnhooyr changed the titleImplement RFC 7692 WebSocket Compression Extensions PR 1RFC 7692 WebSocket Compression Extensions PR 1Oct 15, 2019
@nhooyrnhooyr changed the titleRFC 7692 WebSocket Compression Extensions PR 1RFC 7692 WebSocket Compression Extensions [1]Oct 15, 2019
@andersfylling
Copy link

It's not relevant to my use-cases as I use gzip, I think(?). But looks easy enough to use.

I would add a validation step on Treshold and Level field.

@nhooyr
Copy link
ContributorAuthor

Sounds good.

Only issue I could forsee with this API is you can't control per message compression which I imagine is something people will want control over. But I'd have to break backwards compat and add a writer options structure to allow for that.

Or maybe just a way to disable compression for an individual message (that may already have some other form of compression, e.g. a JPEG image) but keep the level and threshold global to the connection.

🤔

@nhooyr
Copy link
ContributorAuthor

Also, I noticed Facebook uses per message deflate for their chat, which has very small message sizes. Could either be a oversight or an optimization, not sure. 🤔

@nhooyrnhooyr changed the titleRFC 7692 WebSocket Compression Extensions [1]RFC 7692 WebSocket Compression ExtensionsNov 10, 2019
@nhooyrnhooyr changed the base branch fromcompress2 tomasterNovember 10, 2019 02:39
@nhooyrnhooyrforce-pushed thecompress branch 3 times, most recently from14baab4 to2a9e139CompareNovember 12, 2019 02:14
@nhooyrnhooyr merged commitb961007 intomasterFeb 16, 2020
@nhooyrnhooyr deleted the compress branchFebruary 16, 2020 02:56
@nhooyrnhooyr mentioned this pull requestMay 12, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@nhooyr@andersfylling

[8]ページ先頭

©2009-2025 Movatter.jp