Commit5fe95bb

committed

write.go: Fix potential writeFrame deadlock

Closes#405You should always be reading from the connection with CloseRead so this shouldn'thave affected anyone using the library correctly.

1 parent6cec2ca commit5fe95bbCopy full SHA for 5fe95bb

File tree

-0

lines changed

-0

lines changed

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -280,6 +280,7 @@ func (c *Conn) writeFrame(ctx context.Context, fin bool, flate bool, opcode opco`
`280`	`280`	`err=errClosed`
`281`	`281`	`case<-ctx.Done():`
`282`	`282`	`err=ctx.Err()`
	`283`	`+default:`
`283`	`284`	`}`
`284`	`285`	`c.close(err)`
`285`	`286`	`err=fmt.Errorf("failed to write frame: %w",err)`

Comments

(0)