Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: show agent metadata#92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
rodrimaia merged 7 commits intomainfromshow-agent-metadata
May 9, 2023
Merged

feat: show agent metadata#92

rodrimaia merged 7 commits intomainfromshow-agent-metadata
May 9, 2023

Conversation

@rodrimaia
Copy link
Contributor

@rodrimaiarodrimaia commentedMay 2, 2023•
edited
Loading

the UI alignment is not working as it is supposed to, I guess something related to the vscode tooltip internals (because the string itself is correct). I can investigate this later, but I don't think that is a blocker.

  • We added the metadata to the sidebar instead of having a statusbaricon:
    image

Closes#71

matifali and BrunoQuaresma reacted with heart emoji
@matifali
Copy link
Member

Wow loved it. Awesome addition.

@matifalimatifali self-requested a reviewMay 3, 2023 16:16
@kylecarbs
Copy link
Member

@rodrimaia the agent name is already shown in the workspace title, so I'm not sure we should add another item to the bottom bar all the time.

e.g. if I have no metadata right now, what shows up?

Copy link
Contributor

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The code looks good to me. My only considerations are:

  • What happens if it is empty or the agent is not connected
  • If there is no way to align the value text to the right, I'm ok with this version

@rodrimaia
Copy link
ContributorAuthor

  • Hide/Close the statusbar icon if there is no metadata
  • icon name changed to "Metadata"

@kylecarbs
Copy link
Member

@rodrimaia could you update the screenshot with the new display?

@rodrimaia
Copy link
ContributorAuthor

@rodrimaia could you update the screenshot with the new display?

@kylecarbs
image

@kylecarbs
Copy link
Member

@rodrimaia thoughts on putting metadata in the Coder sidebar instead?

@kylecarbs
Copy link
Member

The reason is that it's kinda odd for dynamic data to go in the tooltip, and in the UI we have a "Copy" button, which might be useful in the extension too.

@rodrimaia
Copy link
ContributorAuthor

@kylecarbs I am experimenting with showing the metadata on the sidebar. I will post it here when I reach a working version.

matifali reacted with thumbs up emoji

@rodrimaia
Copy link
ContributorAuthor

image

@rodrimaiarodrimaia merged commit0e76e62 intomainMay 9, 2023
@rodrimaiarodrimaia deleted the show-agent-metadata branchMay 9, 2023 18:46
@rodrimaiarodrimaia self-assigned thisMay 9, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@matifalimatifalimatifali approved these changes

@kylecarbskylecarbsAwaiting requested review from kylecarbs

+1 more reviewer

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rodrimaiarodrimaia

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

display agent metadata

4 participants

@rodrimaia@matifali@kylecarbs@BrunoQuaresma
[8]ページ先頭
©2009-2025 Movatter.jp