coder/vscode-coderPublic

NotificationsYou must be signed in to change notification settings
Fork35
Star108

pass headers to coder api#81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

Liorba wants to merge10 commits intocoder:mainfromLiorba:main

Closed

pass headers to coder api#81

Liorba wants to merge10 commits intocoder:mainfromLiorba:main

Conversation

Copy link

Liorba commentedApr 17, 2023•
edited
Loading

Hey coder team this pr tries to tackle issue#76
This pr added the following functionality to the vscode extension:

new set of configuration to set a VPN header
option to set the token directly insettings.json or in file
if header name is set and non of the option above was not provided a user will be presented by prompt widow to add his token (similar to session token)
if a valid header it will be added toAxios global headers.
To deal with a case that the provided token expired of invalid after some time, I've added new Axios interceptor. which will check a set of conditions and prompt the user to put new case it discover a bad response due to invalid token
pass the vpn header name and token to the SSH configproxyCommand

There is an issue with the codervpnssh command that unlike thessh command do not pass the headers correctly to the underline ssh command. when I replace it with the "regular" ssh command it worked. any Idea what might causing this?

liorb-canva added4 commits

April 6, 2023 10:38

initial implementation of the header token

c29cdd4

added vpn header

e9c94ea

some improvement to the vpn headers

726586c

remove personal vscode settings

30b2b59

Liorba mentioned this pull request

Apr 17, 2023

pass headers to coder api#76

Closed

kylecarbs mentioned this pull request

Apr 17, 2023

fix: add global headers tovscodessh commandcoder/coder#7181

Merged

Copy link

Member

kylecarbs commentedApr 17, 2023

@Liorba I fixed the header problem in the attached PR:coder/coder#7181

I'll review the rest shortly!

Delete package-lock.json

6b16ada

deansheather reviewed

Apr 17, 2023

View reviewed changes

Copy link

Member

deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This should probably just be a map of header name to string or file path so people can set multiple headers

src/commands.ts OutdatedShow resolvedHide resolved

src/commands.tsShow resolvedHide resolved

Liorbaand others added2 commits

April 18, 2023 09:48

Update src/commands.ts

b7e6f6c

Co-authored-by: Dean Sheather <dean@deansheather.com>

Update src/commands.ts

c2e6c2b

Co-authored-by: Dean Sheather <dean@deansheather.com>

Copy link

Author

Liorba commentedApr 17, 2023

@deansheather,I thought about this approach at first, but this is no regular header. it sort of like the session token which is a header but has a special treatments.

Merge branch 'main' into main

d46db51

Copy link

Member

kylecarbs commentedApr 18, 2023

@Liorba is it alright if I work off of your code and change some things? I want to make it more generic so that it's not so VPN-specific (even though that will be the first-class use-case).

Copy link

Author

Liorba commentedApr 18, 2023•
edited
Loading

@kylecarbs sure mate!
what change did you have in mind? I can probably work on that as well if you like.
TBH, the reason I didn't went on the generic approach at the first place is that the VPN header are completely different beast than any other header because :

it can be expired, and we need to catch that
it need to to be stored between sessions
we need to pass it to the ssh command.
Due to that it seems like more related to the session-token implementation in the extension (which itselfbeing pass as a header)
LMK how can I help in any direction you may choose.