Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove node forge dependency#648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
EhabY merged 4 commits intocoder:mainfromEhabY:remove-node-forge-dependency
Nov 17, 2025

Conversation

@EhabY
Copy link
Collaborator

@EhabYEhabY commentedNov 14, 2025
edited
Loading

Replaced thenode-forge dependency with@peculiar/x509, which is more modern, lightweight, and still widely adopted (600K+ downloads). I initially attempted to use Node.js's built-incrypto module, but encountered an issue wherekeyUsage consistently returnedundefined in Electron environments.

Testing in Electron Environments

Added comprehensive testing for Electron environments. In the latest commit, allvitest tests now run in Electron, which mirrors the environment VS Code operates in. This introduces a few seconds of additional overhead compared to running them in pure NodeJS env. An alternative approach would be to create a separate command (e.g.,yarn test:electron) that runs only the relevant tests in Electron, but this is less robust and could result in missed test coverage as the codebase evolves.

I also explored running these as VS Code integration tests, but this approach has significant limitations. It would require converting the test suite to Mocha and rewriting tests to use VS Code API calls, which would make it difficult to write focused unit tests.

Electron Dependency

Addedelectron as a dev dependency to ensure proper BoringSSL usage (rather than OpenSSL, which Node.js uses). Note that the current version is the latest release, while VS Code may be running an older version. We should consider pinning to an older Electron version that more closely matches VS Code's environment.

@EhabYEhabYforce-pushed theremove-node-forge-dependency branch fromefa4a61 to72c86aeCompareNovember 14, 2025 09:57
Copy link
Member

@code-ashercode-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

awesome

@EhabYEhabYforce-pushed theremove-node-forge-dependency branch from2ff6fef tobd045e9CompareNovember 17, 2025 18:22
@EhabYEhabY merged commitfa2272a intocoder:mainNov 17, 2025
3 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@code-ashercode-ashercode-asher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EhabY@code-asher

[8]ページ先頭

©2009-2025 Movatter.jp