Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Show Remote SSH Output panel on workspace start#627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
EhabY wants to merge9 commits intocoder:main
base:main
Choose a base branch
Loading
fromEhabY:show-remote-ssh-output-on-start

Conversation

@EhabY
Copy link
Collaborator

Closes#626

@EhabYEhabYforce-pushed theshow-remote-ssh-output-on-start branch frombbb0391 to92b1788CompareOctober 17, 2025 13:13
@EhabYEhabYforce-pushed theshow-remote-ssh-output-on-start branch 2 times, most recently from719de6f tofe6d1dcCompareOctober 23, 2025 10:31
Copy link
Member

@code-ashercode-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I have not had a chance to try it yet, but it is looking really good!

Copy link
Member

@code-ashercode-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looking really good! I think we just need to tweak how we handle the timeout and error states, and then we are good to go.

@EhabYEhabYforce-pushed theshow-remote-ssh-output-on-start branch frome3c9e7f toae04b2cCompareOctober 30, 2025 12:11
@EhabYEhabYforce-pushed theshow-remote-ssh-output-on-start branch fromae04b2c toad6ea8cCompareOctober 30, 2025 12:46
@EhabYEhabYforce-pushed theshow-remote-ssh-output-on-start branch fromad6ea8c tobc4ba72CompareOctober 30, 2025 12:54
Copy link
Member

@code-ashercode-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Awesome!! I experimented with it and it has a few quirks when I try to stop my workspace while it waits for scripts, but otherwise looks excellent.

Copy link
Member

@code-ashercode-asher left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I know the scope ballooned on this lol but this is really cool, it can handle anything thrown at it. Just noticed one more small thing where I get no agent script log the second time, but otherwise looks good!

case"starting":
case"stopping":
// Clear the agent ID since it could change after a restart
this.agentId=undefined;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think we need to clear the agent socket here as well or something, when I stop my workspace and it starts again, I do not see the agent script logs the second time.

Or, maybe we clear the socket when the agent closes, or both.

Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I fixed this here but I do not know how to re-produce? Can you give it a go or give me the steps?

@EhabYEhabYforce-pushed theshow-remote-ssh-output-on-start branch fromb342a11 tod8beda6CompareNovember 9, 2025 19:47
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@code-ashercode-ashercode-asher approved these changes

Assignees

@EhabYEhabY

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Show agent startup script when connecting to a Workspace

2 participants

@EhabY@code-asher
[8]ページ先頭
©2009-2025 Movatter.jp