- Notifications
You must be signed in to change notification settings - Fork34
Pass the header command output to WebSocket creation#619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
| ...headers, | ||
| ...(token ?{[coderSessionTokenHeader]:token} :{}), | ||
| ...configs.options?.headers, | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Does this order make sense? (From lowest to highest)
- Header args
- Token taken from the axios instance
- Explicitly passed headers
| constheaders=awaitgetHeaders( | ||
| baseUrlRaw, | ||
| getHeaderCommand(vscode.workspace.getConfiguration()), | ||
| this.output, | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Actual fix, we now read the headers and pass them to the websocket. The rest of the changes just propagate the non-async -> async change here
Closes#618