- Notifications
You must be signed in to change notification settings - Fork34
Add search filter to Coder Workspaces tree views#603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
c274710
tof558120
CompareEhabY commentedSep 30, 2025
Uh oh!
There was an error while loading.Please reload this page.
EhabY commentedSep 30, 2025
Uh oh!
There was an error while loading.Please reload this page.
f558120
to017ad5f
Compareaslilac approved these changesOct 1, 2025
Uh oh!
There was an error while loading.Please reload this page.
66377d2
intocoder:main 2 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#330
Adds a search filter for both views "My Workspaces" and "All Workspaces", this depends on the VS Code command
list.find
so support fuzzy match and filtering but does not differentiate between nodes (so we filter on everything not just workspaces or agents... etc).Also, I have add
id
s to all tree items, this guarantees that the expansion state stays the same between refreshes.One downside to using this method is that whenever the tree view refreshes (which is every ~1s) the focus is shifted to the tree instead of the input. I tried to implement selective refreshing such that we refresh only the affected nodes but that didn't fix it :/. See:
Screencast.from.2025-09-08.15-32-59.webm