- Notifications
You must be signed in to change notification settings - Fork34
Refactor storage.ts into testable modules and add unit tests#589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
878914a
to4ae208b
CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Excellent! The only thing I think maybe needs a double-check before merging is theuseCustom
with the proposed API. If you want to merge and address the rest later, I think that is chill, or you could do it here, up to you!
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
4ae208b
toac418d1
Compare52df12c
intocoder:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Closes#588
This PR refactors
storage.ts
into small, isolated modules that are straightforward to unit test (with mocks). It also upgradesvitest
to a version that plays nicely with VS Code extensions, so we can view coverage, run and debug tests directly in VS Code.VS Code Test Explorer:
Screencast.from.2025-09-22.16-54-03.webm
Why mock
vscode
?With the current VS Code Extension API, we essentially have two testing layers:
vscode
) : Validate our module's behavior independently of the VS Code API and external calls (e.g., Axios). These are fast, reliable, and cover most logic.By mocking
vscode
for unit tests, we keep feedback tight and deterministic, while reserving integration tests for end-to-end scenarios that require the actual runtime.