Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add logging on all RESTful and WebSocket requests in VS Code#580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
EhabY merged 9 commits intocoder:mainfromEhabY:add-logging-on-all-requests
Sep 17, 2025

Conversation

EhabY
Copy link
Collaborator

@EhabYEhabY commentedSep 9, 2025•
edited
Loading

Fixes#532

This PR introduces several enhancements to improve logging and consistency:

  1. Axios Logging Interceptor
    Added a logging interceptor to the Axios instance during its creation. Each request is tagged with a unique UUID, allowing us to correlate it with its corresponding response and measure the total in-flight time. To avoid excessive noise, response bodies are deliberately excluded from the logs as they were too verbose and difficult to read.

  2. Unified WebSocket Creation
    Consolidated WebSocket creation logic by standardizing on aOneWayWebSocket. For VS Code, this uses thews Node library. Previously, there were two separate places creating their own WebSocket connections and another two relying on SSE. These SSE implementations were converted to one-way WebSockets for improved consistency and performance. Additional logging was also added to track WebSocket creation, errors, and closure events.

For now, the logging level is set totrace for non-error logs anderror for errors. This can easily be adjusted later. I have also isolated the logging logic inlogging so it's all in one place. Let me know if we want to add more details or possibly remove some.

@EhabYEhabYforce-pushed theadd-logging-on-all-requests branch fromeb8a0a3 to2f0593dCompareSeptember 9, 2025 09:41
@EhabYEhabYforce-pushed theadd-logging-on-all-requests branch 2 times, most recently from2285279 toe32ba50CompareSeptember 10, 2025 08:52
Copy link
Member

@code-ashercode-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I have not had a chance to run it yet (hopefully tomorrow) but gave it a first pass and it is looking fantastic!

EhabY reacted with heart emoji
@EhabYEhabYforce-pushed theadd-logging-on-all-requests branch frome64e992 toe97e687CompareSeptember 11, 2025 13:01
@EhabYEhabYforce-pushed theadd-logging-on-all-requests branch fromd33d380 to6739540CompareSeptember 12, 2025 15:38
@code-asher
Copy link
Member

code-asher commentedSep 12, 2025•
edited
Loading

Feel free to re-request a review whenever you are ready for a new one!

@EhabYEhabYforce-pushed theadd-logging-on-all-requests branch fromc1cf229 to5ae5b5aCompareSeptember 15, 2025 08:06
@EhabY
Copy link
CollaboratorAuthor

Feel free to re-request a review whenever you are ready for a new one!

Ready for re-review 🙏

Copy link
Member

@code-ashercode-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Tried it out and it looks glorious

EhabY reacted with heart emoji
@code-asher
Copy link
Member

One other minor note: The comment forWorkspaceMonitor mentionsSSE still.

EhabY reacted with thumbs up emoji

@code-asher
Copy link
Member

code-asher commentedSep 15, 2025•
edited
Loading

I have to admit the(?b) does look kinda confusing, what do you think? Maybe??? B to match for example533 B would be better? Or...(>= 0 B), idk. Maybe we should try calculating the size by looking at the body?

@EhabY
Copy link
CollaboratorAuthor

I have to admit the(?b) does look kinda confusing, what do you think? Maybe??? B to match for example533 B would be better? Or...(>= 0 B), idk. Maybe we should try estimating the size by looking at the body?

With estimation it looks like this (I simply useJSON.stringify(body)):

2025-09-16 12:03:27.474 [trace] → 79d177f5 GET /api/v2/workspaces?q=owner%3Ame (??? B)2025-09-16 12:03:28.308 [trace] ← 79d177f5 200 GET /api/v2/workspaces?q=owner%3Ame (~5.48 kB) 834ms

Or possibly default to0:

2025-09-16 12:09:31.970 [trace] → 238d9059 GET /api/v2/workspaces?q=owner%3Ame (0 B)2025-09-16 12:09:32.862 [trace] ← 238d9059 200 GET /api/v2/workspaces?q=owner%3Ame (~5.48 kB) 892ms

But I just realized that showing this info forGET requests is a bit useless since those do not have a body anyway (always 0).

@code-asher
Copy link
Member

code-asher commentedSep 16, 2025•
edited
Loading

I like it with the estimation!

But I just realized that showing this info for GET requests is a bit useless since those do not have a body anyway (always 0).

Ohhhhh yeah good point. Personally I like the consistency of always seeing bytes, but I will defer to you if you want to remove it for get requests or show zero. 👌

@EhabY
Copy link
CollaboratorAuthor

I like it with the estimation!

But I just realized that showing this info for GET requests is a bit useless since those do not have a body anyway (always 0).

Ohhhhh yeah good point. Personally I like the consistency of always seeing bytes, but I will defer to you if you want to remove it for get requests or show zero. 👌

For consistency I'll show 0 for now, I was just worried it'll cause confusion since people might assume that a0 byte is an error

code-asher reacted with thumbs up emoji

@EhabYEhabYforce-pushed theadd-logging-on-all-requests branch from723960d tof87f941CompareSeptember 17, 2025 09:10
@EhabYEhabY merged commitac10249 intocoder:mainSep 17, 2025
2 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@code-ashercode-ashercode-asher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add debug logging around requests

2 participants

@EhabY@code-asher
[8]ページ先頭
©2009-2025 Movatter.jp