Axios Logging Interceptor
Added a logging interceptor to the Axios instance during its creation. Each request is tagged with a unique UUID, allowing us to correlate it with its corresponding response and measure the total in-flight time. To avoid excessive noise, response bodies are deliberately excluded from the logs as they were too verbose and difficult to read.
Unified WebSocket Creation
Consolidated WebSocket creation logic by standardizing on aOneWayWebSocket. For VS Code, this uses thews Node library. Previously, there were two separate places creating their own WebSocket connections and another two relying on SSE. These SSE implementations were converted to one-way WebSockets for improved consistency and performance. Additional logging was also added to track WebSocket creation, errors, and closure events.

For now, the logging level is set totrace for non-error logs anderror for errors. This can easily be adjusted later. I have also isolated the logging logic inlogging so it's all in one place. Let me know if we want to add more details or possibly remove some.

EhabY force-pushed theadd-logging-on-all-requests branch fromeb8a0a3 to2f0593dCompare

September 9, 2025 09:41

EhabY commented

Sep 9, 2025

View reviewed changes

src/api.ts OutdatedShow resolvedHide resolved

src/websocket/oneWayCodeWebSocket.tsShow resolvedHide resolved

src/workspaceMonitor.ts OutdatedShow resolvedHide resolved

src/extension.ts OutdatedShow resolvedHide resolved

EhabY force-pushed theadd-logging-on-all-requests branch 2 times, most recently from2285279 toe32ba50Compare

September 10, 2025 08:52

code-asher reviewed

Sep 10, 2025

View reviewed changes

Copy link

Member

code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I have not had a chance to run it yet (hopefully tomorrow) but gave it a first pass and it is looking fantastic!

src/api.ts OutdatedShow resolvedHide resolved

src/agentMetadataHelper.tsShow resolvedHide resolved

src/api.ts OutdatedShow resolvedHide resolved

src/websocket/oneWayCodeWebSocket.tsShow resolvedHide resolved

src/websocket/webSocketClient.ts OutdatedShow resolvedHide resolved

src/workspaceMonitor.ts OutdatedShow resolvedHide resolved

src/websocket/webSocketClient.ts OutdatedShow resolvedHide resolved

EhabY force-pushed theadd-logging-on-all-requests branch frome64e992 toe97e687Compare

September 11, 2025 13:01

EhabY commented

Sep 11, 2025

View reviewed changes

src/logging/netLog.ts OutdatedShow resolvedHide resolved

EhabY force-pushed theadd-logging-on-all-requests branch fromd33d380 to6739540Compare

September 12, 2025 15:38

Copy link

Member

code-asher commentedSep 12, 2025•
edited
Loading

Feel free to re-request a review whenever you are ready for a new one!

EhabY requested a review fromcode-asher

September 14, 2025 20:04

EhabY force-pushed theadd-logging-on-all-requests branch fromc1cf229 to5ae5b5aCompare

September 15, 2025 08:06

Copy link

CollaboratorAuthor

EhabY commentedSep 15, 2025

Feel free to re-request a review whenever you are ready for a new one!

Ready for re-review 🙏

code-asher approved these changes

Sep 15, 2025

View reviewed changes

Copy link

Member

code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Tried it out and it looks glorious

src/api/auth.tsShow resolvedHide resolved

src/api/codeApi.ts OutdatedShow resolvedHide resolved

src/commands.tsShow resolvedHide resolved

CHANGELOG.md OutdatedShow resolvedHide resolved

src/logging/httpLogger.ts OutdatedShow resolvedHide resolved

CHANGELOG.md OutdatedShow resolvedHide resolved

src/logging/httpLogger.ts OutdatedShow resolvedHide resolved

Copy link

Member

code-asher commentedSep 15, 2025

One other minor note: The comment forWorkspaceMonitor mentionsSSE still.

Copy link

Member

code-asher commentedSep 15, 2025•
edited
Loading

I have to admit the(?b) does look kinda confusing, what do you think? Maybe??? B to match for example533 B would be better? Or...(>= 0 B), idk. Maybe we should try calculating the size by looking at the body?

code-asher reviewed

Sep 15, 2025

View reviewed changes

src/logging/wsLogger.ts OutdatedShow resolvedHide resolved

Copy link

CollaboratorAuthor

EhabY commentedSep 16, 2025

I have to admit the(?b) does look kinda confusing, what do you think? Maybe??? B to match for example533 B would be better? Or...(>= 0 B), idk. Maybe we should try estimating the size by looking at the body?

With estimation it looks like this (I simply useJSON.stringify(body)):

2025-09-16 12:03:27.474 [trace] → 79d177f5 GET /api/v2/workspaces?q=owner%3Ame (??? B)2025-09-16 12:03:28.308 [trace] ← 79d177f5 200 GET /api/v2/workspaces?q=owner%3Ame (~5.48 kB) 834ms

Or possibly default to0:

2025-09-16 12:09:31.970 [trace] → 238d9059 GET /api/v2/workspaces?q=owner%3Ame (0 B)2025-09-16 12:09:32.862 [trace] ← 238d9059 200 GET /api/v2/workspaces?q=owner%3Ame (~5.48 kB) 892ms

But I just realized that showing this info forGET requests is a bit useless since those do not have a body anyway (always 0).

Copy link

Member

code-asher commentedSep 16, 2025•
edited
Loading

I like it with the estimation!

But I just realized that showing this info for GET requests is a bit useless since those do not have a body anyway (always 0).

Ohhhhh yeah good point. Personally I like the consistency of always seeing bytes, but I will defer to you if you want to remove it for get requests or show zero. 👌

EhabY added8 commits

September 17, 2025 11:15

Add logging interceptor for axios + Refactor WS (WIP)

701719d

Unify WS implementations across VS Code

d5b0da4

Improve logging and isolate it into a separate file

bce9d2a

Review comments

abb2ebd

Create CodeApi and separate the API methods

0824a13

Refactor the logging and addcoder.httpClientLogLevel setting

b69f187

Add changelog + smol refactoring

6e29413

..

More review comments fixes

3ac0272

Copy link

CollaboratorAuthor

EhabY commentedSep 17, 2025

I like it with the estimation!
But I just realized that showing this info for GET requests is a bit useless since those do not have a body anyway (always 0).
Ohhhhh yeah good point. Personally I like the consistency of always seeing bytes, but I will defer to you if you want to remove it for get requests or show zero. 👌

For consistency I'll show 0 for now, I was just worried it'll cause confusion since people might assume that a0 byte is an error

Review comments and rebase fallout

f87f941

EhabY force-pushed theadd-logging-on-all-requests branch from723960d tof87f941Compare

September 17, 2025 09:10

EhabY merged commitac10249 intocoder:main

Sep 17, 2025

2 checks passed

This was referencedSep 17, 2025

Test SSE connections are not leaked#481

Open

Add a way to get failed request details#277

Open

davo-canva mentioned this pull request

Oct 2, 2025

TypeError: Converting circular structure to JSON when downloading Coder binary#606

Closed

EhabY mentioned this pull request

Oct 9, 2025

Add SSE fallback for the new WebSocket API endpoints#620

Open

Labels

None yet

2 participants

Movatterモバイル変換

Add logging on all RESTful and WebSocket requests in VS Code#580

Add logging on all RESTful and WebSocket requests in VS Code#580

Uh oh!

Conversation

EhabY commentedSep 9, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

code-asher left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

code-asher commentedSep 12, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

EhabY commentedSep 15, 2025

Uh oh!

code-asher left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

code-asher commentedSep 15, 2025

Uh oh!

code-asher commentedSep 15, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

Uh oh!

EhabY commentedSep 16, 2025

Uh oh!

code-asher commentedSep 16, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

EhabY commentedSep 17, 2025

Uh oh!

Uh oh!

Uh oh!

EhabY commentedSep 9, 2025•
edited
Loading

code-asher commentedSep 12, 2025•
edited
Loading

code-asher commentedSep 15, 2025•
edited
Loading

code-asher commentedSep 16, 2025•
edited
Loading