- Notifications
You must be signed in to change notification settings - Fork34
Add confirmation prompt to workspace update action#557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Adds a warning dialog with explicit consent before updating workspace.Includes warning text about workspace restart and potential data loss.Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
src/commands.ts Outdated
| useCustom:true, | ||
| modal:true, | ||
| detail:`Update${this.workspace.owner_name}/${this.workspace.name} to the latest version?`, | ||
| detail:`Update${this.workspace.owner_name}/${this.workspace.name} to the latest version?\n\nUpdating will restart your workspace and stop any running processes that may result in loss of unsaved work.`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
To me "that" implies the stopping of processes results in the loss of work, but really the restart is what does it. "And" might be a bit better, although "and" could also be interpreted this way so idk.
But this does match the wording used in coder/coder more: "Updating will restart your workspace which stops any running processes and may result in the loss of unsaved work."
Use 'which stops' instead of 'and stop' to clarify that the restartcauses the process stopping and potential data loss.Co-authored-by: kylecarbs <7122116+kylecarbs@users.noreply.github.com>
2d7dac8 intomainUh oh!
There was an error while loading.Please reload this page.
This PR adds a confirmation prompt to the workspace update action to prevent accidental updates that could result in data loss.
Changes:
showInformationMessagetoshowWarningMessageto better indicate the destructive natureTesting:
Fixes the issue where users accidentally trigger workspace updates without understanding the consequences.