- Notifications
You must be signed in to change notification settings - Fork35
fix: construct full path for workspaceLogPath instead of just filename#554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The workspaceLogPath was being set to just the log filename instead of thefull path, causing VS Code to fail when trying to open the log file with'Unable to resolve nonexistent file' errors.This fix ensures that path.join(logDir, logFileName) is used to constructthe complete file path, allowing the 'View Logs' command to work properlywhen coder.proxyLogDirectory is configured.Fixes the issue where log files like 'coder-ssh-20250716-123428-qvict-90716.log'could not be opened because they were referenced by filename only.Co-authored-by: ibetitsmike <203725896+ibetitsmike@users.noreply.github.com>
code-asher approved these changesJul 16, 2025
Member
code-asher commentedJul 16, 2025
Good catch, seems we accidentally lost the original |
8dee463 intomain 2 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Member
matifali commentedJul 23, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@deansheather Does this look related to#560,#542? |
Member
deansheather commentedJul 23, 2025
IDK, it might fix it though. |
Member
matifali commentedJul 23, 2025
Let's test again after we have a new release and we can close those issues. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The VS Code extension was failing to open SSH proxy log files with the error:
This occurred because
workspaceLogPathwas being set to just the filename instead of the full path, causing VS Code to look for the file in the wrong location.Solution
Modified the code in
src/remote.tsto properly construct the full path usingpath.join(logDir, logFileName)instead of just storing the filename.Before:
After:
Testing
/tmp/coder-logs/coder-ssh-20250716-123428-qvict-90716.logThis fix ensures that when users configure the
coder.proxyLogDirectorysetting and use the "View Logs" command, VS Code can successfully open the SSH proxy log files.