tested locally and this diff seems to work fine. could we sneak it in here?

diff --git a/src/commands.ts b/src/commands.tsindex c1d49f9..375bca4 100644--- a/src/commands.ts+++ b/src/commands.ts@@ -620,18 +620,18 @@ export class Commands {  *  * Throw if not logged into a deployment.  */-public async openDevContainer(...args: string[]): Promise<void> {+public async openDevContainer(+workspaceOwner: string,+workspaceName: string,+workspaceAgent: string,+devContainerName: string,+devContainerFolder: string,+): Promise<void> { const baseUrl = this.restClient.getAxiosInstance().defaults.baseURL; if (!baseUrl) { throw new Error("You are not logged in"); }-const workspaceOwner = args[0] as string;-const workspaceName = args[1] as string;-const workspaceAgent = args[2] as string;-const devContainerName = args[3] as string;-const devContainerFolder = args[4] as string;- await openDevContainer( baseUrl, workspaceOwner,

you can add your new arguments to the end as optional

@aslilac made the proposed changes 👍🏻

I really don't know enough about dev containers or this extensions code to feel comfortable approving, but I did have a couple notes

Understandable. 👍🏻

@DanielleMaywood researched this topic in the past and came to the conclusion thatdev-container creates a new one, andattached-container works as we want. However, we recently discovered thatattached-container is likely meant for attaching to a Docker container that's not necessarily a Dev Container since the VS Code extension disables some features.

These APIs are totally undocumented and have been reverse-engineered. With some additional effort we discovered thatdev-container can be used to attach to a running dev container given the right inputs.

More context at:coder/coder#16426 (comment)