Jun 25, 2025 · Jun 24, 2025 · Jun 24, 2025 · Jun 24, 2025 · Jun 24, 2025 · Jun 24, 2025
diff --git a/.git-blame-ignore-revs b/.git-blame-ignore-revs
 # If you would like `git blame` to ignore commits from this file, run:
 # git config blame.ignoreRevsFile .git-blame-ignore-revs

 # chore: simplify prettier config (#528)
 f785902f3ad20d54344cc1107285c2a66299c7f6
diff --git a/src/commands.ts b/src/commands.ts
 } else {
 workspaceOwner = args[0] as string;
 workspaceName = args[1] as string;
 //workspaceAgentis reserved forargs[2], but multiple agents aren't supported yet.
 workspaceAgent=args[2] as string | undefined;
 folderPath = args[3] as string | undefined;
 openRecent = args[4] as boolean | undefined;
 }

 const workspaceOwner = args[0] as string;
 const workspaceName = args[1] as string;
 const workspaceAgent =undefined; //args[2]is reserved, but we do not support multiple agents yet.
 const workspaceAgent = args[2]as string;
 const devContainerName = args[3] as string;
 const devContainerFolder = args[4] as string;

 baseUrl: string,
 workspaceOwner: string,
 workspaceName: string,
 workspaceAgent: string | undefined,
 workspaceAgent: string,
 devContainerName: string,
 devContainerFolder: string,
 ) {
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,5 @@
		# If you would like `git blame` to ignore commits from this file, run:
		# git config blame.ignoreRevsFile .git-blame-ignore-revs

		# chore: simplify prettier config (#528)
		f785902f3ad20d54344cc1107285c2a66299c7f6
Copy link Member mafredriJun 24, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. What's the purpose of this? Copy link MemberAuthor ethanndicksonJun 24, 2025• edited Loading Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. We have the same file on`coder/coder` - it's just a convenient way to remove a formatting commit from`git blame` results. I noticed every line was blamed on#528. No longer the case after running`git config blame.ignoreRevsFile .git-blame-ignore-revs` mafredri reacted with thumbs up emoji
Original file line number	Diff line number	Diff line change
Expand Up		@@ -600,7 +600,7 @@ export class Commands {
		} else {
		workspaceOwner = args[0] as string;
		workspaceName = args[1] as string;
		//workspaceAgentis reserved forargs[2], but multiple agents aren't supported yet.
		workspaceAgent=args[2] as string \| undefined;
		folderPath = args[3] as string \| undefined;
		openRecent = args[4] as boolean \| undefined;
		}
Expand DownExpand Up		@@ -628,7 +628,7 @@ export class Commands {

		const workspaceOwner = args[0] as string;
		const workspaceName = args[1] as string;
		const workspaceAgent =undefined; //args[2]is reserved, but we do not support multiple agents yet.
		const workspaceAgent = args[2]as string;
Copy link MemberAuthor ethanndicksonJun 24, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. `openDevcontainer` URIs must include the agent name to work properly, I believe, so this is`string` and not`string \| undefined`. mafredri reacted with thumbs up emoji
		const devContainerName = args[3] as string;
		const devContainerFolder = args[4] as string;

Expand DownExpand Up		@@ -748,7 +748,7 @@ async function openDevContainer(
		baseUrl: string,
		workspaceOwner: string,
		workspaceName: string,
		workspaceAgent: string \| undefined,
		workspaceAgent: string,
		devContainerName: string,
		devContainerFolder: string,
		) {
Expand Down