Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: update Node.js version to 20#522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
matifali merged 1 commit intomainfromupdate-node20
May 28, 2025
Merged

chore: update Node.js version to 20#522

matifali merged 1 commit intomainfromupdate-node20
May 28, 2025

Conversation

matifali
Copy link
Member

@matifalimatifali commentedMay 28, 2025
edited
Loading

This PR updates the Node.js version used in CI and release workflows from 18 to 20.

Testing

  • Ran tests with Node 20 locally and all tests passed

Closes#521

@matifalimatifali requested review fromcode-asher anda teamMay 28, 2025 12:05
Copy link
Contributor

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We also need to update it in dogfood and packge.json files.

@matifali
Copy link
MemberAuthor

matifali commentedMay 28, 2025
edited
Loading

We also need to update it in dogfood and package.json files.

I do not see Node version constraint in package.json, and the dogfood image is out of scope here.

@matifalimatifali merged commit640d97f intomainMay 28, 2025
2 checks passed
@matifalimatifali deleted the update-node20 branchMay 28, 2025 13:01
matifali added a commit that referenced this pull requestMay 28, 2025
@code-asher
Copy link
Member

I see this was reverted, but when we do this again we should also update the flake.

Probably not a bad idea to usenode-version-file: .node-version instead ofnode-version in the workflow as well, and create a.node-version file with the version in it so we have just one place to control it.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

@code-ashercode-asherAwaiting requested review from code-asher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to Node 20
3 participants
@matifali@code-asher@BrunoQuaresma

[8]ページ先頭

©2009-2025 Movatter.jp