Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: support finding ssh process by port on macos sequoia#480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bcpeinhardt merged 4 commits intomainfromethan/fix-conn-indicator-sequoia
Apr 16, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedApr 15, 2025•
edited
Loading

Relates to#361.

This brings back the connection indicator, at least on macOS Sequoia.
image

The indicator is populated from a file named<sshPID>.json. The library we were using to find that PID,find-process hasn't been updated for Sequoia.

Full explanation of the necessary change can be found in an umerged PR for that library:
yibn2008/find-process#78

This change was never merged, so I've forked it into our org for now. When it gets upstreamed we can switch back.

matifali reacted with heart emoji
@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@ethanndicksonethanndicksonforce-pushed theethan/fix-conn-indicator-sequoia branch from7b1eda3 tofacb2ebCompareApril 15, 2025 03:38
@ethanndicksonethanndickson marked this pull request as ready for reviewApril 15, 2025 03:42
Copy link
Member

@matifalimatifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Thanks@ethanndickson

@ethanndicksonethanndicksonforce-pushed theethan/fix-conn-indicator-sequoia branch from86f3458 tof6c1272CompareApril 15, 2025 08:17
Copy link
Member

@code-ashercode-asher left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Interesting thatfind-process execsnetstat instead of reading/proc directly. Although, maybe that is not possible on macOS?

In any case, looks good to me. If we ever implement our own connection code we will be able to get the PID more easily. 🤞

ethanndickson and matifali reacted with heart emoji
@ethanndickson
Copy link
MemberAuthor

Will need someone else to merge, as I don't have permission!

@bcpeinhardtbcpeinhardt merged commit1fb0f02 intomainApr 16, 2025
3 checks passed
@bcpeinhardtbcpeinhardt deleted the ethan/fix-conn-indicator-sequoia branchApril 16, 2025 01:39
@matifali
Copy link
Member

If we ever implement our own connection code we will be able to get the PID more easily. 🤞

This is becoming more than a want now, and we may actually need this soon.

code-asher reacted with thumbs up emoji

@matifali
Copy link
Member

@ethanndickson, I am noticing a better reconnection flow after this PR. When my device returns from sleep, VS Code auto-reconnects without me pressing the reload button.

This may probably solve#413.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@matifalimatifalimatifali approved these changes

@code-ashercode-ashercode-asher approved these changes

@bcpeinhardtbcpeinhardtAwaiting requested review from bcpeinhardt

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@ethanndickson@matifali@code-asher@bcpeinhardt
[8]ページ先頭
©2009-2025 Movatter.jp