Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: Inject coder ssh configuration between comments#48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 23 commits intomainfrombq/fix-42
Jan 27, 2023

Conversation

BrunoQuaresma
Copy link
Contributor

No description provided.

@BrunoQuaresmaBrunoQuaresma self-assigned thisJan 25, 2023
@BrunoQuaresmaBrunoQuaresma changed the titlefix: Removes first matching Host blockfix: Inject coder ssh configuration between commentsJan 25, 2023
@BrunoQuaresma
Copy link
ContributorAuthor

Closes#42

@BrunoQuaresma
Copy link
ContributorAuthor

@mafredri so just to think out loud the logic here:

  • Check if there are only one start and end block comment. If there is more than one, show a "bad format" error.
  • Check if the start block is placed previously than the end block. If not, show a "bad format" error.
  • Remove the text
  • Add the new config

Does it look right?

@mafredri
Copy link
Member

Does it look right?

Yup, that sounds perfect@BrunoQuaresma. 👍🏻

@BrunoQuaresma
Copy link
ContributorAuthor

I wanted to add some tests to theSSHConfig but I figure out the testing runner for this project needs some extra work so I decided to not do it on this PR.

Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looking good. Still had some pretty minor but probably important (for good user experience) nits.

Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for fixing the nits. Code looks good to me, but I haven't tested the extension so might be good to have another set of eyes on it.

BrunoQuaresma reacted with heart emoji
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@kylecarbskylecarbskylecarbs approved these changes

@mafredrimafredriAwaiting requested review from mafredri

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BrunoQuaresma@mafredri@kylecarbs
[8]ページ先頭
©2009-2025 Movatter.jp