Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix version comparison logic for checking wildcard support in "coder ssh"#446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletionsCHANGELOG.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,7 @@
- Remove agent singleton so that client TLS certificates are reloaded on every API request.
- Use Axios client to receive event stream so TLS settings are properly applied.
- Set `usage-app=vscode` on `coder ssh` to fix deployment session counting.
- Fix version comparison logic for checking wildcard support in "coder ssh"

## [v1.4.1](https://github.com/coder/vscode-coder/releases/tag/v1.4.1) (2025-02-19)

Expand Down
8 changes: 8 additions & 0 deletionssrc/featureSet.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,4 +11,12 @@ describe("check version support", () => {
expect(featureSetForVersion(semver.parse(v)).proxyLogDirectory).toBeTruthy()
})
})
it("wildcard ssh", () => {
;["v1.3.3+e491217", "v2.3.3+e491217"].forEach((v: string) => {
expect(featureSetForVersion(semver.parse(v)).wildcardSSH).toBeFalsy()
})
;["v2.19.0", "v2.19.1", "v2.20.0+e491217", "v5.0.4+e491217"].forEach((v: string) => {
expect(featureSetForVersion(semver.parse(v)).wildcardSSH).toBeTruthy()
})
})
})
2 changes: 1 addition & 1 deletionsrc/featureSet.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,6 +22,6 @@ export function featureSetForVersion(version: semver.SemVer | null): FeatureSet
// If this check didn't exist, VS Code connections would fail on
// older versions because of an unknown CLI argument.
proxyLogDirectory: (version?.compare("2.3.3") || 0) > 0 || version?.prerelease[0] === "devel",
wildcardSSH: (version?.compare("2.19.0")|| 0) > 0 || version?.prerelease[0] === "devel",
wildcardSSH: (version ? version.compare("2.19.0"): -1) >= 0 || version?.prerelease[0] === "devel",
}
}

[8]ページ先頭

©2009-2025 Movatter.jp