Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix version comparison logic for checking wildcard support in "coder ssh"#446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

aaronlehmann
Copy link
Contributor

This meant to check that the version was at least 2.19.0, but the logic was faulty.

…ssh"This meant to check that the version was at least 2.19.0, but the logicwas faulty.
@bcpeinhardt
Copy link
Collaborator

bcpeinhardt commentedMar 7, 2025•
edited
Loading

Ah damn thanks for the fix on that. The version check on proxyLogDirectory is a bit misleading with it being released in 1.3.2. I wonder if I should back port this as a patch 🤔 tbh I think most everyone auto updates, even to major versions.

@bcpeinhardtbcpeinhardt merged commitf0740e8 intocoder:mainMar 7, 2025
2 checks passed
@aaronlehmann
Copy link
ContributorAuthor

Fortunately it's a harmless error.vscodessh still works fine with Coder 2.19, and switching tossh is really a cleanup.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@bcpeinhardtbcpeinhardtbcpeinhardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@aaronlehmann@bcpeinhardt
[8]ページ先頭
©2009-2025 Movatter.jp